From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ViSA5-0001UC-8y for mharc-grub-devel@gnu.org; Mon, 18 Nov 2013 11:58:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViS9y-0001T3-8W for grub-devel@gnu.org; Mon, 18 Nov 2013 11:58:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ViS9p-0006RQ-PQ for grub-devel@gnu.org; Mon, 18 Nov 2013 11:58:50 -0500 Received: from mail-ee0-x230.google.com ([2a00:1450:4013:c00::230]:37272) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViS9p-0006RH-Iw for grub-devel@gnu.org; Mon, 18 Nov 2013 11:58:41 -0500 Received: by mail-ee0-f48.google.com with SMTP id e49so2642772eek.21 for ; Mon, 18 Nov 2013 08:58:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=XjMs4W928ufHjpW7tj0GGbXsewpCHfQLZKdhSTLjFS4=; b=yLCE/QIvcdg1WpUDUCm3cMUExptuzxxGW4WkpJcnZhWb86VsZ7iIdVrhoPwkZvuUvi EOuV7Rdkijoby1+YDH6x2kKYar3IZsqiVeLddljIGFEgI1jv2izJJXq3w0ONZ748TwWO whdhxzWqa2Zu9p9uqbFTC1FUOdyDbZNCbx9Snt/B1tumYbHS+EsGrKD6FOH8ksvhOJgC pAG4u/EdcacJZnHLB+xq8qdDi/s8zeYXrY5/+acz4WdyAJOIlTzu5/1BeDvPwzjY+OCl K39uO0cxeg4Rp3Upk0/IXhCNw4LC7ZRsmOLuBxsi5bFipjE6Blq0RM/XuGqnBlIzXYXZ +iiw== X-Received: by 10.14.47.75 with SMTP id s51mr1436339eeb.97.1384793920566; Mon, 18 Nov 2013 08:58:40 -0800 (PST) Received: from [192.168.1.16] (31-249.1-85.cust.bluewin.ch. [85.1.249.31]) by mx.google.com with ESMTPSA id j46sm39640958eew.18.2013.11.18.08.58.39 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 18 Nov 2013 08:58:39 -0800 (PST) Message-ID: <528A473D.8030702@gmail.com> Date: Mon, 18 Nov 2013 17:58:37 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH 2/4] efi: Fix requests to allocate GRUB_MEMORY_AVAILABLE References: <04626043f86011c00505e719d84d40ef155ce312.1384309081.git.josh@joshtriplett.org> In-Reply-To: <04626043f86011c00505e719d84d40ef155ce312.1384309081.git.josh@joshtriplett.org> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2PQARRPGSVTCOIFJUAMJM" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::230 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Nov 2013 16:58:55 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2PQARRPGSVTCOIFJUAMJM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 13.11.2013 03:26, Josh Triplett wrote: > EFI firmware refuses to allocate memory of type > GRUB_EFI_CONVENTIONAL_MEMORY, because that indicates a block of > available memory that other allocations (or the OS) would then step on.= > Map GRUB_MEMORY_AVAILABLE to GRUB_EFI_LOADER_CODE instead. > --- >=20 > ChangeLog entry: >=20 > 2013-11-13 Josh Triplett >=20 > * grub-core/mmap/efi/mmap.c (make_efi_memtype): Map > GRUB_MEMORY_AVAILABLE to GRUB_EFI_LOADER_CODE rather than > GRUB_EFI_CONVENTIONAL_MEMORY. EFI firmware refuses to allocate > memory of type GRUB_EFI_CONVENTIONAL_MEMORY, because that > indicates a block of available memory that other allocations (or > the OS) would then step on. >=20 "allocating" with type GRUB_MEMORY_AVAILABLE isn't actually allocating but declaring a new chunk of available memory not discovered by firmware. Up until now we've never actually needed it > grub-core/mmap/efi/mmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/grub-core/mmap/efi/mmap.c b/grub-core/mmap/efi/mmap.c > index a77efe8..e6cd185 100644 > --- a/grub-core/mmap/efi/mmap.c > +++ b/grub-core/mmap/efi/mmap.c > @@ -146,7 +146,7 @@ make_efi_memtype (int type) > return GRUB_EFI_UNUSABLE_MEMORY; > =20 > case GRUB_MEMORY_AVAILABLE: > - return GRUB_EFI_CONVENTIONAL_MEMORY; > + return GRUB_EFI_LOADER_CODE; > =20 > case GRUB_MEMORY_ACPI: > return GRUB_EFI_ACPI_RECLAIM_MEMORY; >=20 ------enig2PQARRPGSVTCOIFJUAMJM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKKRz0ACgkQmBXlbbo5nOtuQgD/e6AU7mtTYZSpL1hI1Tq7pIwj GOAnH7whsbjygc3ghOwA/ihsuVOQWUv9lIwGF4A1VfPAGizVoATZ7Ja1MiySRZwv =utZm -----END PGP SIGNATURE----- ------enig2PQARRPGSVTCOIFJUAMJM--