From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VjyZo-0003KR-AX for mharc-grub-devel@gnu.org; Fri, 22 Nov 2013 16:47:48 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjxQq-0006YI-Q2 for grub-devel@gnu.org; Fri, 22 Nov 2013 15:34:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjxQm-0000AR-CQ for grub-devel@gnu.org; Fri, 22 Nov 2013 15:34:28 -0500 Received: from mail-ee0-x233.google.com ([2a00:1450:4013:c00::233]:52407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjxQl-0000AD-U8 for grub-devel@gnu.org; Fri, 22 Nov 2013 15:34:24 -0500 Received: by mail-ee0-f51.google.com with SMTP id b15so720242eek.24 for ; Fri, 22 Nov 2013 12:34:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type; bh=fgYKA9UD4yuTgm+wHZtRF9h4vaExZJPGeJo7rCPGWno=; b=KRtFSBkvgMQ9M3jjxiToat9A4S7Uz3l7xRQ3CfP42FwR+RIufdJi4NvfFfLzk8+3gf tKx73I3Aw/LMG3QSjSwHRFLG+8346r+FL/avaPlNpPbWl1gBeGQUtXDe/8X8GPyiJw6N O/L9/ee6V6aCiW9129IcRdjtlBbQGlnwGgbZqF9+5E6I/QGGnUO7uT60oCXOoSCW0yTN X3SOexlMNm19yMM0rpueuW5378FLJwrB/goqbiEulvRTPEkDhdGfFTchKMY4R9Prl3eS uBmB1eGox+czjEMHh2tdZgP5alOflHR5VNqV+fFVkEclb9SF6wY7zTJP7YrmRk0S+XzS DjNg== X-Received: by 10.14.182.199 with SMTP id o47mr18970155eem.7.1385152461375; Fri, 22 Nov 2013 12:34:21 -0800 (PST) Received: from [192.168.2.102] (p54BB7F98.dip0.t-ipconnect.de. [84.187.127.152]) by mx.google.com with ESMTPSA id a51sm80123164eeh.8.2013.11.22.12.34.19 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 22 Nov 2013 12:34:20 -0800 (PST) Message-ID: <528FBFCB.2010804@googlemail.com> Date: Fri, 22 Nov 2013 21:34:19 +0100 From: Andreas Cadhalpun User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: grub2: Patch to correct hidden timeout behavior Content-Type: multipart/mixed; boundary="------------000101060106080907050602" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::233 X-Mailman-Approved-At: Fri, 22 Nov 2013 16:47:47 -0500 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Nov 2013 20:34:33 -0000 This is a multi-part message in MIME format. --------------000101060106080907050602 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Hi, I'm using Debian with grub version 2.00-20. My /etc/default/grub configuration contains the following lines: GRUB_TIMEOUT=-1 GRUB_HIDDEN_TIMEOUT=3 Expected behavior: When booting, grub should display a three second countdown and if no key is pressed, boot the default grub entry, after the countdown finishes. Current behavior: When booting, grub displays a three second countdown and if no key is pressed, the grub menu is shown, after the countdown finishes. The problem lies in the 00_header.in script [1], specifically: if sleep$verbose --interruptible ${1} ; then set timeout=${2} fi This just always sets the countdown to GRUB_TIMEOUT, even if the sleep is not interrupted. I think it should be something like: if sleep$verbose --interruptible ${1} ; then set timeout=0 else set timeout=${2} fi I created a patch to fix this (see attachment). Please include the patch. Best regards, Andreas 1: http://git.savannah.gnu.org/cgit/grub.git/tree/util/grub.d/00_header.in --------------000101060106080907050602 Content-Type: text/x-patch; name="HIDDEN_TIMEOUT.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="HIDDEN_TIMEOUT.patch" diff -rup grub2-2.00.orig/util/grub.d/00_header.in grub2-2.00/util/grub.d/00_header.in --- grub2-2.00.orig/util/grub.d/00_header.in 2013-11-21 19:01:07.000000000 +0100 +++ grub2-2.00/util/grub.d/00_header.in 2013-11-22 19:23:22.208203853 +0100 @@ -315,6 +315,8 @@ EOF fi cat << EOF if sleep$verbose --interruptible ${1} ; then + set timeout=0 +else set timeout=${2} fi EOF --------------000101060106080907050602--