From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Vl0Kf-0000Fc-II for mharc-grub-devel@gnu.org; Mon, 25 Nov 2013 12:52:25 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vl0KY-0000ES-Aw for grub-devel@gnu.org; Mon, 25 Nov 2013 12:52:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vl0KT-0003PA-C8 for grub-devel@gnu.org; Mon, 25 Nov 2013 12:52:18 -0500 Received: from mail-ea0-x234.google.com ([2a00:1450:4013:c01::234]:35977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vl0KT-0003P6-4K for grub-devel@gnu.org; Mon, 25 Nov 2013 12:52:13 -0500 Received: by mail-ea0-f180.google.com with SMTP id f15so2666632eak.39 for ; Mon, 25 Nov 2013 09:52:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=fNmKfBTSU5/0Q//6KPqnwFhVw39s8I4w6NMMCxogc3E=; b=T0j2ErT/33IVfzfa7tLxMq41kbmboZxQVgSakijV+qN2vSo0TPJFKpsg8Fc++DzLtH RHOZwxg9uDN8KiMsRD5AYoZqxubbC1CGXBn++nYfPIJRDJoUuFovb9moPfwa3avIhqmn k1kcsGt8vsj/6KT5DkzhnolQS53PYx0bRO3QI19vbTXE3C6x0qFJVIQkXQmxXJYR9FJd k/VL3KHohkPp6RutnjcKgOeM2egQd5jssejPfsFFu6RNO34iKvxZkw9ghafJZ0V/UBlk arv713RUUy8+BKCoTBo42Hcr43IVbD8KYUZQUPpqGHEOq78aWTFhW8iDoXSFfWauLG+E F+Ew== X-Received: by 10.15.36.197 with SMTP id i45mr10093752eev.31.1385401932221; Mon, 25 Nov 2013 09:52:12 -0800 (PST) Received: from [192.168.1.121] (31-249.1-85.cust.bluewin.ch. [85.1.249.31]) by mx.google.com with ESMTPSA id v45sm1053496eef.11.2013.11.25.09.52.10 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 25 Nov 2013 09:52:11 -0800 (PST) Message-ID: <52938E36.40405@gmail.com> Date: Mon, 25 Nov 2013 18:51:50 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] Explicitly check for linking format to use for efiemu64 module References: <1385313664-5982-1-git-send-email-arvidjaar@gmail.com> <5292D0A2.8040301@gmail.com> <20131125214220.68453de4@opensuse.site> In-Reply-To: <20131125214220.68453de4@opensuse.site> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2EILASDKVBJKSEPQVCBMV" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::234 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Nov 2013 17:52:23 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2EILASDKVBJKSEPQVCBMV Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 25.11.2013 18:42, Andrey Borzenkov wrote: > =D0=92 Mon, 25 Nov 2013 05:22:58 +0100 > Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0= =B8=D1=88=D0=B5=D1=82: >=20 >>> + CFLAGS=3D"-m64 -nostdlib -O2 -mcmodel=3Dlarge -mno-red-zone" >>> + LDFLAGS=3D"-m64 -Wl,$format -nostdlib" >> You need -static as otherwise on Apple systems it will try to pull in >> the dynamic linker which we don't want (scratch comment about other >> thread, I though of adding -static everywhere but it's no necessarry >> after all) >=20 > I used the same flags as in Makefile. If -static is needed here should > not it be added to grub-core/Makefile.am as well? >=20 >>> diff --git a/grub-core/Makefile.am b/grub-core/Makefile.am >>> index e2da083..e6862b7 100644 >>> --- a/grub-core/Makefile.am >>> +++ b/grub-core/Makefile.am >>> @@ -421,7 +421,7 @@ efiemu64.o: efiemu64_c.o efiemu64_s.o $(TARGET_OB= J2ELEF) >>> $(TARGET_OBJCONV) -felf64 -nu -nd $@.bin $@ || exit 1; \ >>> rm -f $@.bin; \ >> Here the check for apple linker has to be adjusted as >> x$(EFIEMU64_LINK_FORMAT) =3D x-arch,x86_64 >=20 > Mmm ... but I assume apple linker case *did* work before and it broke > only for the case !TARGET_APPLE_LINKER. Should $(EFIEMU64_LINK_FORMAT) > be added for apple linker case as well? I have no way to test it. >=20 What I mean is that TARGET_APPLE_LINKER is conditioned on link_format. And in this case we should check for efiemu64_link_format. As for the exact command, don't worry too much about it, I'll clean it up and unify the two cases after your patch is merged. >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 ------enig2EILASDKVBJKSEPQVCBMV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKTjkoACgkQmBXlbbo5nOuwjAEAlQrs4eeSCcMgDGg2X7+Svwee bYpcx7IC/JaNPZA6t4QA/2NYrblg9PKWHfvqYFWNzWxk5EkZbJeRAkE5aRQdy98f =jquR -----END PGP SIGNATURE----- ------enig2EILASDKVBJKSEPQVCBMV--