From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Vm2HL-0002hb-Vb for mharc-grub-devel@gnu.org; Thu, 28 Nov 2013 09:09:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vm2HE-0002gF-VL for grub-devel@gnu.org; Thu, 28 Nov 2013 09:09:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vm2H5-0008VZ-S5 for grub-devel@gnu.org; Thu, 28 Nov 2013 09:09:08 -0500 Received: from mail-ea0-x230.google.com ([2a00:1450:4013:c01::230]:37644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vm2H5-0008VM-HT for grub-devel@gnu.org; Thu, 28 Nov 2013 09:08:59 -0500 Received: by mail-ea0-f176.google.com with SMTP id h14so5862439eaj.35 for ; Thu, 28 Nov 2013 06:08:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=Kk3OlbNVqY+aSoH2iLfhqbqLImMmWDoPnjA4iVDV4Po=; b=cY3GFQHhuaQnTx9JPj1m8UXgjqpdVrklRThq4zjKirNkBzyPJV9p1RqOOJaL46tUsJ gij0QO8NNi5+zH/dYfBP47s/XtIL5gPQbSx2J22DQJT+2qC+w0f/y8M1OjJlVtRXGcir 24WuuhuCKssNgVQKOpQYGtHZ/KnFY62PwqAaRmOgeOEL6mYxnUAhy4U9zdj0OMV35a6T SfI5CnFaEjFLsz7+FQIGj4ojRG6TUM7tpBztwmPia1Fa9a7LXg+7XJ/2+sfD3huTDk/l XdOyZqzJ2IkLrCJbvIONr36euG+4ivXToEsgPr840nDIG8D4ow3DeMepUVks7xYU9y8v tQBw== X-Received: by 10.14.119.1 with SMTP id m1mr5705828eeh.39.1385647738825; Thu, 28 Nov 2013 06:08:58 -0800 (PST) Received: from [192.168.42.70] (48-228.197-178.cust.bluewin.ch. [178.197.228.48]) by mx.google.com with ESMTPSA id o1sm30262047eea.10.2013.11.28.06.08.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 28 Nov 2013 06:08:57 -0800 (PST) Message-ID: <52974E75.2060003@gmail.com> Date: Thu, 28 Nov 2013 15:08:53 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [RFC][PATCH] Allow hotkeys to interrupt hidden menu References: <20130911131804.GA10979@riva.ucam.org> <20130911133129.GB10979@riva.ucam.org> <20131127234057.GA23139@riva.ucam.org> <20131128023056.GA19545@riva.ucam.org> <20131128110428.GA9590@riva.ucam.org> In-Reply-To: <20131128110428.GA9590@riva.ucam.org> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2XBJWNHSFEIBBXVVQGRWN" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::230 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Nov 2013 14:09:14 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2XBJWNHSFEIBBXVVQGRWN Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 28.11.2013 12:04, Colin Watson wrote: > On Thu, Nov 28, 2013 at 07:19:46AM +0100, Vladimir 'phcoder' Serbinenko= wrote: >> On Nov 28, 2013 3:31 AM, "Colin Watson" wrote: >>> +If this option is set to @samp{countdown} or @samp{hidden}, then, be= fore >>> +displaying the menu, GRUB will wait for the timeout set by >>> +@samp{GRUB_TIMEOUT} to expire. If @key{ESC} is pressed during that >>> time, it >>> +will display the menu and wait for input according to >>> @samp{GRUB_TIMEOUT}. >>> +If a hotkey associated with a menu entry is pressed, it will boot th= e >>> +associated menu entry immediately. If the timeout expires before ei= ther >>> of >>> +these happens, it will display the menu. >> >> What you describe here doesn=E2=80=98t serm what code is doing. Copypa= ste error? >=20 > I must be missing something. What part of this doesn't agree with the > code? >=20 > ... oh, right, if the timeout expires then it will boot the default > entry. I'll fix that, thanks. >=20 >>> diff --git a/util/grub-mkconfig.in b/util/grub-mkconfig.in >>> index ba1d4ef..50f73aa 100644 >>> --- a/util/grub-mkconfig.in >>> +++ b/util/grub-mkconfig.in >>> @@ -186,6 +186,7 @@ export GRUB_DEFAULT \ >>> GRUB_HIDDEN_TIMEOUT \ >>> GRUB_HIDDEN_TIMEOUT_QUIET \ >>> GRUB_TIMEOUT \ >>> + GRUB_TIMEOUT_STYLE \ >> >> you need button variant as well >=20 > Can you suggest a use case for that? I can understand why you might > want different timeouts in the button case, just about, but not why > you'd want an entirely different style of menu. >=20 Normal button: normal start, hidden menu Second button: diagnostic, show menu >>> + fi >>> if [ "x${GRUB_HIDDEN_TIMEOUT_QUIET}" =3D "xtrue" ] ; then >>> verbose=3D >>> + style=3D"hidden" >>> else >>> verbose=3D" --verbose" >>> + style=3D"countdown" >>> fi >>> cat << EOF >>> -if sleep$verbose --interruptible ${1} ; then >>> +if [ x\$feature_timeout_style =3D xy ] ; then >>> + set timeout_style=3D$style >>> + set timeout=3D${1} >>> +elif sleep$verbose --interruptible ${1} ; then >>> set timeout=3D${2} >> >> Is behaviour mismatch between both versions intentional? >> I see 2 ways of handling double timeout: either not supporting at all >> anymore or generate old code for it. This one seems to be mix of both >=20 > The code is somewhat inevitably confusing, I'll agree, but I don't see > the mismatch. Could you please give me an example? > if both GRUB_HIDDEN_TIMEOUT and GRUB_TIMEOUT are set the part for old GRUB will replicate old behaviour while part for new GRUB would make only one timeout. To make them align it would need set timeout=3D-1 at last line. > Thanks, >=20 ------enig2XBJWNHSFEIBBXVVQGRWN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKXTnUACgkQmBXlbbo5nOtJXwD+KdWE5VV5OYS5scjzLw1BqE75 yphcgyP6RQ9F0G1F+7sA/1Fhao3Eo5fIGVHVzljgOoe92L8r7wL1LFD06hMet4Ph =J0U7 -----END PGP SIGNATURE----- ------enig2XBJWNHSFEIBBXVVQGRWN--