From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VnM9B-0001uC-PF for mharc-grub-devel@gnu.org; Mon, 02 Dec 2013 00:34:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnM95-0001lv-3V for grub-devel@gnu.org; Mon, 02 Dec 2013 00:34:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnM8z-0005DD-Jk for grub-devel@gnu.org; Mon, 02 Dec 2013 00:34:11 -0500 Received: from mail-ea0-x22c.google.com ([2a00:1450:4013:c01::22c]:57231) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnM8z-0005D8-Cd for grub-devel@gnu.org; Mon, 02 Dec 2013 00:34:05 -0500 Received: by mail-ea0-f172.google.com with SMTP id q10so8419077ead.17 for ; Sun, 01 Dec 2013 21:34:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=oNZdfv4UA2nmNN0aMuIxGDRzioxUZs/MeC+SMI2RjYc=; b=qS+hmYKWkk2UsfAiSNzl5Wo2QZnzf3aycBx+n4d8KDOUIWTt4DN/hhhi6QSp0eY7Hi OcQ513wao1rnwrdUsddudtl+mdbZdPHOlNR6lJAG2lEsMwH00PRdOxxaRiE2nSAm3u1/ Rk6cKHsJmHZYtzonbzrH5lUJFK5b5HKX4Hx5oLq1P3mMWxx3TXaHF8BAEOnGvZ/Io+Wj 3IzQoRLLZxrtSHPrDsVzvb3Ej9sxsiKO1A2l6xMq5bctzIHEb3SFa7BIPGp0twmC1Jv3 AMoqZgMcDqFOmKOCBqiubD8H1BHNnpV1XctCKLgnLH8qNTs09iTKZ8jlN0Bq9VKWShF/ Zikg== X-Received: by 10.14.119.136 with SMTP id n8mr142830eeh.82.1385962444471; Sun, 01 Dec 2013 21:34:04 -0800 (PST) Received: from [192.168.1.16] (85-188.196-178.cust.bluewin.ch. [178.196.188.85]) by mx.google.com with ESMTPSA id 4sm54791033eed.14.2013.12.01.21.34.02 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 01 Dec 2013 21:34:03 -0800 (PST) Message-ID: <529C1BC9.5040709@gmail.com> Date: Mon, 02 Dec 2013 06:34:01 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] add grub_qsort_strcmp to use when sorting array of strings References: <1385744460-6624-1-git-send-email-arvidjaar@gmail.com> <5299C050.4040507@gmail.com> <20131130145959.0c2f158a@opensuse.site> In-Reply-To: <20131130145959.0c2f158a@opensuse.site> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2KJLJSVMDRKIJOFWWSCAM" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::22c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Dec 2013 05:34:16 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2KJLJSVMDRKIJOFWWSCAM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 30.11.2013 11:59, Andrey Borzenkov wrote: > =D0=92 Sat, 30 Nov 2013 11:39:12 +0100 > Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0= =B8=D1=88=D0=B5=D1=82: >=20 >> On 29.11.2013 18:01, Andrey Borzenkov wrote: >>> Compare function used in qsort gets arguments by reference, so strcmp= >>> cannot be used directly - it expects pointer to char, but gets pointe= r >>> to pointer to char. >>> >>> Introduce new helper grub_qsort_strcmp and use it in grub-install. >>> This helper is going to be used in a couple more places as well so >>> add it to global file, not in grub-install.c. >>> >> Nice catch. But I don't we have enough use for grub_qsort_strcmp to ma= ke >> it global. Can you make it static in grub-install.c ? >=20 > I have pending patches to sort long lists in help output of commands > (grub-mkimage and grub-probe target lists). They are long enough to > wish some ordering. >=20 Ok, then go ahead. >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 ------enig2KJLJSVMDRKIJOFWWSCAM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKcG8kACgkQmBXlbbo5nOtsoAEAjqq5tkBMy9O6R1GFHTKWLlK3 7XWT6tPIcsVU8MvD2L8BAKsi6vpAc2Wq7VYaHD+gO3cfWBV1awU0cuUBd48vvMzd =c6ZN -----END PGP SIGNATURE----- ------enig2KJLJSVMDRKIJOFWWSCAM--