From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH, RFC, RFT] ARM relocation fixes
Date: Mon, 02 Dec 2013 11:59:44 +0100 [thread overview]
Message-ID: <529C6820.9090902@gmail.com> (raw)
In-Reply-To: <20131202105330.GA24997@rocoto.smurfnet.nu>
[-- Attachment #1: Type: text/plain, Size: 1927 bytes --]
On 02.12.2013 11:53, Leif Lindholm wrote:
> On Sun, Dec 01, 2013 at 07:06:32AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>> Current ARM relocation doesn't handle the cases when the relocation cant
>> be satisfied directly (like thumb call over 1M of distance or jump24 to
>> thumb mode. Attached patch adds missing tampoline and missing relocation
>> handling to EFI code (it didn't allow to use ARM (no-Thumb) binary with
>> EFI).
>> I couldn't test it on either arm-efi or ARM64
>
> Amusingly, I wrote the attached
Nothing is attached to your mail. Right now could you pause work on
*/dl.c: I'm reorganising them to declare more of it as platform
independent and unify handling (ARM dl.c is unnecessarily different from
other versions and forget some of ELF handling)
> on Saturday, based on a bug report
> from Jon Masters @ Red Hat. Although an unlikely corner case, it does
> probably need the addition of grub_arch_dl_get_tramp_got_size() from
> your implementation in order to ensure the "veneers"[1] don't end up
> in a heap region different to and too far away from the one the module
> is loaded into.
>
> I'll have a look and a poke on both 32- and 64-bit stuff and respond..
>
> I would say the modifications to grub-mkimage for arm64 are probably
> unnessecary: AArch64 relative branch range is +-128MB, and I don't
> think we'll see grub kernel images that big.
There are no changes of this kind to mkimage. I only added missing ARM
handling and the functions which now became mkimage-specific were moved
to it.
>
> /
> Leif
>
> [1]
> ARM terminology - "trampolines" for ARM refers to something generated
> on the stack, which we don't see anymore since the nested functions were
> removed.
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]
next prev parent reply other threads:[~2013-12-02 11:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-01 6:06 [PATCH, RFC, RFT] ARM relocation fixes Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-02 10:53 ` Leif Lindholm
2013-12-02 10:58 ` Leif Lindholm
2013-12-02 10:59 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2013-12-02 11:28 ` Leif Lindholm
2013-12-02 11:43 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-02 11:46 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-02 13:30 ` Leif Lindholm
2013-12-02 14:14 ` Leif Lindholm
2013-12-02 14:33 ` Leif Lindholm
2013-12-02 17:32 ` Leif Lindholm
2013-12-02 17:40 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-02 17:38 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-02 17:45 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-02 19:40 ` Leif Lindholm
2013-12-02 20:04 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-02 20:46 ` Leif Lindholm
2013-12-03 5:37 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-03 8:14 ` Leif Lindholm
2013-12-03 8:22 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-03 8:47 ` Leif Lindholm
2013-12-03 9:31 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-03 11:16 ` Leif Lindholm
2013-12-03 12:00 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-03 8:09 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-03 11:23 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529C6820.9090902@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).