From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VnRET-0005jR-KI for mharc-grub-devel@gnu.org; Mon, 02 Dec 2013 06:00:05 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnREN-0005Zj-1B for grub-devel@gnu.org; Mon, 02 Dec 2013 06:00:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnREH-00005I-LE for grub-devel@gnu.org; Mon, 02 Dec 2013 05:59:58 -0500 Received: from mail-ea0-x22b.google.com ([2a00:1450:4013:c01::22b]:36407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnREH-00005D-E1 for grub-devel@gnu.org; Mon, 02 Dec 2013 05:59:53 -0500 Received: by mail-ea0-f171.google.com with SMTP id h10so8759649eak.2 for ; Mon, 02 Dec 2013 02:59:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=0l9sjMcSWd6P/0ky2exbosPM7Yz4Vc2pVMuhNWEhuvY=; b=AdaXr8v2auC9xGpM7yrPiCiR5sMPfcDtdp8DjAd8zIDgNyUBodkPp5c7nZgbtFL2UO s6L0EkAX5Buga4d9LRml+0ol4nkWlCTuNoxMqLkgtn+W0wXZMlHb0c6xSThGgeITOV+S 3NuH96MnPdtkVW9fgE757xzFOBFuK8UZE0/2fcHJaX98Qqhp0V7eeRHRN/35Ahu/GweO ZBuhgoiBzIV230RyldkDhXEStwlv4mmja6kfOit0p8kBs5E9/TWt1Ng0tMaJW88SLuCu aHIc7Y+hP3OwGRSa2Jyg6hTNoD03BtGihdmWSDLGfEQ0kYL3817rsWGXg07P0q8MzD+3 XRKg== X-Received: by 10.14.251.196 with SMTP id b44mr65773434ees.10.1385981992380; Mon, 02 Dec 2013 02:59:52 -0800 (PST) Received: from [192.168.42.154] (146-236.197-178.cust.bluewin.ch. [178.197.236.146]) by mx.google.com with ESMTPSA id m1sm63870237eeg.0.2013.12.02.02.59.48 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 02 Dec 2013 02:59:51 -0800 (PST) Message-ID: <529C6820.9090902@gmail.com> Date: Mon, 02 Dec 2013 11:59:44 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH, RFC, RFT] ARM relocation fixes References: <529AD1E8.8010305@gmail.com> <20131202105330.GA24997@rocoto.smurfnet.nu> In-Reply-To: <20131202105330.GA24997@rocoto.smurfnet.nu> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2FFCLWXUIVFFOJEASOOWW" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::22b X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Dec 2013 11:00:04 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2FFCLWXUIVFFOJEASOOWW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02.12.2013 11:53, Leif Lindholm wrote: > On Sun, Dec 01, 2013 at 07:06:32AM +0100, Vladimir '=CF=86-coder/phcode= r' Serbinenko wrote: >> Current ARM relocation doesn't handle the cases when the relocation ca= nt >> be satisfied directly (like thumb call over 1M of distance or jump24 t= o >> thumb mode. Attached patch adds missing tampoline and missing relocati= on >> handling to EFI code (it didn't allow to use ARM (no-Thumb) binary wit= h >> EFI). >> I couldn't test it on either arm-efi or ARM64 >=20 > Amusingly, I wrote the attached Nothing is attached to your mail. Right now could you pause work on */dl.c: I'm reorganising them to declare more of it as platform independent and unify handling (ARM dl.c is unnecessarily different from other versions and forget some of ELF handling) > on Saturday, based on a bug report > from Jon Masters @ Red Hat. Although an unlikely corner case, it does > probably need the addition of grub_arch_dl_get_tramp_got_size() from > your implementation in order to ensure the "veneers"[1] don't end up > in a heap region different to and too far away from the one the module > is loaded into. >=20 > I'll have a look and a poke on both 32- and 64-bit stuff and respond.. >=20 > I would say the modifications to grub-mkimage for arm64 are probably > unnessecary: AArch64 relative branch range is +-128MB, and I don't > think we'll see grub kernel images that big. There are no changes of this kind to mkimage. I only added missing ARM handling and the functions which now became mkimage-specific were moved to it. >=20 > / > Leif >=20 > [1] > ARM terminology - "trampolines" for ARM refers to something generated > on the stack, which we don't see anymore since the nested functions wer= e > removed. >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 ------enig2FFCLWXUIVFFOJEASOOWW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKcaCAACgkQmBXlbbo5nOtCuwEAg8k4saWhRwhCO+MHFZbcPWYz E5C1pxKuC/I/ma09F94BAJwlvPZFNL9J6aHKCj8MJMHA1YZ5lG3wa2toam1bEMhy =8JHW -----END PGP SIGNATURE----- ------enig2FFCLWXUIVFFOJEASOOWW--