From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VnZ3H-0004yj-8g for mharc-grub-devel@gnu.org; Mon, 02 Dec 2013 14:21:03 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnZ37-0004yP-1o for grub-devel@gnu.org; Mon, 02 Dec 2013 14:21:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnZ2y-0003U2-Ky for grub-devel@gnu.org; Mon, 02 Dec 2013 14:20:52 -0500 Received: from mail-ea0-x234.google.com ([2a00:1450:4013:c01::234]:55058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnZ2y-0003Tx-D4 for grub-devel@gnu.org; Mon, 02 Dec 2013 14:20:44 -0500 Received: by mail-ea0-f180.google.com with SMTP id f15so9303900eak.25 for ; Mon, 02 Dec 2013 11:20:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=C8RhcVb5SOCaGE5Pxj6APx5757Ky41PJ7Hj3C8lqXNg=; b=HX9ectuqXKthaP5fkTj9qHeBBXuUKVxR5BmfOdQl4NVU9W/w+fhs5JhzC9c/j5apqd fTaXbPeGHLWUYimyRazQE67PtH5n1sU19xF/GuEhamgMR+BPdhW9SwqN6efdbanG5YkN vhUzDqnUwvwL4JBNYfP4iG1vFrfdXsKR2sydQZ9B9lSDz3fQN49gZnz7iO5sMc6+mXck uBYx7yemDGCs9uoo6AVdfffV8BFIiBs3asmK8QlkcETFI39brsvo/Su4PfVr3kTKvhGC y0zezYRd12j4mR7SXUJnirWXSXokGS5izY9JbTUHmhKjJbtWLytQGdgmnfBY95JS5bEc mfCw== X-Received: by 10.14.113.199 with SMTP id a47mr3286764eeh.41.1386012043324; Mon, 02 Dec 2013 11:20:43 -0800 (PST) Received: from [192.168.1.16] (85-188.196-178.cust.bluewin.ch. [178.196.188.85]) by mx.google.com with ESMTPSA id v7sm56931646eel.2.2013.12.02.11.20.42 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 02 Dec 2013 11:20:42 -0800 (PST) Message-ID: <529CDD89.6050808@gmail.com> Date: Mon, 02 Dec 2013 20:20:41 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH v0] Make clear that passing --grub-mkimage to grub-install is not supported. References: <1386011595-14832-1-git-send-email-jonmccune@google.com> In-Reply-To: <1386011595-14832-1-git-send-email-jonmccune@google.com> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2MBPATSQLIQDLDMEBMOLT" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::234 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Dec 2013 19:21:02 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2MBPATSQLIQDLDMEBMOLT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02.12.2013 20:13, Jon McCune wrote: > A reasonable alternative would be to completely remove all traces > of --grub-mkimage, and simply have it fail like any other unrecognized > flag to grub-install, but this will not be as clear to those who may > go looking for what has happened to --grub-mkimage. >=20 The reason for this option was to specify where grub-mkimage is located. Your ways of using it were unsupported interface abuses. I have never seen any script abusing grub-mkimage such way (that is other than yours).= > Signed-off-by: Jon McCune > --- > util/grub-install-common.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/util/grub-install-common.c b/util/grub-install-common.c > index 03c6f13..fcb4d66 100644 > --- a/util/grub-install-common.c > +++ b/util/grub-install-common.c > @@ -359,7 +359,8 @@ grub_install_parse (int key, char *arg) > } > grub_util_error (_("Unrecognized compression `%s'"), arg); > case GRUB_INSTALL_OPTIONS_GRUB_MKIMAGE: > - return 1; > + grub_util_error (_("Option --grub-mkimage is no longer supported= ")); > + return 0; > default: > return 0; > } >=20 ------enig2MBPATSQLIQDLDMEBMOLT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKc3YkACgkQmBXlbbo5nOuQxQEApk51tgNuiGkJEPH1VKIGKql8 i8t87Ad/swYeJsloJ7sA/iDi6eUm9svr+zbxXhk4/PzxhTvlv5h+Q094fnTEiUZv =rN/m -----END PGP SIGNATURE----- ------enig2MBPATSQLIQDLDMEBMOLT--