From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VpDYa-0002IQ-I1 for mharc-grub-devel@gnu.org; Sat, 07 Dec 2013 03:48:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VpDYQ-00026M-Hq for grub-devel@gnu.org; Sat, 07 Dec 2013 03:48:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VpDYI-0005cU-3h for grub-devel@gnu.org; Sat, 07 Dec 2013 03:48:02 -0500 Received: from mail-ea0-x22e.google.com ([2a00:1450:4013:c01::22e]:51312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VpDYH-0005cQ-KH for grub-devel@gnu.org; Sat, 07 Dec 2013 03:47:54 -0500 Received: by mail-ea0-f174.google.com with SMTP id b10so664858eae.5 for ; Sat, 07 Dec 2013 00:47:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=ZvDaYEZlBf0IdZoz+6jLn8ZIl4yze8emO2ewRNA6iOo=; b=HizhCxAuZi26Tv6gcnI1ALbONzAgdEMjYdla1vb9jZEYpZCGpMi1hDl6Ytp6i8cF6u 6eAgnvSVtWswMZOOAIVwAdB6yEjGy9+9mNwlzBKLv8pcs26WTPBWZJJ+sLIWqcI9K8ox wfBXK3w8Y+Or654lav6R12OU0BQhK2uQ8HzjmiWgjm1jMPtcAjLdmXIWwgQMyfOOoBmH lKBz3LyLP9yNCfjG+I62Pb3GcN0IbT0buJkKcwXvAIpnBm8zd7aox+qGZRxIVGuOW3MD FH9DcIn/RFhwXSGSA7Xs06W/WLup9TnWji9oM3YtpKu5ZF/tfBpasuiQA51R9aDINbBe MrVw== X-Received: by 10.14.218.129 with SMTP id k1mr6059eep.109.1386406072756; Sat, 07 Dec 2013 00:47:52 -0800 (PST) Received: from [192.168.1.16] (85-188.196-178.cust.bluewin.ch. [178.196.188.85]) by mx.google.com with ESMTPSA id v1sm4244402eef.9.2013.12.07.00.47.51 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 07 Dec 2013 00:47:51 -0800 (PST) Message-ID: <52A2E0B0.2030608@gmail.com> Date: Sat, 07 Dec 2013 09:47:44 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH 2/2] second attempt to fix using grub device name as install device References: <1386405872-28362-1-git-send-email-arvidjaar@gmail.com> <1386405872-28362-2-git-send-email-arvidjaar@gmail.com> In-Reply-To: <1386405872-28362-2-git-send-email-arvidjaar@gmail.com> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2UWGLDXAPQCIPQOCJDHES" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::22e X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Dec 2013 08:48:11 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2UWGLDXAPQCIPQOCJDHES Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07.12.2013 09:44, Andrey Borzenkov wrote: > + install_device[grub_strlen (install_device) - 1] =3D '\0'; > + install_drive =3D xstrdup (install_device + 1); > + install_device[grub_strlen (install_device) - 1] =3D ')'; > + } Bad code. You forgot that grub_strlen changes with your operations. You need to keep explicit pointer. ------enig2UWGLDXAPQCIPQOCJDHES Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKi4LcACgkQmBXlbbo5nOu78gD+JOzbfiK/BaCKwhtfKP3rImC0 4PyZxGy67tPLlkdFRUYBAIE+bL96CplFYEBPYUc7Rp4UJ1hQWRjvildNTSgKgLgO =q7m6 -----END PGP SIGNATURE----- ------enig2UWGLDXAPQCIPQOCJDHES--