From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH 2/2 v2] second attempt to fix using grub device name as install device
Date: Sat, 07 Dec 2013 15:14:00 +0100 [thread overview]
Message-ID: <52A32D28.1010001@gmail.com> (raw)
In-Reply-To: <20131207175901.1802ddd6@opensuse.site>
[-- Attachment #1: Type: text/plain, Size: 1944 bytes --]
On 07.12.2013 14:59, Andrey Borzenkov wrote:
> В Sat, 07 Dec 2013 14:50:09 +0100
> Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
>
>> On 07.12.2013 11:19, Andrey Borzenkov wrote:
>>> grub-install already resolved passed install device to grub device. So do the
>>> same as grub-setup and strip parenthesis if we get legacy (hdX).
>>>
>> Did you test it with both syntaxes?
>
> Yes.
>
Go ahead for both parts.
Colin told on IRC that he's ok with this patch as well.
> linux-cor4:~ # /usr/local/grub2/sbin/grub-install '(hd1)'
> FATAL: Error inserting efivars (/lib/modules/3.11.6-4-pae/kernel/drivers/firmware/efi/efivars.ko): No such device
> /usr/local/grub2/sbin/grub-install: warning: cannot open directory `/usr/local/grub2/share/locale': No such file or directory.
> Installation finished. No error reported.
> linux-cor4:~ # /usr/local/grub2/sbin/grub-install /dev/sdb
> FATAL: Error inserting efivars (/lib/modules/3.11.6-4-pae/kernel/drivers/firmware/efi/efivars.ko): No such device
> /usr/local/grub2/sbin/grub-install: warning: cannot open directory `/usr/local/grub2/share/locale': No such file or directory.
> Installation finished. No error reported.
> linux-cor4:~ # /usr/local/grub2/sbin/grub-install /dev/disk/by-id/ata-QEMU_HARDDISK_QM00002
> FATAL: Error inserting efivars (/lib/modules/3.11.6-4-pae/kernel/drivers/firmware/efi/efivars.ko): No such device
> /usr/local/grub2/sbin/grub-install: warning: cannot open directory `/usr/local/grub2/share/locale': No such file or directory.
> Installation finished. No error reported.
> linux-cor4:~ # cat /boot/grub/device.map
> (hd0) /dev/disk/by-id/ata-QEMU_HARDDISK_QM00001
> (hd1) /dev/disk/by-id/ata-QEMU_HARDDISK_QM00002
> linux-cor4:~ # exit
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]
prev parent reply other threads:[~2013-12-07 14:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 21:39 [PATCH] Fix grub-install with OS device name Colin Watson
2013-12-04 21:54 ` Jonathan McCune
2013-12-04 22:15 ` Colin Watson
2013-12-05 5:56 ` arvidjaar
2013-12-05 7:08 ` Andrey Borzenkov
2013-12-07 8:44 ` [PATCH 1/2] revert 69ca97c820, it broke using OS device name as install device Andrey Borzenkov
2013-12-07 8:44 ` [PATCH 2/2] second attempt to fix using grub " Andrey Borzenkov
2013-12-07 8:47 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-07 9:40 ` Andrey Borzenkov
2013-12-07 9:42 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-07 10:19 ` [PATCH 2/2 v2] " Andrey Borzenkov
2013-12-07 13:50 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-07 13:59 ` Andrey Borzenkov
2013-12-07 14:14 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A32D28.1010001@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).