grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] use light-gray as default color in normal.mod for consistency
Date: Sat, 07 Dec 2013 16:46:21 +0100	[thread overview]
Message-ID: <52A342CD.3070505@gmail.com> (raw)
In-Reply-To: <1385712627-31628-1-git-send-email-arvidjaar@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]

Go ahead
On 29.11.2013 09:10, Andrey Borzenkov wrote:
> As we are in clean up stage ... annoyed me for quite some time.
> 
> Defalut font color on PC console seems to be light-gray; this is
> what user also gets in rescue prompt and what is defined as
> GRUB_TERM_DEFAULT_NORMAL_COLOR. But normal.mod defaults to white.
> This makes unpleasant visual effect as colors are changed after kernel
> is booted.
> 
> Use the same color eveywhere for consistency and default to light-gray
> as this is also what at least Linux kernel is using by default.
> 
> ---
>  grub-core/normal/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/grub-core/normal/main.c b/grub-core/normal/main.c
> index ad36273..644e916 100644
> --- a/grub-core/normal/main.c
> +++ b/grub-core/normal/main.c
> @@ -572,8 +572,8 @@ GRUB_MOD_INIT(normal)
>    grub_env_export ("color_highlight");
>  
>    /* Set default color names.  */
> -  grub_env_set ("color_normal", "white/black");
> -  grub_env_set ("color_highlight", "black/white");
> +  grub_env_set ("color_normal", "light-gray/black");
> +  grub_env_set ("color_highlight", "black/light-gray");
>  
>    for (i = 0; i < ARRAY_SIZE (features); i++)
>      {
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]

      reply	other threads:[~2013-12-07 15:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-29  8:10 [PATCH] use light-gray as default color in normal.mod for consistency Andrey Borzenkov
2013-12-07 15:46 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A342CD.3070505@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).