From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VpK5b-0007Wh-BZ for mharc-grub-devel@gnu.org; Sat, 07 Dec 2013 10:46:43 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VpK5R-0007WG-Hi for grub-devel@gnu.org; Sat, 07 Dec 2013 10:46:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VpK5J-0000gy-4v for grub-devel@gnu.org; Sat, 07 Dec 2013 10:46:33 -0500 Received: from mail-ea0-x236.google.com ([2a00:1450:4013:c01::236]:33775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VpK5I-0000gu-TK for grub-devel@gnu.org; Sat, 07 Dec 2013 10:46:25 -0500 Received: by mail-ea0-f182.google.com with SMTP id a15so804770eae.27 for ; Sat, 07 Dec 2013 07:46:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=39KcUNnvhGp0tU5w0BppXY617+Ho8R8YTcak43vkUho=; b=ztBF4v758/4M4YbiiKjKRslIXxeFykcY3Y5kv320j4NMsIRuErJ71hyDxtUcv42Nlc Qs4tc+i7Co1mzvLKcm5wJ78TpzVi2lRlMt+dVxvUvjoSU6zZ8LhD4yJpv1laTbC0C+pw o2SPmZgTvrl7JCQb6/ThWwSr2cEvIhluJ03FZXnBpBOIAnsWx0I/3JRRyppUdetwiGV7 bOfmpAfun+X+ZlTrcCrKGW93mkzmFvS8vQ2OT2Y/mcElVqZG75VUw5wJw1ahoIa9ufWN GHMjYcGFZJYx4nJHfgR4z2vireN7RQUOZzDbhTPDi6wzvvGkyUYYjV6HJUdivN2nVkEY 0MAw== X-Received: by 10.14.225.2 with SMTP id y2mr6649198eep.62.1386431183689; Sat, 07 Dec 2013 07:46:23 -0800 (PST) Received: from [192.168.1.16] (85-188.196-178.cust.bluewin.ch. [178.196.188.85]) by mx.google.com with ESMTPSA id z42sm7593517eeo.17.2013.12.07.07.46.22 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 07 Dec 2013 07:46:22 -0800 (PST) Message-ID: <52A342CD.3070505@gmail.com> Date: Sat, 07 Dec 2013 16:46:21 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] use light-gray as default color in normal.mod for consistency References: <1385712627-31628-1-git-send-email-arvidjaar@gmail.com> In-Reply-To: <1385712627-31628-1-git-send-email-arvidjaar@gmail.com> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="----enig2EHTUVFTPTESSNHXDOLUD" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::236 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Dec 2013 15:46:42 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2EHTUVFTPTESSNHXDOLUD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Go ahead On 29.11.2013 09:10, Andrey Borzenkov wrote: > As we are in clean up stage ... annoyed me for quite some time. >=20 > Defalut font color on PC console seems to be light-gray; this is > what user also gets in rescue prompt and what is defined as > GRUB_TERM_DEFAULT_NORMAL_COLOR. But normal.mod defaults to white. > This makes unpleasant visual effect as colors are changed after kernel > is booted. >=20 > Use the same color eveywhere for consistency and default to light-gray > as this is also what at least Linux kernel is using by default. >=20 > --- > grub-core/normal/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/grub-core/normal/main.c b/grub-core/normal/main.c > index ad36273..644e916 100644 > --- a/grub-core/normal/main.c > +++ b/grub-core/normal/main.c > @@ -572,8 +572,8 @@ GRUB_MOD_INIT(normal) > grub_env_export ("color_highlight"); > =20 > /* Set default color names. */ > - grub_env_set ("color_normal", "white/black"); > - grub_env_set ("color_highlight", "black/white"); > + grub_env_set ("color_normal", "light-gray/black"); > + grub_env_set ("color_highlight", "black/light-gray"); > =20 > for (i =3D 0; i < ARRAY_SIZE (features); i++) > { >=20 ------enig2EHTUVFTPTESSNHXDOLUD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKjQs0ACgkQmBXlbbo5nOvZbwD9EwV9hno0I7csMQGMXiDYA+mC 81O4TnbCyk3mkVv7p9IA/2EkwYCkOcOwu2BrmiJLr2apZQYYcuc05RI4shMGH7G9 =+APq -----END PGP SIGNATURE----- ------enig2EHTUVFTPTESSNHXDOLUD--