From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH v4] Support to disable reed-solomon codes
Date: Tue, 10 Dec 2013 00:23:31 +0100 [thread overview]
Message-ID: <52A650F3.1050509@gmail.com> (raw)
In-Reply-To: <1386618897-17163-1-git-send-email-jonmccune@google.com>
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
> + /* Round up to the nearest sector boundary, and zero the extra memory */
> core_img = realloc (core_img, nsec * GRUB_DISK_SECTOR_SIZE);
> + assert (core_img && (nsec * GRUB_DISK_SECTOR_SIZE >= core_size));
Can you change that to xrealloc while on it?
Other than this, go ahead.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 291 bytes --]
prev parent reply other threads:[~2013-12-09 23:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 19:54 [PATCH v4] Support to disable reed-solomon codes Jon McCune
2013-12-09 23:23 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A650F3.1050509@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).