From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VqPfo-0006Gu-HR for mharc-grub-devel@gnu.org; Tue, 10 Dec 2013 10:56:36 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqPff-0006Bs-E8 for grub-devel@gnu.org; Tue, 10 Dec 2013 10:56:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VqPfZ-0006vb-J4 for grub-devel@gnu.org; Tue, 10 Dec 2013 10:56:27 -0500 Received: from mail-ea0-f172.google.com ([209.85.215.172]:50992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VqPfZ-0006vV-DF for grub-devel@gnu.org; Tue, 10 Dec 2013 10:56:21 -0500 Received: by mail-ea0-f172.google.com with SMTP id q10so2271189ead.17 for ; Tue, 10 Dec 2013 07:55:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=SMW2dLLs51oCQ1lw62MRr938djuH9A4lhmnK7BKsEAQ=; b=na/tqW4rAzm9+VN4Xq3VQx/OdbLc2xut+MiKoLhxuTkYZk1R0Rx36ol282lDQg6PRv THwW1vw81GNrZesv+zjWPdv/S0Q+MTnwjfCxAxpfY8p265FkFcma20mjxrc+DNkhndTH E2/Fm6PXtZQ9uJLxygL9SaygA1RF2679HrZskgymwjcXw3qn3UG6R2HvmBmpk6elj95g LyTbVZUoBZBtpOBtQ+bwCwOSt881MwwaB2qkfj5ZU8kL4Xmox/1PtTs8GcIeniz0MYze wzW3RdKv8U/1g0C2VhCntgvsKVEBLb1xXIs0R73t9YgU9F2SDDYDtOWYJGiHwgwSxmz3 KzPg== X-Received: by 10.14.107.3 with SMTP id n3mr33569994eeg.67.1386690945513; Tue, 10 Dec 2013 07:55:45 -0800 (PST) Received: from [192.168.1.16] (85-188.196-178.cust.bluewin.ch. [178.196.188.85]) by mx.google.com with ESMTPSA id a51sm42678007eeh.8.2013.12.10.07.55.44 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 10 Dec 2013 07:55:44 -0800 (PST) Message-ID: <52A73980.80808@gmail.com> Date: Tue, 10 Dec 2013 16:55:44 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: memcpy() in lib/fdt.c References: <20131210153823.GG22356@rocoto.smurfnet.nu> In-Reply-To: <20131210153823.GG22356@rocoto.smurfnet.nu> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bsAEeIhnLe28x5jemfUuqIQ0MQgrFsDFw" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.215.172 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Dec 2013 15:56:33 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bsAEeIhnLe28x5jemfUuqIQ0MQgrFsDFw Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Go ahead On 10.12.2013 16:38, Leif Lindholm wrote: > Hi, >=20 > There is a typo in fdt.c, invoking memcpy() rather than grub_memcpy(). > Suggested trivial fix: >=20 > diff --git a/grub-core/lib/fdt.c b/grub-core/lib/fdt.c > index 9c886fc..9f34dc7 100644 > --- a/grub-core/lib/fdt.c > +++ b/grub-core/lib/fdt.c > @@ -219,8 +219,8 @@ static int rearrange_blocks (void *fdt, unsigned in= t clearan > grub_fdt_set_off_dt_strings (fdt, off_dt_strings); > =20 > /* Copy reordered blocks back to fdt. */ > - memcpy (fdt_ptr + off_mem_rsvmap, tmp_fdt + off_mem_rsvmap, > - grub_fdt_get_totalsize (fdt) - off_mem_rsvmap); > + grub_memcpy (fdt_ptr + off_mem_rsvmap, tmp_fdt + off_mem_rsvmap, > + grub_fdt_get_totalsize (fdt) - off_mem_rsvmap); > =20 > grub_free(tmp_fdt); > return 0; >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --bsAEeIhnLe28x5jemfUuqIQ0MQgrFsDFw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKnOYAACgkQmBXlbbo5nOvdogD/f4/jpliqTG4tpM+FhxPpdf3l CgyAG8YyiCys51VZFYcA+wavAgO8eCYyADYPq+OvoBd3ESm8tq6pfAIhMXUN1PTu =GxBK -----END PGP SIGNATURE----- --bsAEeIhnLe28x5jemfUuqIQ0MQgrFsDFw--