From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VsF3C-0001E5-7b for mharc-grub-devel@gnu.org; Sun, 15 Dec 2013 12:00:18 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsF33-00014M-Ez for grub-devel@gnu.org; Sun, 15 Dec 2013 12:00:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsF2y-0002nL-Ei for grub-devel@gnu.org; Sun, 15 Dec 2013 12:00:09 -0500 Received: from mail-ea0-x236.google.com ([2a00:1450:4013:c01::236]:56901) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsF2y-0002jH-1l for grub-devel@gnu.org; Sun, 15 Dec 2013 12:00:04 -0500 Received: by mail-ea0-f182.google.com with SMTP id a15so1789855eae.13 for ; Sun, 15 Dec 2013 09:00:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type; bh=ZMvQNowr54YDf+3twIDtqXvAsMiQJglzmugR0geqjpU=; b=V7hvchcD0dN3DDyKsqQtdJ/E5s2ymwfvbh8res2XPnz6rrUTNhTEXD4aeDxcYIvqYN yxnDak/0hh+KuAacDAKxs1YOcqRb+8wJtmpeqM7Z3Eh+FOQzlnK2tYeTEosHAZu+h/1t uqTVtfthJtd1USl2CpkFBdM476gnMPLG8H5bfswti8CcJzosdb845iodRLocNs6481gw 91nO3nuOvfJrnvuSD3up5AXeo6dg1+bKU6eV68o3fivhcDRZEEZQQHKhcMvWRT+0dbxZ F6BVXrQj7TjxL5iaLYo1+SVtEPF+k3G3LiH6S7ES68lUFpXckZzBGDwBw7yh3S2dLVom 9Y3A== X-Received: by 10.14.114.71 with SMTP id b47mr12791683eeh.26.1387126803172; Sun, 15 Dec 2013 09:00:03 -0800 (PST) Received: from [192.168.1.16] (85-188.196-178.cust.bluewin.ch. [178.196.188.85]) by mx.google.com with ESMTPSA id j46sm32029061eew.18.2013.12.15.09.00.01 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 15 Dec 2013 09:00:02 -0800 (PST) Message-ID: <52ADE011.6010009@gmail.com> Date: Sun, 15 Dec 2013 18:00:01 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: Ian Campbell Subject: Re: [PATCH] * grub-core/kern/uboot/init.c (uboot_timer_ms) correct units References: <1387121014-19415-1-git-send-email-ijc@hellion.org.uk> In-Reply-To: <1387121014-19415-1-git-send-email-ijc@hellion.org.uk> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nGWcSiLbXvlHc6x4f7tt2m6dwRE9jXsNg" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::236 Cc: grub-devel@gnu.org, Ian Campbell , Leif Lindholm X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Dec 2013 17:00:14 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nGWcSiLbXvlHc6x4f7tt2m6dwRE9jXsNg Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Committed, thanks On 15.12.2013 16:23, Ian Campbell wrote: > From: Ian Campbell >=20 > u-boot's API_GET_TIMER returns the current time in ms by directly expos= ing the > internal get_timer which is in ms, which isn't all that clearly documen= ted but > is obvious from the use within u-boot and is mentioned in > http://www.denx.de/wiki/U-Boot/TaskTimerAPI. >=20 > This was put wrong in 4e13e84e56f7 "Fix timer units". >=20 > Without this it takes 5000s to count down to the automatic boot of the = selected > option (or I assume it would, I never waited...) >=20 > Cc: Vladimir 'phcoder' Serbinenko > Cc: Leif Lindholm > --- > grub-core/kern/uboot/init.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/grub-core/kern/uboot/init.c b/grub-core/kern/uboot/init.c > index b108de3..2e9d382 100644 > --- a/grub-core/kern/uboot/init.c > +++ b/grub-core/kern/uboot/init.c > @@ -66,8 +66,7 @@ uboot_timer_ms (void) > if (cur < last) > high++; > last =3D cur; > - return grub_divmod64 ((((grub_uint64_t) high) << 32) | cur, > - 1000, 0); > + return (((grub_uint64_t) high) << 32) | cur; > } > =20 > void >=20 --nGWcSiLbXvlHc6x4f7tt2m6dwRE9jXsNg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKt4BEACgkQmBXlbbo5nOvywwEAmLBVLsM5QA5wL20mw1kGNhn/ +oWc3Q18gdXzGxFJ6pEA/iQfH9+mxCSsSUIK7Niw6jF0yAUzBzf8HQXhHJT6nw3J =n0wz -----END PGP SIGNATURE----- --nGWcSiLbXvlHc6x4f7tt2m6dwRE9jXsNg--