From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VscwJ-0001MV-1O for mharc-grub-devel@gnu.org; Mon, 16 Dec 2013 13:30:47 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vscw9-0001Ku-1t for grub-devel@gnu.org; Mon, 16 Dec 2013 13:30:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vscw1-0004WE-HM for grub-devel@gnu.org; Mon, 16 Dec 2013 13:30:36 -0500 Received: from mail-ee0-f47.google.com ([74.125.83.47]:45671) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vscw1-0004W9-As for grub-devel@gnu.org; Mon, 16 Dec 2013 13:30:29 -0500 Received: by mail-ee0-f47.google.com with SMTP id e51so2033137eek.6 for ; Mon, 16 Dec 2013 10:29:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=1llFwKoC6ASx8yO7JLrQ1RvgzqVxLOBrxRBhGfDTk3o=; b=veJt2LEv9yquNc9HNMgtLLWiia+WBZupSwptUGAQYbnhkOimkMFnYgk7uuRlX9aiKh YbEqNmkoqR3GaTfP1Lr6wvJDr8eRr15sN99koPwIob5PEcXVeLvX4EQJOOB3svq4+SFm bfEcBi+C+OAERFrhKCtfmIrb7bFfxqF+iwL12YEGq9KWob7bfpuT3QNJSsvF15Up/k1H 22PiMwv/j9kkc4DuiIv1faCsVNo0JPEvh3e+q9Tx27d/A+vxUeWFaP9WTqwyvlasFEZT zsAMbouVph9u2OkCPhC40ph8ZbWfdTQyaWKc21kNJ5GtZccJ068zW6scpCaZbqC4ePdZ SIpw== X-Received: by 10.14.108.134 with SMTP id q6mr10469127eeg.96.1387218593606; Mon, 16 Dec 2013 10:29:53 -0800 (PST) Received: from [192.168.1.16] (85-188.196-178.cust.bluewin.ch. [178.196.188.85]) by mx.google.com with ESMTPSA id l4sm45163221een.13.2013.12.16.10.29.52 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 16 Dec 2013 10:29:52 -0800 (PST) Message-ID: <52AF469F.7050009@gmail.com> Date: Mon, 16 Dec 2013 19:29:51 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH 2/2] use grub_util_exec_redirect_all to silence "moprobe efivars" References: <20131216062201.45b549a4@opensuse.site> <1387218052-22765-1-git-send-email-arvidjaar@gmail.com> <1387218052-22765-3-git-send-email-arvidjaar@gmail.com> In-Reply-To: <1387218052-22765-3-git-send-email-arvidjaar@gmail.com> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VJXjCrQ2TCLO3K7AxlNJqr2cF3D2cjnXu" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 74.125.83.47 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Dec 2013 18:30:44 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --VJXjCrQ2TCLO3K7AxlNJqr2cF3D2cjnXu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Go ahead for both patches. Could you also add a grub_util_info detailing which directories were tried and if they were found or not? To provide info about why GRUB assumed this or that platform. On 16.12.2013 19:20, Andrey Borzenkov wrote: > --- > grub-core/osdep/linux/platform.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/grub-core/osdep/linux/platform.c b/grub-core/osdep/linux/p= latform.c > index ec67aad..86561f7 100644 > --- a/grub-core/osdep/linux/platform.c > +++ b/grub-core/osdep/linux/platform.c > @@ -69,8 +69,8 @@ grub_install_get_default_x86_platform (void) > anyway later. So it should be safe to > try to load it here. > */ > - grub_util_exec ((const char * []){ "modprobe", "-q", > - "efivars", NULL }); > + grub_util_exec_redirect_all ((const char * []){ "modprobe", "efivars= ", NULL }, > + NULL, NULL, "/dev/null"); > if (is_not_empty_directory ("/sys/firmware/efi")) > { > if (is_64_kernel ()) >=20 --VJXjCrQ2TCLO3K7AxlNJqr2cF3D2cjnXu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlKvRp8ACgkQmBXlbbo5nOvYCwD/cr5NYGsKKHlDqh4mfRUeAK0F sWkVhYfwBcwWO5MPeLQA/iOb3XxggAIxG7q+U4Y/bNZ09vaMqSMSNOsp+0G6ZupD =Yn3d -----END PGP SIGNATURE----- --VJXjCrQ2TCLO3K7AxlNJqr2cF3D2cjnXu--