From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VuUxY-0004nT-Bx for mharc-grub-devel@gnu.org; Sat, 21 Dec 2013 17:23:48 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VuUxS-0004mr-6c for grub-devel@gnu.org; Sat, 21 Dec 2013 17:23:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VuUxN-0005zv-Vs for grub-devel@gnu.org; Sat, 21 Dec 2013 17:23:42 -0500 Received: from mail-ee0-x229.google.com ([2a00:1450:4013:c00::229]:63072) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VuUxN-0005yV-OC for grub-devel@gnu.org; Sat, 21 Dec 2013 17:23:37 -0500 Received: by mail-ee0-f41.google.com with SMTP id t10so1710388eei.0 for ; Sat, 21 Dec 2013 14:23:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type; bh=1t+8L8lfR3cA3kRJumcxK6Bng7qQiHM6+6Z93iZsp+A=; b=e6ob4l/85sjL6uDDVHhFF4FS2XL+oY5nRHsdR1tqf7C9+PAWHOQBwoYUA5ODc1Geb9 sJhfoAsVj/udV/eM4WLR+SQjy2bCcPXVa3iWa9t51BRyaHEE/FVUvdFTalFEy05t5jbe lte/d+b89Z6q0r0/2blVtMUjQWxrnfTsh4/RAroASg6FdTOOiBSbwh2Ybi735SAjD+Me wx8XjFpwK1R2uRv6Bz31U5HV6XKCClDsLSvvhmowVLindq18Fi2yw93zeqKbyY90EP/B wc5RDAei6wXZMMLYxZba977D9eXUlGPoh7DvHUci+F7dfNn56MEmPKpS+Pg5vVJ2TXkg xixw== X-Received: by 10.14.101.4 with SMTP id a4mr13451423eeg.28.1387664616868; Sat, 21 Dec 2013 14:23:36 -0800 (PST) Received: from [192.168.1.16] (85-188.196-178.cust.bluewin.ch. [178.196.188.85]) by mx.google.com with ESMTPSA id h48sm31227478eev.3.2013.12.21.14.23.35 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 21 Dec 2013 14:23:35 -0800 (PST) Message-ID: <52B614E6.1090100@gmail.com> Date: Sat, 21 Dec 2013 23:23:34 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: Ian Campbell Subject: Re: [PATCH] * grub-core/kern/uboot/init.c (uboot_timer_ms) correct units References: <1387121014-19415-1-git-send-email-ijc@hellion.org.uk> In-Reply-To: <1387121014-19415-1-git-send-email-ijc@hellion.org.uk> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Dq6i842QDPl9TgcwVIAXxscAJFJjUWMU1" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::229 Cc: grub-devel@gnu.org, Ian Campbell , Leif Lindholm X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Dec 2013 22:23:46 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Dq6i842QDPl9TgcwVIAXxscAJFJjUWMU1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 15.12.2013 16:23, Ian Campbell wrote: > From: Ian Campbell >=20 > u-boot's API_GET_TIMER returns the current time in ms by directly expos= ing the > internal get_timer which is in ms, which isn't all that clearly documen= ted but > is obvious from the use within u-boot and is mentioned in > http://www.denx.de/wiki/U-Boot/TaskTimerAPI. >=20 During tests on my raspberry pi, I actually experienced the exact opposite. On PI timer API is in microseconds. Are you sure you made no mistake? > This was put wrong in 4e13e84e56f7 "Fix timer units". >=20 > Without this it takes 5000s to count down to the automatic boot of the = selected > option (or I assume it would, I never waited...) >=20 > Cc: Vladimir 'phcoder' Serbinenko > Cc: Leif Lindholm > --- > grub-core/kern/uboot/init.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/grub-core/kern/uboot/init.c b/grub-core/kern/uboot/init.c > index b108de3..2e9d382 100644 > --- a/grub-core/kern/uboot/init.c > +++ b/grub-core/kern/uboot/init.c > @@ -66,8 +66,7 @@ uboot_timer_ms (void) > if (cur < last) > high++; > last =3D cur; > - return grub_divmod64 ((((grub_uint64_t) high) << 32) | cur, > - 1000, 0); > + return (((grub_uint64_t) high) << 32) | cur; > } > =20 > void >=20 --Dq6i842QDPl9TgcwVIAXxscAJFJjUWMU1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlK2FOYACgkQmBXlbbo5nOtrWwD+JQQkvqwJYKuaCUrZUjOjebtB clooPhh9EADsNpQ4LHwA/3dLOE2fxVyiN084UVESwPacB1tvDA2HAJXGOJ08aOP/ =lzwp -----END PGP SIGNATURE----- --Dq6i842QDPl9TgcwVIAXxscAJFJjUWMU1--