From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VvVbm-0005cx-BX for mharc-grub-devel@gnu.org; Tue, 24 Dec 2013 12:17:30 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvVLL-0000GO-Ie for grub-devel@gnu.org; Tue, 24 Dec 2013 12:00:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvVLG-0002rp-7s for grub-devel@gnu.org; Tue, 24 Dec 2013 12:00:31 -0500 Received: from mail-ea0-x230.google.com ([2a00:1450:4013:c01::230]:44846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvVLG-0002rb-0n for grub-devel@gnu.org; Tue, 24 Dec 2013 12:00:26 -0500 Received: by mail-ea0-f176.google.com with SMTP id h14so2966160eaj.7 for ; Tue, 24 Dec 2013 09:00:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=VjqDk+N91COUY4KaHiKLXR628PAi9Ul6XFuBMeysL7s=; b=MHZ5inELb7vEWzKOvf10opGcHC73hOe+6LJowkHFEowTEjCfMN+SK1HGGvMwxpj/8k 1PBhggJVZbeomElOcLGD9VmP77QlVO+WLBFnmBNfzY+PDdL4iL+ppATiqlJPHLJJs0cB aWdilcoFx0pd6iluR8mcnvwB/CM2k5oh7IrNp2+a2jG9j7MnFNapAfjG1RBgoACf8lzZ qEf9jK7Jp0RhoAFW6bZoo5B6JSdPK1uHpDRJ3HSF+QoT7zEDtrcONekxj/ZcVbZjI2CB 7V5pYJnhVlDxC87ElCOlfpE3nzgukbb6DEzlWexNNjBnH4pjf6pvQ0sL/P2Wl0IHikIp MUmA== X-Received: by 10.15.26.6 with SMTP id m6mr3397283eeu.80.1387904424835; Tue, 24 Dec 2013 09:00:24 -0800 (PST) Received: from [192.168.1.16] (85-188.196-178.cust.bluewin.ch. [178.196.188.85]) by mx.google.com with ESMTPSA id a51sm56536664eeh.8.2013.12.24.09.00.23 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 24 Dec 2013 09:00:23 -0800 (PST) Message-ID: <52B9BDA7.4030306@gmail.com> Date: Tue, 24 Dec 2013 18:00:23 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] Skip Apple ghosts References: <52B98B9A.5020609@gmail.com> <1387903453.918.53.camel@opensuse.site> In-Reply-To: <1387903453.918.53.camel@opensuse.site> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dBkJSACnSdlMII1CRN7RaBSvV2WlW4783" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::230 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Dec 2013 17:17:28 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dBkJSACnSdlMII1CRN7RaBSvV2WlW4783 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 24.12.2013 17:44, Andrey Borzenkov wrote: > =D0=92 =D0=92=D1=82, 24/12/2013 =D0=B2 14:26 +0100, Vladimir '=CF=86-co= der/phcoder' Serbinenko > =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> Hello, all. It was discovered that on macs sometimes firmware defines >> ghost disks with vendor suffix. E.g. >> /ACPI(a0341d0,0)/PCI(2,1f)/UnknownMessaging(12)/EndEntire >> is a normal disks with partitions presented with HD(...) but then >> /ACPI(a0341d0,0)/PCI(2,1f)/UnknownMessaging(12)/MediaVendor(Apple)[0: >> ]/EndEntire >> is a ghost disk. It has as suffix a vendor path with empty vendor data= =2E >=20 > Messaging subtype 12 is IPv4 Device Path. I suppose it is related to > NetBoot. It's hex. 0x12 is SATA. >=20 >> This is a problem because when chainloading on such disks GRUB can't >> find handle of partition as none is defined. I propose to dkip ghosts >> completely. This should be safe as the skip happens only for empty App= le >> vendor suffix and if the parent is already a known disk. >=20 > Hmm ... should not we simply ignore all unknown media types? They can b= e > added on case by case basis I guess. >=20 Too much breakage potential. And I don't have accessto check it on loads of different buggy EFI systems and even if I did, it would be a waste of time. > diff --git a/grub-core/disk/efi/efidisk.c b/grub-core/disk/efi/efidisk.= c > index e04203f..6dfdb0d 100644 > --- a/grub-core/disk/efi/efidisk.c > +++ b/grub-core/disk/efi/efidisk.c > @@ -310,6 +310,7 @@ name_devices (struct grub_efidisk_data *devices) > grub_efi_print_device_path (d->device_path); > #endif > /* For now, ignore the others. */ > + d->last_device_path =3D 0; > break; > } > } >=20 >=20 >> Did anyone see anything similar? >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> https://lists.gnu.org/mailman/listinfo/grub-devel >=20 >=20 >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --dBkJSACnSdlMII1CRN7RaBSvV2WlW4783 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlK5vacACgkQmBXlbbo5nOuMVgD+IHE+23bndPKHkQtKCciqBim8 2dC4S9fy1QXz4C8FS4IA/3M0UNz1b86AKkDQ0ACO7bsfGc1RGPtxbZb/PXOSVSp3 =LHQZ -----END PGP SIGNATURE----- --dBkJSACnSdlMII1CRN7RaBSvV2WlW4783--