From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VwdAj-0006zq-Gv for mharc-grub-devel@gnu.org; Fri, 27 Dec 2013 14:34:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VwdAh-0006xy-5k for grub-devel@gnu.org; Fri, 27 Dec 2013 14:34:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VwdAg-0005Oc-9V for grub-devel@gnu.org; Fri, 27 Dec 2013 14:34:11 -0500 Received: from mail-bk0-x22a.google.com ([2a00:1450:4008:c01::22a]:50576) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VwdAg-0005OY-2Q for grub-devel@gnu.org; Fri, 27 Dec 2013 14:34:10 -0500 Received: by mail-bk0-f42.google.com with SMTP id w11so3208175bkz.15 for ; Fri, 27 Dec 2013 11:34:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=GEt2unJo83Sylepp+/vZDNr7H+zAjbMkEW0O+74WT1Y=; b=U506T5FMVES4s5c3u1+4uRQl05sZIPlv52rLXKwScaippjVmFVSJTbwr+Mtz92t1cj sOH4k/fzmbg7YhPI1XGRBbeBFl6YjaM+p2iUAiqp814Ow0lYkGnuSmaLndJwq3cf26Lu v4Lxk2J5kNXHSeQ3iK5s8FWGZa55ya9MJkX6a/88phLr2rJQNwXtzizoXGKKMna8pq+K DcVexwZQsRnPJwL4DhZJTkfqzOsmXa8hfjN5ojfh6BTx3TDFXRXAOChLTdAvSUt8hopQ 0S1Na8MfohEw516h3JeQwRwej+5b9xjiCdYyS/pu9+UMSs8lvMktrSKiFFRmC2jz3WwT PDsQ== X-Received: by 10.204.69.203 with SMTP id a11mr1272123bkj.111.1388172849163; Fri, 27 Dec 2013 11:34:09 -0800 (PST) Received: from ?IPv6:2001:67c:20a1:1068:3e97:eff:fe6a:16ab? ([2001:67c:20a1:1068:3e97:eff:fe6a:16ab]) by mx.google.com with ESMTPSA id bk1sm18370384bkc.3.2013.12.27.11.34.07 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 27 Dec 2013 11:34:07 -0800 (PST) Message-ID: <52BDD629.3010906@gmail.com> Date: Fri, 27 Dec 2013 20:34:01 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: error.h missing on mingw (grub-core/kern/emu/misc.c fails to compile) References: <1388087687.918.69.camel@opensuse.site> <1388168717.918.74.camel@opensuse.site> In-Reply-To: <1388168717.918.74.camel@opensuse.site> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Sh5EWm5VFqxjaGqjRBieTrBfqxe21aExP" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4008:c01::22a X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Dec 2013 19:34:12 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Sh5EWm5VFqxjaGqjRBieTrBfqxe21aExP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 27.12.2013 19:25, Andrey Borzenkov wrote: > =D0=92 =D0=A7=D1=82, 26/12/2013 =D0=B2 23:54 +0400, Andrey Borzenkov =D0= =BF=D0=B8=D1=88=D0=B5=D1=82: >> I'm not sure how to fix it. It is pulled in by build-grub-pep2elf and >> build-grub-pe2elf. Those are build time programs and so use >> BUILD_CPPFLAGS; adding CPPFLAGS_GNULIB is probably not appropriate. It= >> compiles just fine with error.h commented out. May be something like >> >> #if !defined(GRUB_BUILD) || defined(HAVE_ERROR_H) >> >=20 > On the second glance - why is needed at all? Nothing defined > there is used in misc.c and on Linux it compiles just fine with error.h= > as well. >=20 > May be we could simply drop it? >=20 Yes. I was going to answer with this. Many of includes are inherited by copying of include parts. error.h there can simply be removed >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --Sh5EWm5VFqxjaGqjRBieTrBfqxe21aExP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlK91i8ACgkQmBXlbbo5nOv3xAEArnIh7hC4cZYfIXt55DF+QGIL JDXz79rmOHq1b8Z1lUAA/0jPCxQWpMCN9JN91iuiqzJZGqRvKW1+E6RiOXETN/Gv =rDq7 -----END PGP SIGNATURE----- --Sh5EWm5VFqxjaGqjRBieTrBfqxe21aExP--