From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VxXZZ-0004oh-7X for mharc-grub-devel@gnu.org; Mon, 30 Dec 2013 02:47:37 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VxXZW-0004o9-4y for grub-devel@gnu.org; Mon, 30 Dec 2013 02:47:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VxXZR-00088V-6N for grub-devel@gnu.org; Mon, 30 Dec 2013 02:47:34 -0500 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:59187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VxXZQ-00087w-V5 for grub-devel@gnu.org; Mon, 30 Dec 2013 02:47:29 -0500 Received: by mail-wg0-f42.google.com with SMTP id a1so13836521wgh.1 for ; Sun, 29 Dec 2013 23:47:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=qBE58Q/1WcGgaD4QHJmYF7QorQU06a4xjhQjIWqStgo=; b=TrxfrX/5ac1NbOWP8gsE1nD+j6WMHPn3JGObsZNQytCkN2t+uz+JSs0jUNIjeihnVx PNtuDd45jgZaHLaJs+VIv0ewriKpv6eNqrDWklSW1XeA3GsMRe+fHaSirfElm5id7VDP 0hOizWv7bDkcIM1kjsemKAC7qhXUgVDthTwYQhOA09ZVN8gkeBIMwXfo1Tjsr6G0+za9 JEMTiYS1C7HDlF+IeDZ/gP2+ZbAkoXEUsClNLRS6FUwCLyT140DhZ2ufBen5UlbGYVIF RxjiZNTwP8Kaas7biIIMNwevPQZsrMIur9xokzTqsH7HUAXAE+raDQXxdC1aOC0DjmWT oaPg== X-Received: by 10.180.9.196 with SMTP id c4mr25666067wib.16.1388389648072; Sun, 29 Dec 2013 23:47:28 -0800 (PST) Received: from ?IPv6:2001:67c:20a1:1068:3e97:eff:fe6a:16ab? ([2001:67c:20a1:1068:3e97:eff:fe6a:16ab]) by mx.google.com with ESMTPSA id po3sm25137827wjc.3.2013.12.29.23.47.26 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 29 Dec 2013 23:47:26 -0800 (PST) Message-ID: <52C1250D.2040906@gmail.com> Date: Mon, 30 Dec 2013 08:47:25 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] grub-core/term/efi/console.c: Use EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL if available References: <20131229070445.GA28511@leaf> In-Reply-To: <20131229070445.GA28511@leaf> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FGlfao13BRuEQ4EV9IkVxpFnH8MxkXrKT" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::22a X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Dec 2013 07:47:35 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FGlfao13BRuEQ4EV9IkVxpFnH8MxkXrKT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 29.12.2013 08:04, Josh Triplett wrote: > + term->data =3D grub_efi_locate_protocol(&simple_text_input_ex_guid, = NULL); This will find the first handle that provides EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL, not necessarily the same as normal console and you may inadvertently switch to another console. You have to look for protocols on input handle. > + if (shift_state & (GRUB_EFI_RIGHT_SHIFT_PRESSED | GRUB_EFI_LEFT_SHIFT_PRESSED)) > + result |=3D GRUB_TERM_SHIFT; The keys which have natural meaning for shifted version never should receive GRUB_TERM_SHIFT. E.g. Shift+d should give 'D', not 'd'|GRUB_TERM_SHIFT. Easiest way is to add GRUB_TERM_SHIFT only if GRUB_TERM_EXTENDED is already present. What about providing keystatus function? --FGlfao13BRuEQ4EV9IkVxpFnH8MxkXrKT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlLBJQ0ACgkQmBXlbbo5nOuQZAD/Vf6sBer5xKxdHmqeISR7TpoR xE3v/A7JODCsDRUau7EA/Aga6bunF79yOU00ofBG6mKOmN/tCW7/c8gq2fepQtO/ =pVFx -----END PGP SIGNATURE----- --FGlfao13BRuEQ4EV9IkVxpFnH8MxkXrKT--