Re: [PATCH] Add apple_set_os command

From: SevenBits <sevenbitstech@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] Add apple_set_os command
Date: Fri, 03 Jan 2014 13:38:04 -0500	[thread overview]
Message-ID: <52C7038C.3090404@gmail.com> (raw)
In-Reply-To: <52C65CCF.7070801@gmail.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/03/2014 01:46 AM, Vladimir '?-coder/phcoder' Serbinenko wrote:
> On 31.12.2013 00:11, SevenBits wrote:
>> On Monday, December 30, 2013, Andreas Heider wrote:
>> 
>> The EFI on current macbooks configures hardware differently
>> depending on wether it is booting Mac OS X or a different os, for
>> example disabling the internal GPU completely on some models.
>> 
>> Mac OS X identifies itself using a custom EFI protocol.
>> 
>> This adds a command that fakes the os identification, making all 
>> hardware accessible.
>> 
>> 
>> Just a question: I do a lot of booting Linux on MacBooks, and I 
>> frequently suffer from this issue. How do we know that this code 
>> actually works?
> Run on a mac with this code and without and compare results. The
> ship of "works by sane design" has long since sailed away. For
> most manufacturers it's somewhere in Moon orbit but for apple it
> has long since left solar system.
So, Andreas, I tried your patch, and... no dice. The Mac behaves
exactly as before. I'm afraid it didn't appear to do anything for me.

Furthermore, your patch didn't print any output. There wasn't any
error message returned (i.e your "Could not locate the apple set os
protocol." message on line 52-53). When I invoked your command from
the GRUB normal prompt, it DID print the message however. Perhaps it
doesn't fail if called from within a grub.cfg, or maybe it simply
doesn't print.

The Mac that I tested on was a MacBook Pro from early 2008. Clearly,
this function isn't present on all models. I can try it on others and
seeing if it works on them, however.

Also, why the if statements on lines 59 and 65, which indicate whether
the OS version and/or vendor was set. What is the point of them? Why
not just call the functions directly?
> 
> 
> 
> _______________________________________________ Grub-devel mailing
> list Grub-devel@gnu.org 
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJSxwOMAAoJEFbRvtGxmFPELWoH+QGu7aLuDam0vY+xW8h4TdFw
ckY51K8vgEGlpUNvK2fwQnnAt57W3jH14HBIRY1IaC+c9XA3mooqp748xh0jfoV/
D95lZJuYu3XP4iFYtCehcCVOiz+x4DNXMnT6WA6hd5FjPT9xqbBqf/9RxSpN9O+i
ZGbSe/ZQkOvTyLXJ11L3SeTlNi9jqA03mLaMrMi7Ehb7AU3hBkiSMpiiIcUjnP3o
ZskQrSkguqt9Kt+FlHheTJkpAitqqJR/GpHkegg3bNGLrflacVGITMFFw0EsJP4R
h0fsEocfYnvSVPrw07SJVFvt2TzPGB69p5QXy11cU1ZBYUhILcG7rDTAmVctZig=
=wKye
-----END PGP SIGNATURE-----