From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W0a7d-0003Yo-Vz for mharc-grub-devel@gnu.org; Tue, 07 Jan 2014 12:07:22 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0a7X-0003WZ-1Q for grub-devel@gnu.org; Tue, 07 Jan 2014 12:07:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0a7R-0006Ol-29 for grub-devel@gnu.org; Tue, 07 Jan 2014 12:07:14 -0500 Received: from mail-ee0-x22d.google.com ([2a00:1450:4013:c00::22d]:40987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0a7Q-0006Od-RW for grub-devel@gnu.org; Tue, 07 Jan 2014 12:07:08 -0500 Received: by mail-ee0-f45.google.com with SMTP id d49so200413eek.32 for ; Tue, 07 Jan 2014 09:07:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=OvKrO0axUF4klLqArkUpqILOwOMsc9J+CvA+hchKU9k=; b=F/3M3TTxu6WMwrpFh5XNBGH20/vztHICDrT3JNfSutj74yixiQkW3QmmdnohZa8rAF fEbAKS7lx5SN4BikoNBmy3RplgnwSDqHzswTzAFUxjKWDrRgYT16Tmp5RMsG8ztW7UWR FrPLyiloCuMJj2W2UT6XiT3Q8QJ32E+OVmhS5KCwnT7VyT5bH/5BOnGFFMvuFOrxKOrC QRnPO1Unw4UUOBuHe/l9RDt8BhO+nH2amX+oxVQhNmXdLnn678KifMBmMws7ABY0HlXe wticXkieBCrcn1qWrKgkH7jATQFLZzGC+0DbMOP00anhHza3vcNn3YeUoJ5fHexpayXx KBlA== X-Received: by 10.14.105.134 with SMTP id k6mr75950eeg.116.1389114428120; Tue, 07 Jan 2014 09:07:08 -0800 (PST) Received: from [192.168.1.16] (85-188.196-178.cust.bluewin.ch. [178.196.188.85]) by mx.google.com with ESMTPSA id n7sm1245982eef.5.2014.01.07.09.07.06 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 07 Jan 2014 09:07:07 -0800 (PST) Message-ID: <52CC3439.1060109@gmail.com> Date: Tue, 07 Jan 2014 18:07:05 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [patch] arm64: set correct length of device path end entry References: <20140107170607.GB30907@bivouac.eciton.net> In-Reply-To: <20140107170607.GB30907@bivouac.eciton.net> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IKGtcXeAqKrlkVTeA049aGC6vfiHjjtwr" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::22d X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jan 2014 17:07:20 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IKGtcXeAqKrlkVTeA049aGC6vfiHjjtwr Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Go ahead. On 07.01.2014 18:06, Leif Lindholm wrote: > The length of the Device Path End entry in the grub_linux_boot() > funtcion is incorrectly set to 0. This triggers an assert failure > in debug builds of Tianocore. >=20 > The correct length is 4 bytes (1 byte type, 1 byte subtype, > 2 bytes length). >=20 > Reported-by: Mark Salter >=20 > diff --git a/grub-core/loader/arm64/linux.c b/grub-core/loader/arm64/li= nux.c > index 9d15aad..7c9bc2b 100644 > --- a/grub-core/loader/arm64/linux.c > +++ b/grub-core/loader/arm64/linux.c > @@ -268,7 +268,7 @@ grub_linux_boot (void) > =20 > mempath[1].header.type =3D GRUB_EFI_END_DEVICE_PATH_TYPE; > mempath[1].header.subtype =3D GRUB_EFI_END_ENTIRE_DEVICE_PATH_SUBTYP= E; > - mempath[1].header.length =3D 0; > + mempath[1].header.length =3D 4; > =20 > b =3D grub_efi_system_table->boot_services; > status =3D b->load_image (0, grub_efi_image_handle, >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --IKGtcXeAqKrlkVTeA049aGC6vfiHjjtwr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlLMNDkACgkQmBXlbbo5nOtV1gD/RoC1wM8fNNOHjp3Jlo4bKasI fIiVr4/twXy1LboBrhcA+gKLz/BA7Ob0dj94qjudIVxxJ/JIlleIJIlHPNAH715O =q1Q2 -----END PGP SIGNATURE----- --IKGtcXeAqKrlkVTeA049aGC6vfiHjjtwr--