[patch] arm64: set correct length of device path end entry

[patch] arm64: set correct length of device path end entry

[Leif Lindholm]

The length of the Device Path End entry in the grub_linux_boot()
funtcion is incorrectly set to 0. This triggers an assert failure
in debug builds of Tianocore.

The correct length is 4 bytes (1 byte type, 1 byte subtype,
2 bytes length).

Reported-by: Mark Salter <msalter@redhat.com>

diff --git a/grub-core/loader/arm64/linux.c b/grub-core/loader/arm64/linux.c
index 9d15aad..7c9bc2b 100644
--- a/grub-core/loader/arm64/linux.c
+++ b/grub-core/loader/arm64/linux.c
@@ -268,7 +268,7 @@ grub_linux_boot (void)
 
   mempath[1].header.type = GRUB_EFI_END_DEVICE_PATH_TYPE;
   mempath[1].header.subtype = GRUB_EFI_END_ENTIRE_DEVICE_PATH_SUBTYPE;
-  mempath[1].header.length = 0;
+  mempath[1].header.length = 4;
 
   b = grub_efi_system_table->boot_services;
   status = b->load_image (0, grub_efi_image_handle,

Re: [patch] arm64: set correct length of device path end entry

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

Go ahead.
On 07.01.2014 18:06, Leif Lindholm wrote:
> The length of the Device Path End entry in the grub_linux_boot()
> funtcion is incorrectly set to 0. This triggers an assert failure
> in debug builds of Tianocore.
> 
> The correct length is 4 bytes (1 byte type, 1 byte subtype,
> 2 bytes length).
> 
> Reported-by: Mark Salter <msalter@redhat.com>
> 
> diff --git a/grub-core/loader/arm64/linux.c b/grub-core/loader/arm64/linux.c
> index 9d15aad..7c9bc2b 100644
> --- a/grub-core/loader/arm64/linux.c
> +++ b/grub-core/loader/arm64/linux.c
> @@ -268,7 +268,7 @@ grub_linux_boot (void)
>  
>    mempath[1].header.type = GRUB_EFI_END_DEVICE_PATH_TYPE;
>    mempath[1].header.subtype = GRUB_EFI_END_ENTIRE_DEVICE_PATH_SUBTYPE;
> -  mempath[1].header.length = 0;
> +  mempath[1].header.length = 4;
>  
>    b = grub_efi_system_table->boot_services;
>    status = b->load_image (0, grub_efi_image_handle,
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 274 bytes --]

Re: [patch] arm64: set correct length of device path end entry

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]

On 07.01.2014 18:06, Leif Lindholm wrote:
> The length of the Device Path End entry in the grub_linux_boot()
> funtcion is incorrectly set to 0. This triggers an assert failure
> in debug builds of Tianocore.
> 
> The correct length is 4 bytes (1 byte type, 1 byte subtype,
> 2 bytes length).
> 
> Reported-by: Mark Salter <msalter@redhat.com>
> 
> diff --git a/grub-core/loader/arm64/linux.c b/grub-core/loader/arm64/linux.c
> index 9d15aad..7c9bc2b 100644
> --- a/grub-core/loader/arm64/linux.c
> +++ b/grub-core/loader/arm64/linux.c
> @@ -268,7 +268,7 @@ grub_linux_boot (void)
>  
>    mempath[1].header.type = GRUB_EFI_END_DEVICE_PATH_TYPE;
>    mempath[1].header.subtype = GRUB_EFI_END_ENTIRE_DEVICE_PATH_SUBTYPE;
> -  mempath[1].header.length = 0;
> +  mempath[1].header.length = 4;
> 
Could you use sizeof ?

>    b = grub_efi_system_table->boot_services;
>    status = b->load_image (0, grub_efi_image_handle,
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 274 bytes --]