From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W0aCE-000760-Nf for mharc-grub-devel@gnu.org; Tue, 07 Jan 2014 12:12:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0aC7-000737-UR for grub-devel@gnu.org; Tue, 07 Jan 2014 12:12:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0aC2-00084k-Kt for grub-devel@gnu.org; Tue, 07 Jan 2014 12:11:59 -0500 Received: from mail-ea0-x236.google.com ([2a00:1450:4013:c01::236]:44151) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0aC2-00084e-ER for grub-devel@gnu.org; Tue, 07 Jan 2014 12:11:54 -0500 Received: by mail-ea0-f182.google.com with SMTP id a15so345825eae.13 for ; Tue, 07 Jan 2014 09:11:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=lpWIokyAu9sJrwRV5DZGFVJrEUCzGieJvHn23VfYbJ4=; b=gG4epm/zgjgjclzwlBLEvZEhC6oNjIIBjVSBMppqgLQJffY83kYgKDfYQfKmfh4tA2 cOC/kBh8g/rJ3yEX8QACK2jvb7Kyd6CklyrenJNVjM4/66VKKPvP6nqEbRsk0xG+mjcG +HAY1KLnFmM+bEn/sQaO60b68JJX2K0iYg+WPREtcac1Oj8Wbj1gMdErg9mfIEzFYVpL AVJrqpiMgQJUzWhLkQ6ScZTEUAP/zmrPus3yEJgfRP3ToPC2eBDqtv4B6BbDH2fzJy4B kkIGa7UXR2BlYkxVGnZB0QFYC6F7aSnBMjquliHcCDnf5YFPaxIJ7rg8lAc4nXkCahMC C2YA== X-Received: by 10.15.63.78 with SMTP id l54mr389860eex.39.1389114713391; Tue, 07 Jan 2014 09:11:53 -0800 (PST) Received: from [192.168.1.16] (85-188.196-178.cust.bluewin.ch. [178.196.188.85]) by mx.google.com with ESMTPSA id e3sm181762043eeg.11.2014.01.07.09.11.52 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 07 Jan 2014 09:11:52 -0800 (PST) Message-ID: <52CC3557.8040200@gmail.com> Date: Tue, 07 Jan 2014 18:11:51 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [patch] arm64: set correct length of device path end entry References: <20140107170607.GB30907@bivouac.eciton.net> In-Reply-To: <20140107170607.GB30907@bivouac.eciton.net> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lgAUdLp7lM7qepMgd5RbfNRd46d36HFef" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::236 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jan 2014 17:12:05 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lgAUdLp7lM7qepMgd5RbfNRd46d36HFef Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07.01.2014 18:06, Leif Lindholm wrote: > The length of the Device Path End entry in the grub_linux_boot() > funtcion is incorrectly set to 0. This triggers an assert failure > in debug builds of Tianocore. >=20 > The correct length is 4 bytes (1 byte type, 1 byte subtype, > 2 bytes length). >=20 > Reported-by: Mark Salter >=20 > diff --git a/grub-core/loader/arm64/linux.c b/grub-core/loader/arm64/li= nux.c > index 9d15aad..7c9bc2b 100644 > --- a/grub-core/loader/arm64/linux.c > +++ b/grub-core/loader/arm64/linux.c > @@ -268,7 +268,7 @@ grub_linux_boot (void) > =20 > mempath[1].header.type =3D GRUB_EFI_END_DEVICE_PATH_TYPE; > mempath[1].header.subtype =3D GRUB_EFI_END_ENTIRE_DEVICE_PATH_SUBTYP= E; > - mempath[1].header.length =3D 0; > + mempath[1].header.length =3D 4; >=20 Could you use sizeof ? > b =3D grub_efi_system_table->boot_services; > status =3D b->load_image (0, grub_efi_image_handle, >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --lgAUdLp7lM7qepMgd5RbfNRd46d36HFef Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlLMNVcACgkQmBXlbbo5nOvJrwD/VCWmdXQfp1n4Gog8WlSaZ/5t yVL8ZMbx3OkcJOGmBqYBAI7+yqefJt+YLlKqu6xvrzHIQXDqYfwecC1mbJ+MmXyi =UeNn -----END PGP SIGNATURE----- --lgAUdLp7lM7qepMgd5RbfNRd46d36HFef--