From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W23bT-0004m4-2n for mharc-grub-devel@gnu.org; Sat, 11 Jan 2014 13:48:15 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W23bJ-0004cb-OK for grub-devel@gnu.org; Sat, 11 Jan 2014 13:48:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W23bB-0008Dl-BU for grub-devel@gnu.org; Sat, 11 Jan 2014 13:48:05 -0500 Received: from mail-ea0-x234.google.com ([2a00:1450:4013:c01::234]:49898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W23bB-0008Df-5A for grub-devel@gnu.org; Sat, 11 Jan 2014 13:47:57 -0500 Received: by mail-ea0-f180.google.com with SMTP id f15so2594298eak.11 for ; Sat, 11 Jan 2014 10:47:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=XbvuZVr3RfsuJKscUfKHYIZ7moS7PbKPIYPW96ehLSE=; b=blv8kN98URIXycBdzIawXRJprNcFDkaqpWZflWNqlE25mgcXGTXGn7C8+TfVm8xHwd s9NU4MOoAB9/y1hv1vpkyfPdTxHmYCM+6ZN9Bu4zJgke3FI9dI5AHuAN5U0S5sfRWGCZ Ep4goUxI6OAE9hHVHoM8aeFz9i4gyOx/4RE8IV/EI64xCi0pBRdY7ihrPwiMRa3Jdnc5 CMJuyekAKAzfnEthz9JBTP6BHhov7QS/6IkFjUWTdGWoU5PyoMq+tTXytN5ZCaUZH+9D G8uRefbWBhJKF9/eIXq8/bzlG2rbkZXBkspzoPWCGCyq321JyJ9nxaRIxeam43q0dlDW X6AQ== X-Received: by 10.14.48.74 with SMTP id u50mr866930eeb.107.1389466075753; Sat, 11 Jan 2014 10:47:55 -0800 (PST) Received: from [192.168.1.16] (85-188.196-178.cust.bluewin.ch. [178.196.188.85]) by mx.google.com with ESMTPSA id l4sm24962596een.13.2014.01.11.10.47.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 11 Jan 2014 10:47:54 -0800 (PST) Message-ID: <52D15BFC.8070509@gmail.com> Date: Sat, 11 Jan 2014 15:58:04 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] add part_apple to EFI rescue image to fix missing prefix References: <1389119495-4399-1-git-send-email-arvidjaar@gmail.com> In-Reply-To: <1389119495-4399-1-git-send-email-arvidjaar@gmail.com> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4b80CCBWBcwjkJ5Um1kD0DAa6jf4mS74X" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::234 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jan 2014 18:48:14 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4b80CCBWBcwjkJ5Um1kD0DAa6jf4mS74X Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07.01.2014 19:31, Andrey Borzenkov wrote: > On Mac rescue image is booted from HFS+ partition, so bootpath looks li= ke > /ACPI(a0341d0,0)/PCI(1,1f)/ATAPI(0,0,0)/HD(3,5d1,ca3,0000000000000000,2= 0,0)/EndEntire >=20 > grub fails to find device for this path because it cannot scan partitio= n > table. The simplest fix is to add part_apple by default. >=20 > --- > util/grub-mkrescue.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/util/grub-mkrescue.c b/util/grub-mkrescue.c > index 0d03e55..30bb701 100644 > --- a/util/grub-mkrescue.c > +++ b/util/grub-mkrescue.c > @@ -316,9 +316,11 @@ make_image_fwdisk_abs (enum grub_install_plat plat= , > fclose (load_cfg_f); > =20 > grub_install_push_module ("iso9660"); > + grub_install_push_module ("part_apple"); > grub_install_make_image_wrap (source_dirs[plat], "()/boot/grub", out= put, > 0, load_cfg, mkimage_target, 0); > grub_install_pop_module (); > + grub_install_pop_module (); This needs to be either limited to the 3 platforms in question (powerpc-ieee1275, i386-efi, x86_64-efi) or extended to all platforms. I prefer former. > } > =20 > static int >=20 --4b80CCBWBcwjkJ5Um1kD0DAa6jf4mS74X Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlLRXAgACgkQmBXlbbo5nOv7vgEAr64b3R0Rwj0wWUy8C3sD0wcB kRZaunzxXMuHiF3cAOIA/R/qfpyzuT2s6Vq/IAW5vxLhffUn9Y4+x+gWT/ybctPe =kHfu -----END PGP SIGNATURE----- --4b80CCBWBcwjkJ5Um1kD0DAa6jf4mS74X--