From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W2IuT-0004kC-6t for mharc-grub-devel@gnu.org; Sun, 12 Jan 2014 06:08:53 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2IuM-0004ij-4j for grub-devel@gnu.org; Sun, 12 Jan 2014 06:08:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2IuG-0002ms-Oe for grub-devel@gnu.org; Sun, 12 Jan 2014 06:08:46 -0500 Received: from mail-ea0-x230.google.com ([2a00:1450:4013:c01::230]:43618) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2IuG-0002mn-Cm for grub-devel@gnu.org; Sun, 12 Jan 2014 06:08:40 -0500 Received: by mail-ea0-f176.google.com with SMTP id h14so2753745eaj.21 for ; Sun, 12 Jan 2014 03:08:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=xfPK189fONC5wp8XiMl4IiWD6B8fgEEod0JbzNqTslc=; b=ZJO/IiTE+xFi2L1EMU74Ptrvw+HzhJSTEDPwcHYCBK2lfT1T+afWQC314pYbXOAE3M 8JjxgzS0kTvLG30Pdf87fQ8yyyGcmtvACoszFXgc2j3JI7x1FXsoRgR3o2KlqgZWHPuE HzWlmU30wOX5NL54e3VmHUDMPODtQxfbYPBKITUOcLF336OnN7+eSc4xQlV+WnbJSQVD oRqPMFkqVhqq9g9jAcW/yNNXoZNJVofrSjzcuAXaoGVsC0E3SUU60Upg9bEWsBbMJjYF aqsSEc/+x3hO1GFLXaR3JmyT6TNqMZqAp2DHe1LwjnK2fJD7CWsSE0DywcUmmFkjLckD ygSQ== X-Received: by 10.14.99.129 with SMTP id x1mr21000555eef.89.1389524919354; Sun, 12 Jan 2014 03:08:39 -0800 (PST) Received: from [192.168.1.16] (85-188.196-178.cust.bluewin.ch. [178.196.188.85]) by mx.google.com with ESMTPSA id b41sm30157011eef.16.2014.01.12.03.08.38 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 12 Jan 2014 03:08:38 -0800 (PST) Message-ID: <52D277AE.20505@gmail.com> Date: Sun, 12 Jan 2014 12:08:30 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] add part_apple to EFI rescue image to fix missing prefix References: <1389119495-4399-1-git-send-email-arvidjaar@gmail.com> <52D15BFC.8070509@gmail.com> <20140112113147.246fa792@opensuse.site> In-Reply-To: <20140112113147.246fa792@opensuse.site> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QGu8o5KGU3aPPF0QjO696w36ipFC2wGux" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::230 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Jan 2014 11:08:51 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QGu8o5KGU3aPPF0QjO696w36ipFC2wGux Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12.01.2014 08:31, Andrey Borzenkov wrote: > =D0=92 Sat, 11 Jan 2014 15:58:04 +0100 > Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0= =B8=D1=88=D0=B5=D1=82: >=20 >> On 07.01.2014 19:31, Andrey Borzenkov wrote: >>> On Mac rescue image is booted from HFS+ partition, so bootpath looks = like >>> /ACPI(a0341d0,0)/PCI(1,1f)/ATAPI(0,0,0)/HD(3,5d1,ca3,0000000000000000= ,20,0)/EndEntire >>> >>> grub fails to find device for this path because it cannot scan partit= ion >>> table. The simplest fix is to add part_apple by default. >>> >>> --- >>> util/grub-mkrescue.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/util/grub-mkrescue.c b/util/grub-mkrescue.c >>> index 0d03e55..30bb701 100644 >>> --- a/util/grub-mkrescue.c >>> +++ b/util/grub-mkrescue.c >>> @@ -316,9 +316,11 @@ make_image_fwdisk_abs (enum grub_install_plat pl= at, >>> fclose (load_cfg_f); >>> =20 >>> grub_install_push_module ("iso9660"); >>> + grub_install_push_module ("part_apple"); >>> grub_install_make_image_wrap (source_dirs[plat], "()/boot/grub", o= utput, >>> 0, load_cfg, mkimage_target, 0); >>> grub_install_pop_module (); >>> + grub_install_pop_module (); >> This needs to be either limited to the 3 platforms in question >> (powerpc-ieee1275, i386-efi, x86_64-efi) or extended to all platforms.= I >> prefer former. >=20 > Like below? >=20 Yes, go ahead. > From: Andrey Borzenkov > Subject: [PATCH] add part_apple to EFI rescue image to fix missing pref= ix >=20 > On Mac rescue image is booted from HFS+ partition, so bootpath looks li= ke > /ACPI(a0341d0,0)/PCI(1,1f)/ATAPI(0,0,0)/HD(3,5d1,ca3,0000000000000000,2= 0,0)/EndEntire >=20 > grub fails to find device for this path because it cannot scan partitio= n > table. The simplest fix is to add part_apple by default. >=20 > --- > util/grub-mkrescue.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/util/grub-mkrescue.c b/util/grub-mkrescue.c > index 0d03e55..34e0b7a 100644 > --- a/util/grub-mkrescue.c > +++ b/util/grub-mkrescue.c > @@ -653,11 +653,15 @@ main (int argc, char *argv[]) > make_image_fwdisk_abs (GRUB_INSTALL_PLATFORM_IA64_EFI, "ia64-efi= ", imgname); > free (imgname); > =20 > + grub_install_push_module ("part_apple"); > img64 =3D grub_util_path_concat (2, efidir_efi_boot, "bootx64.ef= i"); > make_image_fwdisk_abs (GRUB_INSTALL_PLATFORM_X86_64_EFI, "x86_64= -efi", img64); > + grub_install_pop_module (); > =20 > + grub_install_push_module ("part_apple"); > img32 =3D grub_util_path_concat (2, efidir_efi_boot, "bootia32.e= fi"); > make_image_fwdisk_abs (GRUB_INSTALL_PLATFORM_I386_EFI, "i386-efi= ", img32); > + grub_install_pop_module (); > =20 > imgname =3D grub_util_path_concat (2, efidir_efi_boot, "bootarm.= efi"); > make_image_fwdisk_abs (GRUB_INSTALL_PLATFORM_ARM_EFI, "arm-efi",= imgname); > @@ -707,7 +711,9 @@ main (int argc, char *argv[]) > free (efidir); > } > =20 > + grub_install_push_module ("part_apple"); > make_image_fwdisk (GRUB_INSTALL_PLATFORM_POWERPC_IEEE1275, "powerpc-= ieee1275", "powerpc-ieee1275/core.elf"); > + grub_install_pop_module (); > =20 > if (source_dirs[GRUB_INSTALL_PLATFORM_POWERPC_IEEE1275]) > { >=20 >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --QGu8o5KGU3aPPF0QjO696w36ipFC2wGux Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlLSd7UACgkQmBXlbbo5nOvLnwD/aYODoGjiwtoGz3awXrtW0IBl ttXnEKT8Dx9FsuH+9XkBAJVKfY55Gzt20bV761lHn4ihsR1CmvvkcUK2alkUvjJZ =daeo -----END PGP SIGNATURE----- --QGu8o5KGU3aPPF0QjO696w36ipFC2wGux--