grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: conflicting types for 'grub_list_push' on MinGW (include loop)
Date: Mon, 13 Jan 2014 23:00:47 +0100	[thread overview]
Message-ID: <52D4620F.5000805@gmail.com> (raw)
In-Reply-To: <20140113234455.0dfb7b9b@opensuse.site>

[-- Attachment #1: Type: text/plain, Size: 973 bytes --]

On 13.01.2014 20:44, Andrey Borzenkov wrote:
> В Mon, 13 Jan 2014 18:33:41 +0000
> Colin Watson <cjwatson@ubuntu.com> пишет:
> 
>> On Mon, Jan 13, 2014 at 10:17:05PM +0400, Andrey Borzenkov wrote:
>>> I'm not sure what to do here. list.h needs misc.h apparently only for
>>> definition of ATTRIBUTE_ERROR which in turn does  not appear to be used
>>> anywhere else. This is not fatal so may be can be ignored for now, but
>>> still would be nice to clean up.
>>
>> Maybe we could instead move grub_strtol into grub-core/kern/misc.c,
>> after which we'd no longer need to include <grub/i18n.h> from
>> <grub/misc.h>?
>>
> 
> I'd rather move compiler features into separate file (like
> grub/compiler.h) and include it from misc.h and separately from list.h.
> 
This would be a good idea.
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 274 bytes --]

  reply	other threads:[~2014-01-13 22:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-13 18:17 conflicting types for 'grub_list_push' on MinGW (include loop) Andrey Borzenkov
2014-01-13 18:33 ` Colin Watson
2014-01-13 19:44   ` Andrey Borzenkov
2014-01-13 22:00     ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2014-01-15 18:14       ` Andrey Borzenkov
2014-01-18 17:12         ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-01-18 17:13           ` SevenBits
2014-01-13 22:00   ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-01-14  2:49     ` Andrey Borzenkov
2014-01-14 11:12       ` Colin Watson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52D4620F.5000805@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).