From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES
Date: Sat, 18 Jan 2014 19:08:35 +0100 [thread overview]
Message-ID: <52DAC323.60709@gmail.com> (raw)
In-Reply-To: <20140118211202.20f09930@opensuse.site>
[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]
On 18.01.2014 18:12, Andrey Borzenkov wrote:
> В Sat, 18 Jan 2014 17:55:38 +0100
> Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
>
>> On 18.01.2014 17:27, Andrey Borzenkov wrote:
>>> While on it, pass detected
>>> nm arguments instead of hardcoding them.
>> please make this part a separate patch.
>
> is it OK to commit without this part?
>
could you send the remaining part alone? It's difficult to see throught
intermingled patch.
>> This would indicate that you
>> support non-portable nm output which in this branch isn't the case. Why
>> do you need it in the first place?
>>
>
> I do not need it for MinGW case; but it just looks incorrect in general
> case - first we check nm arguments and then ignore it.
Because relevant support in scripts isn't available yet.
> I agree that
> mixing two patches was wrong on my side.
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 274 bytes --]
next prev parent reply other threads:[~2014-01-18 18:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-18 16:27 [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES Andrey Borzenkov
2014-01-18 16:55 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-01-18 17:12 ` Andrey Borzenkov
2014-01-18 18:08 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2014-01-18 18:36 ` Andrey Borzenkov
2014-01-18 19:05 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DAC323.60709@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).