From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W5WUk-0000LS-7S for mharc-grub-devel@gnu.org; Tue, 21 Jan 2014 03:15:38 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5WUd-0000Ee-M4 for grub-devel@gnu.org; Tue, 21 Jan 2014 03:15:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W5WUY-00071N-Oj for grub-devel@gnu.org; Tue, 21 Jan 2014 03:15:31 -0500 Received: from mail-ee0-x22e.google.com ([2a00:1450:4013:c00::22e]:63594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W5WUY-00070c-Dj for grub-devel@gnu.org; Tue, 21 Jan 2014 03:15:26 -0500 Received: by mail-ee0-f46.google.com with SMTP id c13so3710200eek.5 for ; Tue, 21 Jan 2014 00:15:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=hqlOFLUteQz7ALozNgihAh0CNSBjx9gxFAMGIhUzl4Q=; b=pshQfZuEsi92qgojCMK2QY+jAAp1iSc2N0apjITNKHNVJqk6v2VmsL8LYN4Jth9CTP Zcxyi3EQsS6m5yl+BDZDd4+63cXObboR9JmrsCtDUHx3LloFMkNwIfGd6vriaNvgramq oxLk0jZIPovuxeir22J+ZUfhD30uWrcGpxlrJY9oMcdh8D/LjxsFSCT2mqbXAIfTfEe3 LeO7mnfFoiiiFdezDi0Tma4TvDZDTxu3jQ3A6EaNK762oCs9Zmu+86sglBvZp+EnLuvh p31sZgJHNKyfvyeR110A/xVpz4/mmScUF26nzuffBww3Cmljv8hfnD6AkwZRYfO7e1Ic JyuQ== X-Received: by 10.14.95.2 with SMTP id o2mr226366eef.69.1390292125661; Tue, 21 Jan 2014 00:15:25 -0800 (PST) Received: from [192.168.42.236] (83-224.197-178.cust.bluewin.ch. [178.197.224.83]) by mx.google.com with ESMTPSA id o13sm11934762eex.19.2014.01.21.00.15.22 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 21 Jan 2014 00:15:23 -0800 (PST) Message-ID: <52DE2477.3040209@gmail.com> Date: Tue, 21 Jan 2014 08:40:39 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.2.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] Improve DejaVuSans detection References: <1389528954-24812-1-git-send-email-arvidjaar@gmail.com> <1390060691-9862-1-git-send-email-arvidjaar@gmail.com> <52DAAB28.7060606@gmail.com> <20140118210438.43692ccb@opensuse.site> In-Reply-To: <20140118210438.43692ccb@opensuse.site> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BNWu1VDJwWc8g3WHm0XUHJNDCkBL5232H" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::22e X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jan 2014 08:15:36 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BNWu1VDJwWc8g3WHm0XUHJNDCkBL5232H Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 18.01.2014 18:04, Andrey Borzenkov wrote: > =D0=92 Sat, 18 Jan 2014 17:26:16 +0100 > Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0= =B8=D1=88=D0=B5=D1=82: >=20 >> On 18.01.2014 16:58, Andrey Borzenkov wrote: >>> Look also in /usr/share/fonts/truetype, it is installed in this path = on >>> openSUSE. >>> >>> Prefer DejaVuSansMono if found, on openSUSE DejaVuSans is proportiona= l font. >>> >> It's not right solution. Proportional fonts must be preffered for >> themes. Only terminal requires monospace fonts. You need to set >> gfxterm_font to unifont name. >=20 > But then not gfxterm_font, but we need to set it in theme definition. > gfxterm_font is optional and theme must still work without it. >=20 > From: Andrey Borzenkov > Subject: [PATCH] Improve DejaVuSans detection and fix starfield termina= l font >=20 > Look also in /usr/share/fonts/truetype, it is installed in this path on= > openSUSE. >=20 > Add detected path name to summary output. >=20 > Set terminal font to unifont in starfield; DejaVuSans is proportional a= nd looks > bad in terminal window. >=20 I've misread the patch in my first review. I thought it added a new behaviour of looking for DejaVuSans. > --- > configure.ac | 3 ++- > themes/starfield/theme.txt | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/configure.ac b/configure.ac > index cf3de3b..8888c2f 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1389,7 +1389,7 @@ fi > =20 > if test x"$starfield_excuse" =3D x; then > for ext in pcf pcf.gz bdf bdf.gz ttf ttf.gz; do > - for dir in . /usr/src /usr/share/fonts/X11/misc /usr/share/fonts/= truetype/ttf-dejavu /usr/share/fonts/dejavu; do > + for dir in . /usr/src /usr/share/fonts/X11/misc /usr/share/fonts/= truetype/ttf-dejavu /usr/share/fonts/dejavu /usr/share/fonts/truetype; do= Go ahead for this part. > if test -f "$dir/DejaVuSans.$ext"; then > DJVU_FONT_SOURCE=3D"$dir/DejaVuSans.$ext" > break 2 > @@ -1816,6 +1816,7 @@ echo grub-mount: No "($grub_mount_excuse)" > fi > if [ x"$starfield_excuse" =3D x ]; then > echo starfield theme: Yes > +echo With DejaVuSans font from $DJVU_FONT_SOURCE Go ahead for this as well. > else > echo starfield theme: No "($starfield_excuse)" > fi > diff --git a/themes/starfield/theme.txt b/themes/starfield/theme.txt > index 5ec871b..b3b8d85 100644 > --- a/themes/starfield/theme.txt > +++ b/themes/starfield/theme.txt > @@ -25,7 +25,7 @@ message-font: "DejaVu Sans Regular 12" > message-color: "#000" > message-bg-color: "#fff" > terminal-box: "terminal_box_*.png" > -terminal-font: "DejaVu Sans Regular 12" > +terminal-font: "Gnu Unifont Mono Regular 16" > desktop-image: "starfield.png" > =20 On my system I get name "Unifont Regular 16". Did you check unicode.pf2 to get this string? > #help bar at the bottom >=20 >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --BNWu1VDJwWc8g3WHm0XUHJNDCkBL5232H Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Icedove - http://www.enigmail.net/ iF4EAREKAAYFAlLeJHcACgkQmBXlbbo5nOsgsgD/Xl9SaVSX0u8ljWK5UF7ODhZ6 ZRE5jvOaik2bWW+7LZIA/Ry4ZHdcPsOD0asrATHAyPYzhOwYd/D+vsVFVjofVsDS =+H+2 -----END PGP SIGNATURE----- --BNWu1VDJwWc8g3WHm0XUHJNDCkBL5232H--