From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W9Vd8-00064z-1H for mharc-grub-devel@gnu.org; Sat, 01 Feb 2014 03:08:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9Vd1-00064Z-R0 for grub-devel@gnu.org; Sat, 01 Feb 2014 03:08:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W9Vcx-000081-13 for grub-devel@gnu.org; Sat, 01 Feb 2014 03:08:39 -0500 Received: from mo6-p00-ob.smtp.rzone.de ([2a01:238:20a:202:5300::10]:17104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W9Vcw-00007f-J6 for grub-devel@gnu.org; Sat, 01 Feb 2014 03:08:34 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1391242112; l=3685; s=domk; d=bubecks.de; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References: Subject:To:MIME-Version:From:Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=A8snjLD6Z1TzPxxPxzKy7ZC1pP0=; b=Ou0VT6ExbnQ0BIGeFW3atLG3ZasQsBB0S5V3iSgNjz199tll9A8aM95knabRGzjteDg Mvk+W/rSdNqpZj+8riw7dZPf1++Z9hWT8hWUtT5C0eLR7bWeJiRz3nSEkHaRneup8weV4 ahfeFVMBkQ4Vjrh2ooCoyFkwK7d+s6+Iybw= X-RZG-AUTH: :OGUIeEGmdd9LocaRWNUrTCqIQctGnGgg+eszxi8Zzh68aZhTiI3aYTRTQoGT2ZgUPJA= X-RZG-CLASS-ID: mo00 Received: from brain.bubecks.de (p3E9E97A3.dip0.t-ipconnect.de [62.158.151.163]) by smtp.strato.de (RZmta 32.23 DYNA|AUTH) with ESMTPSA id 403be6q117NT9l4 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate); Sat, 1 Feb 2014 08:23:29 +0100 (CET) Received: from kitschle.wid.reinform.de (fw.wid.reinform.de [10.2.1.254]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by brain.bubecks.de (Postfix) with ESMTPSA id CA8678850D for ; Sat, 1 Feb 2014 08:23:28 +0100 (CET) Message-ID: <52ECA0F0.4030302@bubecks.de> Date: Sat, 01 Feb 2014 08:23:28 +0100 From: "Dr. Tilmann Bubeck" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] Improve ext2 driver to allow embedding of the boot loader code. References: <1389301657-8236-1-git-send-email-tilmann@bubecks.de> <52CF282C.4070408@gmail.com> <52CFA5FF.7070200@bubecks.de> <52DE2C79.2000507@gmail.com> <52DE30AD.9030301@gmail.com> <52DE541E.2090600@gmail.com> <52DED0BC.8060902@bubecks.de> In-Reply-To: <52DED0BC.8060902@bubecks.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a01:238:20a:202:5300::10 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Feb 2014 08:08:44 -0000 Vladimir, Andrey, is there any chance, that you integrate this patch? As you probably know,there is a huge demand for embedding grub2 into ext4 filesystems. Is it ready for integration or should anything be changed? Thanks! Tilmann Am 21.01.2014 20:55, schrieb Dr. Tilmann Bubeck: > > The allocated space is reused every time on grub-setup execution. It > does not change, as long as it is big enough. As Andrew said, by > allocating 10 MB in the first run, it will be big enough for the > foreseeable future (currently core.img on my system is 30k). > > After issuing the ioctl(EXT4_IOC_SWAP_BOOT) it is not a file anymore. It > is only a (reserved) inode with data blocks. There is no filename > associated in any directory. So user tools have no way to manipulate the > data. > > fsck is aware of this and will not change anything or report any error. > > I do not see, why we need another user space tool for the initial > allocation. The initial reservation and subsequent use of the data > blocks can be done by grub-setup very easy and is already part of the > patch. > > > Tilmann > > > On 01/21/2014 12:03 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> On 21.01.2014 09:41, Andrey Borzenkov wrote: >>> On Tue, Jan 21, 2014 at 12:32 PM, Vladimir 'φ-coder/phcoder' >>> Serbinenko wrote: >>>> On 21.01.2014 09:28, Andrey Borzenkov wrote: >>>>> On Tue, Jan 21, 2014 at 12:14 PM, Vladimir 'φ-coder/phcoder' >>>>> Serbinenko wrote: >>>>>> On 10.01.2014 08:49, Dr. Tilmann Bubeck wrote: >>>>>>> >>>>>>> The blocklist is fixed and stable and will never change. >>>>>> What guarantees that it won't change on grub-setup invocation? I'm >>>>>> under >>>>>> impression that it will change on every grub-setup invocation as file >>>>>> gets recreated. >>>>>> >>>>> >>>>> If I read code correctly, it checks current size and if new core.img >>>>> fits, space is reused. So we could effectively make it preallocate >>>>> reasonable size (or even unreasonable - I guess 10MB will be enough >>>>> for foreseeable future) the very first time it is done. >>>>> >>>> It still doesn't solve the problem that during operations file >>>> becomes a >>>> normal file and OS is allowed to rearrange the blocks as it sees fit. >>> >>> Would this be acceptable - use external utility to allocate >>> EXT2_BOOT_LOADER_INO space of sufficient size once (outside of grub at >>> all) and allow embedding into extX if this space exists? Do not mess >>> with with it in grub-setup itself? >>> >> This presents a problem with sync'ing. After this space was reserved it >> won't appear when using block functions until next sync'ing. This would >> result in install failure on a new filesystem. >>> We could then speak with ext2 folks to add option to mke2fs/une2fs in >>> the long run it it does not exist yet. >>> >>> _______________________________________________ >>> Grub-devel mailing list >>> Grub-devel@gnu.org >>> https://lists.gnu.org/mailman/listinfo/grub-devel >>> >> >> >> >> >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> https://lists.gnu.org/mailman/listinfo/grub-devel >> > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel -- Mit freundlichen Gruessen, Tilmann Bubeck //// dr. tilmann bubeck, it professional & geek //// //// till@bubecks.de / http://www.bubecks.de //// mobile: 0172-8842972 / fon: 0711-7227719 / fax: 0711-7227734 //// widmaierstr. 58 / 70567 stuttgart / germany