From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] Make CTRL and ALT keys work as expected on EFI systems (version 5).
Date: Wed, 26 Feb 2014 19:51:34 +0100 [thread overview]
Message-ID: <530E37B6.1040806@gmail.com> (raw)
In-Reply-To: <6D165E863E048E4D86C25F15CEA532978707E64B@ORSMSX109.amr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1849 bytes --]
On 26.02.2014 03:58, Mroczek, Joseph T wrote:
>> From: Peter Jones
>> Sent: Tuesday, February 25, 2014 2:12 PM
>>
>> This is version 4.
>>
>> Changes from version 1:
>> - handles SHIFT as a modifier
>> - handles F11 and F12 keys
>> - uses the handle provided by the system table to find our _EX protocol.
>>
>> Changes from version 2:
>> - eliminate duplicate keycode translation.
>>
>> Changes from version 3:
>> - Do not add the shift modifier for any ascii character between space
>> (0x20) and DEL (0x7f); the combination of the modifier and many of the
>> keys causes it not to be recognized at all. Specifically, if we
>> include the modifier on any querty punctuation character, i.e.
>> anything the string "~!@#$%^&*()_+{}|:\"<>?" represents in C, it stops
>> being recognized whatsoever.
>>
>> Changes from version 4:
>> - Always initialize term->data from locate protocol (i.e. make it
>> unconditional.)
>>
>
> May I ask you to add one further extension. Add caps lock asserted to the conditions to bring up the menu. If this is not relevant to this patch or you wont add it, let me know and I will see if I can add on after the patch is accepted.
>
Has absolutely nothing to do with this patch.
> The reason for this is that there are some system that take as long as 15 minutes to post. Trying to hit a specific key in a small window (even 30s) is difficult. Allowing caps lock to perform the same action as holding shift allows the user to essentially queue the request for the menu. This behavior is consistent with how syslinux/pxelinux works.
>
> Thank you for any consideration you can pay this request.
>
> ~joe
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 274 bytes --]
next prev parent reply other threads:[~2014-02-26 18:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 22:12 [PATCH] Make CTRL and ALT keys work as expected on EFI systems (version 5) Peter Jones
2014-02-26 2:58 ` Mroczek, Joseph T
2014-02-26 18:51 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2015-10-10 18:48 ` Andrei Borzenkov
2015-10-12 14:19 ` Peter Jones
2015-10-12 14:47 ` Peter Jones
2015-10-13 3:50 ` Andrei Borzenkov
2015-10-25 15:41 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530E37B6.1040806@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).