From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WVkq4-0003TY-HO for mharc-grub-devel@gnu.org; Thu, 03 Apr 2014 12:50:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVkpx-0003RS-Cn for grub-devel@gnu.org; Thu, 03 Apr 2014 12:50:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVkps-0004pY-G0 for grub-devel@gnu.org; Thu, 03 Apr 2014 12:49:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVkps-0004pR-7v for grub-devel@gnu.org; Thu, 03 Apr 2014 12:49:52 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s33GnooR003706 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 3 Apr 2014 12:49:51 -0400 Received: from prarit-guest.khw.lab.eng.bos.redhat.com (prarit-guest.khw.lab.eng.bos.redhat.com [10.16.186.145]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s33Gnobg028820; Thu, 3 Apr 2014 12:49:50 -0400 Message-ID: <533D912E.6060102@redhat.com> Date: Thu, 03 Apr 2014 12:49:50 -0400 From: Prarit Bhargava User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131028 Thunderbird/17.0.10 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] Clarify "Press any key to continue..." message References: <20140403142317.GT32733@riva.ucam.org> In-Reply-To: <20140403142317.GT32733@riva.ucam.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: cjwatson@ubuntu.com X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Apr 2014 16:50:03 -0000 On 04/03/2014 10:23 AM, Colin Watson wrote: > When grub_wait_after_message says "Press any key to continue...", it > really means that it will continue anyway after a short delay, but that > you can press a key to skip the delay. Unfortunately, the delay is just > long enough that in practice a number of users have time to see it, > press a key, and then report a bug saying that their system won't boot > without manual intervention, even though it would have booted just fine > if they'd left it alone. Rephrase this message to make it clearer > what's really happening. I have mixed feelings about changing this message since it is such a well known message. OTOH, I've never really liked it myself. Maybe a better idea is to do a timeout message Press any key for menu (boot will continue in 5 seconds) ... Press any key for menu (boot will continue in 4 seconds) ... ... etc. ? > > * grub-core/normal/menu.c (grub_wait_after_message): Rephrase > message to make it clear that GRUB will continue even if the user > does not press a key. > --- > ChangeLog | 6 ++++++ > grub-core/normal/menu.c | 4 +++- > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/ChangeLog b/ChangeLog > index 6eca73e..53c2aff 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,9 @@ > +2014-04-03 Colin Watson > + > + * grub-core/normal/menu.c (grub_wait_after_message): Rephrase > + message to make it clear that GRUB will continue even if the user > + does not press a key. > + > 2014-03-31 Thomas Falcon > > btrfs: fix get_root key comparison failures due to endianness > diff --git a/grub-core/normal/menu.c b/grub-core/normal/menu.c > index b47991a..a6fa93c 100644 > --- a/grub-core/normal/menu.c > +++ b/grub-core/normal/menu.c > @@ -63,7 +63,9 @@ grub_wait_after_message (void) > { > grub_uint64_t endtime; > grub_xputs ("\n"); > - grub_printf_ (N_("Press any key to continue...")); > + grub_printf_ (N_( > + "Waiting a moment so that you can read previous messages.\n" > + "Press any key to skip this delay...")); > grub_refresh (); > > endtime = grub_get_time_ms () + 10000; >