grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Sree Harsha Totakura <sreeharsha@totakura.in>
To: grub-devel@gnu.org
Cc: Colin Watson <cjwatson@ubuntu.com>
Subject: Why ignore UUID when linux root device is an LV?
Date: Fri, 02 May 2014 14:54:13 +0200	[thread overview]
Message-ID: <53639575.6020109@totakura.in> (raw)

Hi,

I would like to know why UUID is not used for root device in Linux
kernel's `root=' parameter when the root device uses LVM.

The following is a snippet from util/10_linux.in:
> if [ "x${GRUB_DEVICE_UUID}" = "x" ] || [ "x${GRUB_DISABLE_LINUX_UUID}" = "xtrue" ] \
>     || ! test -e "/dev/disk/by-uuid/${GRUB_DEVICE_UUID}" \
>     || uses_abstraction "${GRUB_DEVICE}" lvm; then
>   LINUX_ROOT_DEVICE=${GRUB_DEVICE}
> else
>   LINUX_ROOT_DEVICE=UUID=${GRUB_DEVICE_UUID}
> fi

I have a setup where my root device resides on an LV which is created
from an LUKS encrypted partition.  The kernel's initramfs takes care of
opening the encrypted partition and exposing the logical volumes.  So, I
believe the condition `uses_abstraction "${GRUB_DEVICE}" lvm' is not
required; or am I missing anything?

From the commit log:
> commit 507736c87c49712ac618169d17a659bd6c25eecc
> Author: Colin Watson <cjwatson@ubuntu.com>
> Date:   Fri Jul 2 12:32:05 2010 +0100
> 
>     * util/grub-mkconfig_lib.in (uses_abstraction): New function.
>     * util/grub.d/10_linux.in: Use it to check for LVM, so that
>     LVM-on-RAID is handled correctly.

I see that this condition is added to address LVM/RAID configurations.
But, I guess it is similar to LVM/LUKS; is it not?

I tried booting my setup with root devices addressed by UUID and it
works.  In fact, some initramfs errors about not being to able to find
volume group are no longer present.  I guess these errors were apparent
when `root=/dev/mapper/vg0-root' parameter is used as the volume group
`vg0' is only visible after decrypting the LUKS partition.  When the
root device is addressed by UUID, the initramfs does not lookout for
`vg0' before opening LUKS partition.

Regards,
Sree


             reply	other threads:[~2014-05-02 12:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-02 12:54 Sree Harsha Totakura [this message]
2014-05-02 14:23 ` Why ignore UUID when linux root device is an LV? Colin Watson
2014-06-02 15:33   ` Andrey Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53639575.6020109@totakura.in \
    --to=sreeharsha@totakura.in \
    --cc=cjwatson@ubuntu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).