From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XAQho-0000Rd-Pf for mharc-grub-devel@gnu.org; Thu, 24 Jul 2014 17:37:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAQhn-0000PW-1w for grub-devel@gnu.org; Thu, 24 Jul 2014 17:37:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XAQhl-0003CW-Nf for grub-devel@gnu.org; Thu, 24 Jul 2014 17:37:38 -0400 Received: from mail-we0-x22e.google.com ([2a00:1450:400c:c03::22e]:65236) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAQhl-0003C9-H9 for grub-devel@gnu.org; Thu, 24 Jul 2014 17:37:37 -0400 Received: by mail-we0-f174.google.com with SMTP id x48so3340388wes.19 for ; Thu, 24 Jul 2014 14:37:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=nKFH+yGtcxX5vYb+pHEqk/bEikaiI3eRXdmgGjHB8IY=; b=KbLRlTmffTnCwOkkAYftMN2TBSezTpRaOHkTfONFu0YAbERJ7ZLp88isgOXUsLILhU akU/hY/BUskQaNIgCR/b0J2NPJ7+hW0cudpYEGjk2qyZOWEQ/sJF7yxRsk8d1jwscumq W7XN0oxcvAjX5C+TDBUchJ3yaDVxKIEHpHbCF7LcprIF+81cGxF2pdL6c7MdhEUdOnkA TQFXxfd36zukzAtIi36McQ2Kc69pLxmkGVoyBzPxhCGLXnzhONeR/N6W3aLcEdAfvKHz pYRaSDuruR9/ec3YVd6tg5j2UqtlqhBiPsq+309m/1PvCjSDLql832R8hTk17+nQoDwD zXCQ== X-Received: by 10.194.157.195 with SMTP id wo3mr16533144wjb.130.1406237856604; Thu, 24 Jul 2014 14:37:36 -0700 (PDT) Received: from ?IPv6:2a02:1205:34e1:3c90:3e77:e6ff:feb1:aba3? ([2a02:1205:34e1:3c90:3e77:e6ff:feb1:aba3]) by mx.google.com with ESMTPSA id u10sm19206408wjz.43.2014.07.24.14.37.34 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jul 2014 14:37:35 -0700 (PDT) Message-ID: <53CF67C1.6080001@gmail.com> Date: Wed, 23 Jul 2014 09:44:01 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] Clarify "Press any key to continue..." message References: <20140403142317.GT32733@riva.ucam.org> In-Reply-To: <20140403142317.GT32733@riva.ucam.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xVkbCCpaCLJi41JF4uSJp80HvW8GjwM8r" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c03::22e X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2014 21:37:40 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xVkbCCpaCLJi41JF4uSJp80HvW8GjwM8r Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Go ahead On 03.04.2014 16:23, Colin Watson wrote: > When grub_wait_after_message says "Press any key to continue...", it > really means that it will continue anyway after a short delay, but that= > you can press a key to skip the delay. Unfortunately, the delay is jus= t > long enough that in practice a number of users have time to see it, > press a key, and then report a bug saying that their system won't boot > without manual intervention, even though it would have booted just fine= > if they'd left it alone. Rephrase this message to make it clearer > what's really happening. >=20 > * grub-core/normal/menu.c (grub_wait_after_message): Rephrase > message to make it clear that GRUB will continue even if the user > does not press a key. > --- > ChangeLog | 6 ++++++ > grub-core/normal/menu.c | 4 +++- > 2 files changed, 9 insertions(+), 1 deletion(-) >=20 > diff --git a/ChangeLog b/ChangeLog > index 6eca73e..53c2aff 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,9 @@ > +2014-04-03 Colin Watson > + > + * grub-core/normal/menu.c (grub_wait_after_message): Rephrase > + message to make it clear that GRUB will continue even if the user > + does not press a key. > + > 2014-03-31 Thomas Falcon > =20 > btrfs: fix get_root key comparison failures due to endianness > diff --git a/grub-core/normal/menu.c b/grub-core/normal/menu.c > index b47991a..a6fa93c 100644 > --- a/grub-core/normal/menu.c > +++ b/grub-core/normal/menu.c > @@ -63,7 +63,9 @@ grub_wait_after_message (void) > { > grub_uint64_t endtime; > grub_xputs ("\n"); > - grub_printf_ (N_("Press any key to continue...")); > + grub_printf_ (N_( > + "Waiting a moment so that you can read previous messages.\n" > + "Press any key to skip this delay...")); > grub_refresh (); > =20 > endtime =3D grub_get_time_ms () + 10000; >=20 --xVkbCCpaCLJi41JF4uSJp80HvW8GjwM8r Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iF4EAREKAAYFAlPPZ8EACgkQmBXlbbo5nOvufAEAiRCmb2f2iHppcOxcRpCU3yKv 8T5wVM9a3K3L7SH9i7wA/05K/sGLh6xLbj8+e+DgB7eiTvjsSlbpZv049jNAYk6o =JEGB -----END PGP SIGNATURE----- --xVkbCCpaCLJi41JF4uSJp80HvW8GjwM8r--