From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XAnDN-0000Jx-LO for mharc-grub-devel@gnu.org; Fri, 25 Jul 2014 17:39:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAnDK-0000DK-18 for grub-devel@gnu.org; Fri, 25 Jul 2014 17:39:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XAnDI-0001wA-Ow for grub-devel@gnu.org; Fri, 25 Jul 2014 17:39:41 -0400 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:50298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XAnDI-0001w1-Hz for grub-devel@gnu.org; Fri, 25 Jul 2014 17:39:40 -0400 Received: by mail-wi0-f179.google.com with SMTP id f8so1650589wiw.0 for ; Fri, 25 Jul 2014 14:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=xpnwbQq8xqrfj4stVkkuNJcpa0732Z0eAvAItmAY3UQ=; b=1J6o9RQZZnvZI/rukh2WxxX9vGzM8SNYzF10judesyhqfo36kU+LR3vVAcV4Q68gpd ArS5bpmr17BNLPzu6rsh8pvgrqZoa1WxWu+zB/Kf7gP5tifqFcELfLA2Lapa+4qjr/7E 13Ss0yNLgPxHVWbUf+iXKC6mc/BAmWl/JOuGqNa5NCEBhbY9MblApmPltlUHsSKHBYsV pBWBK5+tfMULPcfPRQdmdLSSWKSUHfDrqWx3QgFCUAZBbnZCuHXSHIntzR7XMSRVSJUt 2v+TwUXvodWF1wldRcEOAhrPjQayFQ8ydWM3sk+pezElUwQC7a/Zlai78pRap1U4h/9C Fn5w== X-Received: by 10.180.14.162 with SMTP id q2mr8828916wic.29.1406324379690; Fri, 25 Jul 2014 14:39:39 -0700 (PDT) Received: from ?IPv6:2a02:1205:501d:7d90:3e77:e6ff:feb1:aba3? ([2a02:1205:501d:7d90:3e77:e6ff:feb1:aba3]) by mx.google.com with ESMTPSA id ed15sm10630958wic.9.2014.07.25.14.39.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 25 Jul 2014 14:39:38 -0700 (PDT) Message-ID: <53D2CE98.9070702@gmail.com> Date: Fri, 25 Jul 2014 23:39:36 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] Do not use inline in argp.h on FreeBSD References: <1406302104-30958-1-git-send-email-arvidjaar@gmail.com> In-Reply-To: <1406302104-30958-1-git-send-email-arvidjaar@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="X1aXd6COtxN8bXTc6N7DvTt74f2DUp2Ji" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::233 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2014 21:39:43 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --X1aXd6COtxN8bXTc6N7DvTt74f2DUp2Ji Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 25.07.2014 17:28, Andrey Borzenkov wrote: > This fixes this error: >=20 > In file included from util/grub-mkimage.c:54:0: > ./grub-core/gnulib/argp.h:627:49: error: '__sbistype' is static but > used in inline function '_option_is_short' which is not static > [-Werror] cc1: all warnings being treated as errors gmake[2]: *** > [util/grub_mkimage-grub-mkimage.o] Error 1 >=20 Did you contatc gnulib? Can we just silence this warning? > Treat FreeBSD similar to Apple and do not try inlines. It currently > does it for GCC only, as this is what had been tested. >=20 > Reported-By: Beeblebrox > Tested-By: Beeblebrox > Signed-off-by: Andrey Borzenkov >=20 > --- > m4/extern-inline.m4 | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) >=20 > diff --git a/m4/extern-inline.m4 b/m4/extern-inline.m4 > index 240150e..009b928 100644 > --- a/m4/extern-inline.m4 > +++ b/m4/extern-inline.m4 > @@ -24,7 +24,10 @@ AC_DEFUN([gl_EXTERN_INLINE], > . > OS X 10.9 has a macro __header_inline indicating the bug is fixed f= or C and > for clang but remains for g++; see . > - Perhaps Apple will fix this some day. */ > + Perhaps Apple will fix this some day. > + > + Suppress use of inlines on FreeBSD with GCC similar to Apple. It fa= ils to > + compile arpg.h due to static inlines in ctype.h */ > #if (defined __APPLE__ \ > && (defined __header_inline \ > ? (defined __cplusplus && defined __GNUC_STDC_INLINE__ \ > @@ -36,7 +39,8 @@ AC_DEFUN([gl_EXTERN_INLINE], > # define _GL_EXTERN_INLINE_APPLE_BUG > #endif > #if ((__GNUC__ \ > - ? defined __GNUC_STDC_INLINE__ && __GNUC_STDC_INLINE__ \ > + ? (defined __GNUC_STDC_INLINE__ && __GNUC_STDC_INLINE__) \ > + && !defined __FreeBSD__ \ > : (199901L <=3D __STDC_VERSION__ \ > && !defined __HP_cc \ > && !(defined __SUNPRO_C && __STDC__))) \ > @@ -45,7 +49,7 @@ AC_DEFUN([gl_EXTERN_INLINE], > # define _GL_EXTERN_INLINE extern inline > # define _GL_EXTERN_INLINE_IN_USE > #elif (2 < __GNUC__ + (7 <=3D __GNUC_MINOR__) && !defined __STRICT_ANS= I__ \ > - && !defined _GL_EXTERN_INLINE_APPLE_BUG) > + && !defined _GL_EXTERN_INLINE_APPLE_BUG && !defined __FreeBSD__= ) > # if defined __GNUC_GNU_INLINE__ && __GNUC_GNU_INLINE__ > /* __gnu_inline__ suppresses a GCC 4.2 diagnostic. */ > # define _GL_INLINE extern inline __attribute__ ((__gnu_inline__)) >=20 --X1aXd6COtxN8bXTc6N7DvTt74f2DUp2Ji Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iF4EAREKAAYFAlPSzpgACgkQmBXlbbo5nOv6aAD/UuDrpDXVlEigyZxp29OAp2H4 ci5+ZiHGGYBXWnPL2jwA+gKOG9QBTBTxhdOXEFk6OVrWjjN+Vy9wqC7BTmn0kdgO =HDiE -----END PGP SIGNATURE----- --X1aXd6COtxN8bXTc6N7DvTt74f2DUp2Ji--