* [RFC PATCH] configure check for ld's --no-relax flag
@ 2014-08-01 12:15 Stanislav Kholmanskikh
2014-08-01 15:35 ` Andrey Borzenkov
0 siblings, 1 reply; 8+ messages in thread
From: Stanislav Kholmanskikh @ 2014-08-01 12:15 UTC (permalink / raw)
To: grub-devel; +Cc: vasily.isaenko
Early versions of binutils doesn't support --no-relax flag, so
commit 063f2a04d158ec1b275a925dfbae74b124708cde prevents building
with such versions.
Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
---
conf/Makefile.common | 8 ++++++++
configure.ac | 10 ++++++++++
2 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/conf/Makefile.common b/conf/Makefile.common
index e4c301f..5bda66f 100644
--- a/conf/Makefile.common
+++ b/conf/Makefile.common
@@ -8,11 +8,19 @@ unexport LC_ALL
# Platform specific options
if COND_sparc64_ieee1275
CFLAGS_PLATFORM += -mno-app-regs
+if COND_LD_SUPPORTS_NO_RELAX
LDFLAGS_PLATFORM = -Wl,-melf64_sparc -Wl,--no-relax
+else
+ LDFLAGS_PLATFORM = -Wl,-melf64_sparc -mno-relax
+endif
endif
if COND_sparc64_emu
CFLAGS_PLATFORM += -mno-app-regs
+if COND_LD_SUPPORTS_NO_RELAX
LDFLAGS_PLATFORM = -Wl,--no-relax
+else
+ LDFLAGS_PLATFORM = -mno-relax
+endif
endif
if COND_arm
if !COND_emu
diff --git a/configure.ac b/configure.ac
index 8888c2f..282fded 100644
--- a/configure.ac
+++ b/configure.ac
@@ -516,6 +516,14 @@ fi
TARGET_CC_VERSION="$(LC_ALL=C $TARGET_CC --version | head -n1)"
+AC_CACHE_CHECK([if the target C compiler supports -Wl,--no-relax], [grub_cv_target_cc_wl_no_relax_flag], [
+ LDFLAGS="$TARGET_LDFLAGS -nostdlib -static"
+
+ AC_LINK_IFELSE([AC_LANG_PROGRAM([[
+int main(void) { return 0; }
+]])], [grub_cv_target_cc_wl_no_relax_flag=yes], [grub_cv_target_cc_wl_no_relax_flag=no])
+])
+
AC_CACHE_CHECK([which extra warnings work], [grub_cv_target_cc_w_extra_flags], [
LDFLAGS="$TARGET_LDFLAGS -nostdlib -static"
@@ -1708,6 +1716,8 @@ AM_CONDITIONAL([COND_ENABLE_BOOT_TIME_STATS], [test x$BOOT_TIME_STATS = x1])
AM_CONDITIONAL([COND_HAVE_CXX], [test x$HAVE_CXX = xyes])
+AM_CONDITIONAL([COND_LD_SUPPORTS_NO_RELAX], [test x$grub_cv_target_cc_wl_no_relax_flag = xyes])
+
AM_CONDITIONAL([COND_HAVE_ASM_USCORE], [test x$HAVE_ASM_USCORE = x1])
AM_CONDITIONAL([COND_STARFIELD], [test "x$starfield_excuse" = x])
AM_CONDITIONAL([COND_HAVE_EXEC], [test "x$have_exec" = xy])
--
1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [RFC PATCH] configure check for ld's --no-relax flag
2014-08-01 12:15 [RFC PATCH] configure check for ld's --no-relax flag Stanislav Kholmanskikh
@ 2014-08-01 15:35 ` Andrey Borzenkov
2014-08-01 15:40 ` Vladimir 'φ-coder/phcoder' Serbinenko
0 siblings, 1 reply; 8+ messages in thread
From: Andrey Borzenkov @ 2014-08-01 15:35 UTC (permalink / raw)
To: The development of GNU GRUB; +Cc: vasily.isaenko, stanislav.kholmanskikh
В Fri, 1 Aug 2014 16:15:56 +0400
Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com> пишет:
> Early versions of binutils doesn't support --no-relax flag, so
> commit 063f2a04d158ec1b275a925dfbae74b124708cde prevents building
> with such versions.
>
> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
> ---
> conf/Makefile.common | 8 ++++++++
> configure.ac | 10 ++++++++++
> 2 files changed, 18 insertions(+), 0 deletions(-)
>
> diff --git a/conf/Makefile.common b/conf/Makefile.common
> index e4c301f..5bda66f 100644
> --- a/conf/Makefile.common
> +++ b/conf/Makefile.common
> @@ -8,11 +8,19 @@ unexport LC_ALL
> # Platform specific options
> if COND_sparc64_ieee1275
> CFLAGS_PLATFORM += -mno-app-regs
> +if COND_LD_SUPPORTS_NO_RELAX
> LDFLAGS_PLATFORM = -Wl,-melf64_sparc -Wl,--no-relax
> +else
> + LDFLAGS_PLATFORM = -Wl,-melf64_sparc -mno-relax
> +endif
TBO I think commit should simply be reverted. "Uniformity" is rather
poor excuse for breaking existing systems.
> endif
> if COND_sparc64_emu
> CFLAGS_PLATFORM += -mno-app-regs
> +if COND_LD_SUPPORTS_NO_RELAX
> LDFLAGS_PLATFORM = -Wl,--no-relax
> +else
> + LDFLAGS_PLATFORM = -mno-relax
> +endif
> endif
> if COND_arm
> if !COND_emu
> diff --git a/configure.ac b/configure.ac
> index 8888c2f..282fded 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -516,6 +516,14 @@ fi
>
> TARGET_CC_VERSION="$(LC_ALL=C $TARGET_CC --version | head -n1)"
>
> +AC_CACHE_CHECK([if the target C compiler supports -Wl,--no-relax], [grub_cv_target_cc_wl_no_relax_flag], [
> + LDFLAGS="$TARGET_LDFLAGS -nostdlib -static"
> +
> + AC_LINK_IFELSE([AC_LANG_PROGRAM([[
> +int main(void) { return 0; }
> +]])], [grub_cv_target_cc_wl_no_relax_flag=yes], [grub_cv_target_cc_wl_no_relax_flag=no])
> +])
> +
> AC_CACHE_CHECK([which extra warnings work], [grub_cv_target_cc_w_extra_flags], [
> LDFLAGS="$TARGET_LDFLAGS -nostdlib -static"
>
> @@ -1708,6 +1716,8 @@ AM_CONDITIONAL([COND_ENABLE_BOOT_TIME_STATS], [test x$BOOT_TIME_STATS = x1])
>
> AM_CONDITIONAL([COND_HAVE_CXX], [test x$HAVE_CXX = xyes])
>
> +AM_CONDITIONAL([COND_LD_SUPPORTS_NO_RELAX], [test x$grub_cv_target_cc_wl_no_relax_flag = xyes])
> +
> AM_CONDITIONAL([COND_HAVE_ASM_USCORE], [test x$HAVE_ASM_USCORE = x1])
> AM_CONDITIONAL([COND_STARFIELD], [test "x$starfield_excuse" = x])
> AM_CONDITIONAL([COND_HAVE_EXEC], [test "x$have_exec" = xy])
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC PATCH] configure check for ld's --no-relax flag
2014-08-01 15:35 ` Andrey Borzenkov
@ 2014-08-01 15:40 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-08-04 6:45 ` Stanislav Kholmanskikh
0 siblings, 1 reply; 8+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2014-08-01 15:40 UTC (permalink / raw)
To: The development of GNU GRUB
[-- Attachment #1: Type: text/plain, Size: 2953 bytes --]
On 01.08.2014 17:35, Andrey Borzenkov wrote:
> В Fri, 1 Aug 2014 16:15:56 +0400
> Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com> пишет:
>
>> Early versions of binutils doesn't support --no-relax flag, so
>> commit 063f2a04d158ec1b275a925dfbae74b124708cde prevents building
>> with such versions.
>>
>> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
>> ---
>> conf/Makefile.common | 8 ++++++++
>> configure.ac | 10 ++++++++++
>> 2 files changed, 18 insertions(+), 0 deletions(-)
>>
>> diff --git a/conf/Makefile.common b/conf/Makefile.common
>> index e4c301f..5bda66f 100644
>> --- a/conf/Makefile.common
>> +++ b/conf/Makefile.common
>> @@ -8,11 +8,19 @@ unexport LC_ALL
>> # Platform specific options
>> if COND_sparc64_ieee1275
>> CFLAGS_PLATFORM += -mno-app-regs
>> +if COND_LD_SUPPORTS_NO_RELAX
>> LDFLAGS_PLATFORM = -Wl,-melf64_sparc -Wl,--no-relax
>> +else
>> + LDFLAGS_PLATFORM = -Wl,-melf64_sparc -mno-relax
>> +endif
>
> TBO I think commit should simply be reverted. "Uniformity" is rather
> poor excuse for breaking existing systems.
>
This commit is needed for clang to compile for sparc64. Given that
sparc64 clang still doesn't really work I'm ok with reverting, at least
for now.
>> endif
>> if COND_sparc64_emu
>> CFLAGS_PLATFORM += -mno-app-regs
>> +if COND_LD_SUPPORTS_NO_RELAX
>> LDFLAGS_PLATFORM = -Wl,--no-relax
>> +else
>> + LDFLAGS_PLATFORM = -mno-relax
>> +endif
>> endif
>> if COND_arm
>> if !COND_emu
>> diff --git a/configure.ac b/configure.ac
>> index 8888c2f..282fded 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -516,6 +516,14 @@ fi
>>
>> TARGET_CC_VERSION="$(LC_ALL=C $TARGET_CC --version | head -n1)"
>>
>> +AC_CACHE_CHECK([if the target C compiler supports -Wl,--no-relax], [grub_cv_target_cc_wl_no_relax_flag], [
>> + LDFLAGS="$TARGET_LDFLAGS -nostdlib -static"
>> +
>> + AC_LINK_IFELSE([AC_LANG_PROGRAM([[
>> +int main(void) { return 0; }
>> +]])], [grub_cv_target_cc_wl_no_relax_flag=yes], [grub_cv_target_cc_wl_no_relax_flag=no])
>> +])
>> +
>> AC_CACHE_CHECK([which extra warnings work], [grub_cv_target_cc_w_extra_flags], [
>> LDFLAGS="$TARGET_LDFLAGS -nostdlib -static"
>>
>> @@ -1708,6 +1716,8 @@ AM_CONDITIONAL([COND_ENABLE_BOOT_TIME_STATS], [test x$BOOT_TIME_STATS = x1])
>>
>> AM_CONDITIONAL([COND_HAVE_CXX], [test x$HAVE_CXX = xyes])
>>
>> +AM_CONDITIONAL([COND_LD_SUPPORTS_NO_RELAX], [test x$grub_cv_target_cc_wl_no_relax_flag = xyes])
>> +
>> AM_CONDITIONAL([COND_HAVE_ASM_USCORE], [test x$HAVE_ASM_USCORE = x1])
>> AM_CONDITIONAL([COND_STARFIELD], [test "x$starfield_excuse" = x])
>> AM_CONDITIONAL([COND_HAVE_EXEC], [test "x$have_exec" = xy])
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC PATCH] configure check for ld's --no-relax flag
2014-08-01 15:40 ` Vladimir 'φ-coder/phcoder' Serbinenko
@ 2014-08-04 6:45 ` Stanislav Kholmanskikh
2014-08-04 14:53 ` Andrey Borzenkov
0 siblings, 1 reply; 8+ messages in thread
From: Stanislav Kholmanskikh @ 2014-08-04 6:45 UTC (permalink / raw)
To: The development of GNU GRUB
Hi!
On 08/01/2014 07:40 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> On 01.08.2014 17:35, Andrey Borzenkov wrote:
>> В Fri, 1 Aug 2014 16:15:56 +0400
>> Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com> пишет:
>>
>>> Early versions of binutils doesn't support --no-relax flag, so
>>> commit 063f2a04d158ec1b275a925dfbae74b124708cde prevents building
>>> with such versions.
>>>
>>> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
>>> ---
>>> conf/Makefile.common | 8 ++++++++
>>> configure.ac | 10 ++++++++++
>>> 2 files changed, 18 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/conf/Makefile.common b/conf/Makefile.common
>>> index e4c301f..5bda66f 100644
>>> --- a/conf/Makefile.common
>>> +++ b/conf/Makefile.common
>>> @@ -8,11 +8,19 @@ unexport LC_ALL
>>> # Platform specific options
>>> if COND_sparc64_ieee1275
>>> CFLAGS_PLATFORM += -mno-app-regs
>>> +if COND_LD_SUPPORTS_NO_RELAX
>>> LDFLAGS_PLATFORM = -Wl,-melf64_sparc -Wl,--no-relax
>>> +else
>>> + LDFLAGS_PLATFORM = -Wl,-melf64_sparc -mno-relax
>>> +endif
>>
>> TBO I think commit should simply be reverted. "Uniformity" is rather
>> poor excuse for breaking existing systems.
>>
> This commit is needed for clang to compile for sparc64. Given that
> sparc64 clang still doesn't really work I'm ok with reverting, at least
> for now.
But, it this case, maybe it would be better to consider
reviewing/applying this patch? Just to not return to this issue after
some time?
Andrey, Vladimir, what do you think?
Thanks.
>>> endif
>>> if COND_sparc64_emu
>>> CFLAGS_PLATFORM += -mno-app-regs
>>> +if COND_LD_SUPPORTS_NO_RELAX
>>> LDFLAGS_PLATFORM = -Wl,--no-relax
>>> +else
>>> + LDFLAGS_PLATFORM = -mno-relax
>>> +endif
>>> endif
>>> if COND_arm
>>> if !COND_emu
>>> diff --git a/configure.ac b/configure.ac
>>> index 8888c2f..282fded 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -516,6 +516,14 @@ fi
>>>
>>> TARGET_CC_VERSION="$(LC_ALL=C $TARGET_CC --version | head -n1)"
>>>
>>> +AC_CACHE_CHECK([if the target C compiler supports -Wl,--no-relax], [grub_cv_target_cc_wl_no_relax_flag], [
>>> + LDFLAGS="$TARGET_LDFLAGS -nostdlib -static"
>>> +
>>> + AC_LINK_IFELSE([AC_LANG_PROGRAM([[
>>> +int main(void) { return 0; }
>>> +]])], [grub_cv_target_cc_wl_no_relax_flag=yes], [grub_cv_target_cc_wl_no_relax_flag=no])
>>> +])
>>> +
>>> AC_CACHE_CHECK([which extra warnings work], [grub_cv_target_cc_w_extra_flags], [
>>> LDFLAGS="$TARGET_LDFLAGS -nostdlib -static"
>>>
>>> @@ -1708,6 +1716,8 @@ AM_CONDITIONAL([COND_ENABLE_BOOT_TIME_STATS], [test x$BOOT_TIME_STATS = x1])
>>>
>>> AM_CONDITIONAL([COND_HAVE_CXX], [test x$HAVE_CXX = xyes])
>>>
>>> +AM_CONDITIONAL([COND_LD_SUPPORTS_NO_RELAX], [test x$grub_cv_target_cc_wl_no_relax_flag = xyes])
>>> +
>>> AM_CONDITIONAL([COND_HAVE_ASM_USCORE], [test x$HAVE_ASM_USCORE = x1])
>>> AM_CONDITIONAL([COND_STARFIELD], [test "x$starfield_excuse" = x])
>>> AM_CONDITIONAL([COND_HAVE_EXEC], [test "x$have_exec" = xy])
>>
>>
>> _______________________________________________
>> Grub-devel mailing list
>> Grub-devel@gnu.org
>> https://lists.gnu.org/mailman/listinfo/grub-devel
>>
>
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC PATCH] configure check for ld's --no-relax flag
2014-08-04 6:45 ` Stanislav Kholmanskikh
@ 2014-08-04 14:53 ` Andrey Borzenkov
2014-09-21 17:03 ` Vladimir 'φ-coder/phcoder' Serbinenko
0 siblings, 1 reply; 8+ messages in thread
From: Andrey Borzenkov @ 2014-08-04 14:53 UTC (permalink / raw)
To: The development of GNU GRUB; +Cc: stanislav.kholmanskikh
В Mon, 04 Aug 2014 10:45:22 +0400
Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com> пишет:
> Hi!
>
> On 08/01/2014 07:40 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> > On 01.08.2014 17:35, Andrey Borzenkov wrote:
> >> В Fri, 1 Aug 2014 16:15:56 +0400
> >> Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com> пишет:
> >>
> >>> Early versions of binutils doesn't support --no-relax flag, so
> >>> commit 063f2a04d158ec1b275a925dfbae74b124708cde prevents building
> >>> with such versions.
> >>>
> >>> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
> >>> ---
> >>> conf/Makefile.common | 8 ++++++++
> >>> configure.ac | 10 ++++++++++
> >>> 2 files changed, 18 insertions(+), 0 deletions(-)
> >>>
> >>> diff --git a/conf/Makefile.common b/conf/Makefile.common
> >>> index e4c301f..5bda66f 100644
> >>> --- a/conf/Makefile.common
> >>> +++ b/conf/Makefile.common
> >>> @@ -8,11 +8,19 @@ unexport LC_ALL
> >>> # Platform specific options
> >>> if COND_sparc64_ieee1275
> >>> CFLAGS_PLATFORM += -mno-app-regs
> >>> +if COND_LD_SUPPORTS_NO_RELAX
> >>> LDFLAGS_PLATFORM = -Wl,-melf64_sparc -Wl,--no-relax
> >>> +else
> >>> + LDFLAGS_PLATFORM = -Wl,-melf64_sparc -mno-relax
> >>> +endif
> >>
> >> TBO I think commit should simply be reverted. "Uniformity" is rather
> >> poor excuse for breaking existing systems.
> >>
> > This commit is needed for clang to compile for sparc64. Given that
> > sparc64 clang still doesn't really work I'm ok with reverting, at least
> > for now.
>
> But, it this case, maybe it would be better to consider
> reviewing/applying this patch? Just to not return to this issue after
> some time?
>
> Andrey, Vladimir, what do you think?
>
Yes, commit message was pretty confusing. This leaves the question,
whether combination of clang and binutils that do not support
-Wl,--no-relax exists though :) Otherwise I agree, we should use this
patch.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC PATCH] configure check for ld's --no-relax flag
2014-08-04 14:53 ` Andrey Borzenkov
@ 2014-09-21 17:03 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-09-21 17:50 ` Andrei Borzenkov
0 siblings, 1 reply; 8+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2014-09-21 17:03 UTC (permalink / raw)
To: The development of GNU GRUB
[-- Attachment #1: Type: text/plain, Size: 2482 bytes --]
On 04.08.2014 16:53, Andrey Borzenkov wrote:
> В Mon, 04 Aug 2014 10:45:22 +0400
> Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com> пишет:
>
>> Hi!
>>
>> On 08/01/2014 07:40 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>>> On 01.08.2014 17:35, Andrey Borzenkov wrote:
>>>> В Fri, 1 Aug 2014 16:15:56 +0400
>>>> Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com> пишет:
>>>>
>>>>> Early versions of binutils doesn't support --no-relax flag, so
>>>>> commit 063f2a04d158ec1b275a925dfbae74b124708cde prevents building
>>>>> with such versions.
>>>>>
>>>>> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
>>>>> ---
>>>>> conf/Makefile.common | 8 ++++++++
>>>>> configure.ac | 10 ++++++++++
>>>>> 2 files changed, 18 insertions(+), 0 deletions(-)
>>>>>
>>>>> diff --git a/conf/Makefile.common b/conf/Makefile.common
>>>>> index e4c301f..5bda66f 100644
>>>>> --- a/conf/Makefile.common
>>>>> +++ b/conf/Makefile.common
>>>>> @@ -8,11 +8,19 @@ unexport LC_ALL
>>>>> # Platform specific options
>>>>> if COND_sparc64_ieee1275
>>>>> CFLAGS_PLATFORM += -mno-app-regs
>>>>> +if COND_LD_SUPPORTS_NO_RELAX
>>>>> LDFLAGS_PLATFORM = -Wl,-melf64_sparc -Wl,--no-relax
>>>>> +else
>>>>> + LDFLAGS_PLATFORM = -Wl,-melf64_sparc -mno-relax
>>>>> +endif
>>>>
>>>> TBO I think commit should simply be reverted. "Uniformity" is rather
>>>> poor excuse for breaking existing systems.
>>>>
>>> This commit is needed for clang to compile for sparc64. Given that
>>> sparc64 clang still doesn't really work I'm ok with reverting, at least
>>> for now.
>>
>> But, it this case, maybe it would be better to consider
>> reviewing/applying this patch? Just to not return to this issue after
>> some time?
>>
>> Andrey, Vladimir, what do you think?
>>
>
> Yes, commit message was pretty confusing. This leaves the question,
> whether combination of clang and binutils that do not support
> -Wl,--no-relax exists though :) Otherwise I agree, we should use this
> patch.
>
I think we could try to push for clang to have -mno-relax. They're
usually pretty responsive and we'll probably need few fixes for few
other clang problems anyway. For now I just reverted it. We'll see how
clang sparc64 goes.
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC PATCH] configure check for ld's --no-relax flag
2014-09-21 17:03 ` Vladimir 'φ-coder/phcoder' Serbinenko
@ 2014-09-21 17:50 ` Andrei Borzenkov
2014-09-21 18:14 ` Vladimir 'φ-coder/phcoder' Serbinenko
0 siblings, 1 reply; 8+ messages in thread
From: Andrei Borzenkov @ 2014-09-21 17:50 UTC (permalink / raw)
To: The development of GNU GRUB
[-- Attachment #1: Type: text/plain, Size: 2530 bytes --]
В Sun, 21 Sep 2014 19:03:08 +0200
Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
> On 04.08.2014 16:53, Andrey Borzenkov wrote:
> > В Mon, 04 Aug 2014 10:45:22 +0400
> > Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com> пишет:
> >
> >> Hi!
> >>
> >> On 08/01/2014 07:40 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> >>> On 01.08.2014 17:35, Andrey Borzenkov wrote:
> >>>> В Fri, 1 Aug 2014 16:15:56 +0400
> >>>> Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com> пишет:
> >>>>
> >>>>> Early versions of binutils doesn't support --no-relax flag, so
> >>>>> commit 063f2a04d158ec1b275a925dfbae74b124708cde prevents building
> >>>>> with such versions.
> >>>>>
> >>>>> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
> >>>>> ---
> >>>>> conf/Makefile.common | 8 ++++++++
> >>>>> configure.ac | 10 ++++++++++
> >>>>> 2 files changed, 18 insertions(+), 0 deletions(-)
> >>>>>
> >>>>> diff --git a/conf/Makefile.common b/conf/Makefile.common
> >>>>> index e4c301f..5bda66f 100644
> >>>>> --- a/conf/Makefile.common
> >>>>> +++ b/conf/Makefile.common
> >>>>> @@ -8,11 +8,19 @@ unexport LC_ALL
> >>>>> # Platform specific options
> >>>>> if COND_sparc64_ieee1275
> >>>>> CFLAGS_PLATFORM += -mno-app-regs
> >>>>> +if COND_LD_SUPPORTS_NO_RELAX
> >>>>> LDFLAGS_PLATFORM = -Wl,-melf64_sparc -Wl,--no-relax
> >>>>> +else
> >>>>> + LDFLAGS_PLATFORM = -Wl,-melf64_sparc -mno-relax
> >>>>> +endif
> >>>>
> >>>> TBO I think commit should simply be reverted. "Uniformity" is rather
> >>>> poor excuse for breaking existing systems.
> >>>>
> >>> This commit is needed for clang to compile for sparc64. Given that
> >>> sparc64 clang still doesn't really work I'm ok with reverting, at least
> >>> for now.
> >>
> >> But, it this case, maybe it would be better to consider
> >> reviewing/applying this patch? Just to not return to this issue after
> >> some time?
> >>
> >> Andrey, Vladimir, what do you think?
> >>
> >
> > Yes, commit message was pretty confusing. This leaves the question,
> > whether combination of clang and binutils that do not support
> > -Wl,--no-relax exists though :) Otherwise I agree, we should use this
> > patch.
> >
> I think we could try to push for clang to have -mno-relax. They're
> usually pretty responsive and we'll probably need few fixes for few
> other clang problems anyway. For now I just reverted it.
Did you push it?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC PATCH] configure check for ld's --no-relax flag
2014-09-21 17:50 ` Andrei Borzenkov
@ 2014-09-21 18:14 ` Vladimir 'φ-coder/phcoder' Serbinenko
0 siblings, 0 replies; 8+ messages in thread
From: Vladimir 'φ-coder/phcoder' Serbinenko @ 2014-09-21 18:14 UTC (permalink / raw)
To: The development of GNU GRUB
[-- Attachment #1: Type: text/plain, Size: 2890 bytes --]
On 21.09.2014 19:50, Andrei Borzenkov wrote:
> В Sun, 21 Sep 2014 19:03:08 +0200
> Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
>
>> On 04.08.2014 16:53, Andrey Borzenkov wrote:
>>> В Mon, 04 Aug 2014 10:45:22 +0400
>>> Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com> пишет:
>>>
>>>> Hi!
>>>>
>>>> On 08/01/2014 07:40 PM, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
>>>>> On 01.08.2014 17:35, Andrey Borzenkov wrote:
>>>>>> В Fri, 1 Aug 2014 16:15:56 +0400
>>>>>> Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com> пишет:
>>>>>>
>>>>>>> Early versions of binutils doesn't support --no-relax flag, so
>>>>>>> commit 063f2a04d158ec1b275a925dfbae74b124708cde prevents building
>>>>>>> with such versions.
>>>>>>>
>>>>>>> Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
>>>>>>> ---
>>>>>>> conf/Makefile.common | 8 ++++++++
>>>>>>> configure.ac | 10 ++++++++++
>>>>>>> 2 files changed, 18 insertions(+), 0 deletions(-)
>>>>>>>
>>>>>>> diff --git a/conf/Makefile.common b/conf/Makefile.common
>>>>>>> index e4c301f..5bda66f 100644
>>>>>>> --- a/conf/Makefile.common
>>>>>>> +++ b/conf/Makefile.common
>>>>>>> @@ -8,11 +8,19 @@ unexport LC_ALL
>>>>>>> # Platform specific options
>>>>>>> if COND_sparc64_ieee1275
>>>>>>> CFLAGS_PLATFORM += -mno-app-regs
>>>>>>> +if COND_LD_SUPPORTS_NO_RELAX
>>>>>>> LDFLAGS_PLATFORM = -Wl,-melf64_sparc -Wl,--no-relax
>>>>>>> +else
>>>>>>> + LDFLAGS_PLATFORM = -Wl,-melf64_sparc -mno-relax
>>>>>>> +endif
>>>>>>
>>>>>> TBO I think commit should simply be reverted. "Uniformity" is rather
>>>>>> poor excuse for breaking existing systems.
>>>>>>
>>>>> This commit is needed for clang to compile for sparc64. Given that
>>>>> sparc64 clang still doesn't really work I'm ok with reverting, at least
>>>>> for now.
>>>>
>>>> But, it this case, maybe it would be better to consider
>>>> reviewing/applying this patch? Just to not return to this issue after
>>>> some time?
>>>>
>>>> Andrey, Vladimir, what do you think?
>>>>
>>>
>>> Yes, commit message was pretty confusing. This leaves the question,
>>> whether combination of clang and binutils that do not support
>>> -Wl,--no-relax exists though :) Otherwise I agree, we should use this
>>> patch.
>>>
>> I think we could try to push for clang to have -mno-relax. They're
>> usually pretty responsive and we'll probably need few fixes for few
>> other clang problems anyway. For now I just reverted it.
>
> Did you push it?
>
Now yes. I was offline when I wrote this. My mail automatically sent
this when I got online but git needed manual intervention.
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-09-21 18:14 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-01 12:15 [RFC PATCH] configure check for ld's --no-relax flag Stanislav Kholmanskikh
2014-08-01 15:35 ` Andrey Borzenkov
2014-08-01 15:40 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-08-04 6:45 ` Stanislav Kholmanskikh
2014-08-04 14:53 ` Andrey Borzenkov
2014-09-21 17:03 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-09-21 17:50 ` Andrei Borzenkov
2014-09-21 18:14 ` Vladimir 'φ-coder/phcoder' Serbinenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).