From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XDEwX-00009N-Te for mharc-grub-devel@gnu.org; Fri, 01 Aug 2014 11:40:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDEwR-0008Qm-Ju for grub-devel@gnu.org; Fri, 01 Aug 2014 11:40:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XDEwM-0000jO-Bb for grub-devel@gnu.org; Fri, 01 Aug 2014 11:40:23 -0400 Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:38603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XDEwM-0000j8-0h for grub-devel@gnu.org; Fri, 01 Aug 2014 11:40:18 -0400 Received: by mail-wg0-f45.google.com with SMTP id x12so4481444wgg.28 for ; Fri, 01 Aug 2014 08:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=iAb+1AdlMC6TE1ln1zhqE41YXLxh3MzeLATl8EZsrzQ=; b=FE8B0ol0LA8po0wpbpGpblLqpv4czt9ziQYyUnPlL7xkL7KJKqoWKegEW3pA3AzBz1 WameUwgMv4NJEb5+4nXlcSCKVP7OrDxnDBgBy74CMlkk2J0jXVQxLXHx2iIvyolcyctx RYWjpCsAvxlJ7cmJ+eW8eo0tNwIM/XC23O53lLLIcuiN+H0bcSVA4QAUrTYdf9p7rS/N QkfUdrEfzMYyhg0keV8iWZky2XQ44APOQE1uHDgK1tXExrXCvTXQ4a3rEvcQPvmeIp1q +Wlop5sm7oBnKcCXvoB99exQ+be081DBBSltIcZjJ5ukKttCM+cswNSG5dpprV7dxcG3 7YMQ== X-Received: by 10.180.221.133 with SMTP id qe5mr7883823wic.17.1406907616483; Fri, 01 Aug 2014 08:40:16 -0700 (PDT) Received: from [192.168.42.61] (167-224.197-178.cust.bluewin.ch. [178.197.224.167]) by mx.google.com with ESMTPSA id n2sm21689201wjf.40.2014.08.01.08.40.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Aug 2014 08:40:15 -0700 (PDT) Message-ID: <53DBB4D4.3090508@gmail.com> Date: Fri, 01 Aug 2014 17:40:04 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [RFC PATCH] configure check for ld's --no-relax flag References: <1406895356-28090-1-git-send-email-stanislav.kholmanskikh@oracle.com> <20140801193559.61fe4363@opensuse.site> In-Reply-To: <20140801193559.61fe4363@opensuse.site> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="g6RPpsDTlmOdsQ8F3W1f63uwmPh6FOUvA" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::22d X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Aug 2014 15:40:28 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --g6RPpsDTlmOdsQ8F3W1f63uwmPh6FOUvA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01.08.2014 17:35, Andrey Borzenkov wrote: > =D0=92 Fri, 1 Aug 2014 16:15:56 +0400 > Stanislav Kholmanskikh =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: >=20 >> Early versions of binutils doesn't support --no-relax flag, so >> commit 063f2a04d158ec1b275a925dfbae74b124708cde prevents building >> with such versions. >> >> Signed-off-by: Stanislav Kholmanskikh >> --- >> conf/Makefile.common | 8 ++++++++ >> configure.ac | 10 ++++++++++ >> 2 files changed, 18 insertions(+), 0 deletions(-) >> >> diff --git a/conf/Makefile.common b/conf/Makefile.common >> index e4c301f..5bda66f 100644 >> --- a/conf/Makefile.common >> +++ b/conf/Makefile.common >> @@ -8,11 +8,19 @@ unexport LC_ALL >> # Platform specific options >> if COND_sparc64_ieee1275 >> CFLAGS_PLATFORM +=3D -mno-app-regs >> +if COND_LD_SUPPORTS_NO_RELAX >> LDFLAGS_PLATFORM =3D -Wl,-melf64_sparc -Wl,--no-relax >> +else >> + LDFLAGS_PLATFORM =3D -Wl,-melf64_sparc -mno-relax >> +endif >=20 > TBO I think commit should simply be reverted. "Uniformity" is rather > poor excuse for breaking existing systems.=20 >=20 This commit is needed for clang to compile for sparc64. Given that sparc64 clang still doesn't really work I'm ok with reverting, at least for now. >> endif >> if COND_sparc64_emu >> CFLAGS_PLATFORM +=3D -mno-app-regs >> +if COND_LD_SUPPORTS_NO_RELAX >> LDFLAGS_PLATFORM =3D -Wl,--no-relax >> +else >> + LDFLAGS_PLATFORM =3D -mno-relax >> +endif >> endif >> if COND_arm >> if !COND_emu >> diff --git a/configure.ac b/configure.ac >> index 8888c2f..282fded 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -516,6 +516,14 @@ fi >> =20 >> TARGET_CC_VERSION=3D"$(LC_ALL=3DC $TARGET_CC --version | head -n1)" >> =20 >> +AC_CACHE_CHECK([if the target C compiler supports -Wl,--no-relax], [g= rub_cv_target_cc_wl_no_relax_flag], [ >> + LDFLAGS=3D"$TARGET_LDFLAGS -nostdlib -static" >> + >> + AC_LINK_IFELSE([AC_LANG_PROGRAM([[ >> +int main(void) { return 0; } >> +]])], [grub_cv_target_cc_wl_no_relax_flag=3Dyes], [grub_cv_target_cc_= wl_no_relax_flag=3Dno]) >> +]) >> + >> AC_CACHE_CHECK([which extra warnings work], [grub_cv_target_cc_w_extr= a_flags], [ >> LDFLAGS=3D"$TARGET_LDFLAGS -nostdlib -static" >> =20 >> @@ -1708,6 +1716,8 @@ AM_CONDITIONAL([COND_ENABLE_BOOT_TIME_STATS], [t= est x$BOOT_TIME_STATS =3D x1]) >> =20 >> AM_CONDITIONAL([COND_HAVE_CXX], [test x$HAVE_CXX =3D xyes]) >> =20 >> +AM_CONDITIONAL([COND_LD_SUPPORTS_NO_RELAX], [test x$grub_cv_target_cc= _wl_no_relax_flag =3D xyes]) >> + >> AM_CONDITIONAL([COND_HAVE_ASM_USCORE], [test x$HAVE_ASM_USCORE =3D x1= ]) >> AM_CONDITIONAL([COND_STARFIELD], [test "x$starfield_excuse" =3D x]) >> AM_CONDITIONAL([COND_HAVE_EXEC], [test "x$have_exec" =3D xy]) >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --g6RPpsDTlmOdsQ8F3W1f63uwmPh6FOUvA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iF4EAREKAAYFAlPbtNkACgkQmBXlbbo5nOvgZAD9HSvterm++n89PQdl/fceV0+/ gUQtXjRSaOPVCYWTGIkA/1qFWUnba/Cp7pjqghDgL3mOHSjGSu2ZOyHDBN8UdkAG =E3wD -----END PGP SIGNATURE----- --g6RPpsDTlmOdsQ8F3W1f63uwmPh6FOUvA--