From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XVjOz-0001sG-O7 for mharc-grub-devel@gnu.org; Sun, 21 Sep 2014 11:50:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVjOo-0001df-EC for grub-devel@gnu.org; Sun, 21 Sep 2014 11:50:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XVjOT-00020W-Va for grub-devel@gnu.org; Sun, 21 Sep 2014 11:50:06 -0400 Received: from mail-wg0-x22c.google.com ([2a00:1450:400c:c00::22c]:46921) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVjOT-0001zf-Oa for grub-devel@gnu.org; Sun, 21 Sep 2014 11:49:45 -0400 Received: by mail-wg0-f44.google.com with SMTP id z12so1606534wgg.3 for ; Sun, 21 Sep 2014 08:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=6Qv1Br6HF2hlKXeoQwwc4VuTU71eoXA8F6EP46yf2lU=; b=kZIw8+mS2+8+WhDb83WINtH8n45WJuj+TIjvMPiLaA28Jw3rhc+MXWBss9DsCUClhu xpDYYB1Rp26kod8cIiOxnEUUotElJXm2iIOMmQ9oeC7sb3sO5+6ubvH72mF7hwrH7ZbE ZcEV8CCk8boIqHLTstggv1x2ldMdDo+S50jbkHXNJ6JZ2Sj2z+KdiVkPL2R7VgZ6Hb9B KXRS0CK1SOTOs5nur67zICsYhpaiyLaQwKHi6Z8a7njjBg6rSRaTI8GAS5jtYeOIJlAT xUhCEx3dBHOSlsdxR3+JMTTjcine4WgX7/iOQatME5sW6+DIpSIHXUYuSbR5ZrFAm9YW p61Q== X-Received: by 10.194.95.234 with SMTP id dn10mr14846056wjb.73.1411314579752; Sun, 21 Sep 2014 08:49:39 -0700 (PDT) Received: from [192.168.42.4] (160-228.197-178.cust.bluewin.ch. [178.197.228.160]) by mx.google.com with ESMTPSA id u7sm9066422wif.7.2014.09.21.08.49.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Sep 2014 08:49:38 -0700 (PDT) Message-ID: <541EF38F.4050305@gmail.com> Date: Sun, 21 Sep 2014 17:49:35 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] Fix extraous comma in printf References: <1410431234-26472-1-git-send-email-mchang@suse.com> In-Reply-To: <1410431234-26472-1-git-send-email-mchang@suse.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Q41iEVKNKNn9HBG9rRuNtUBXHpmd36Dvm" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::22c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Sep 2014 15:50:15 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Q41iEVKNKNn9HBG9rRuNtUBXHpmd36Dvm Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Committed, thanks. On 11.09.2014 12:27, Michael Chang wrote: > This patch is to get intended output from printf shell command, as the > comma is not used as separator for it's arguments, they will eventually= > be outputted together with the variables. >=20 > Though it does not affect or break any function currently, I'd like to > address this hidden problem and hope to get some attention of it. >=20 > Thanks. > --- > grub-core/osdep/unix/config.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/grub-core/osdep/unix/config.c b/grub-core/osdep/unix/confi= g.c > index f4b0bb4..65effa9 100644 > --- a/grub-core/osdep/unix/config.c > +++ b/grub-core/osdep/unix/config.c > @@ -105,8 +105,8 @@ grub_util_load_config (struct grub_util_config *cfg= ) > *ptr++ =3D *iptr; > } > =20 > - strcpy (ptr, "'; printf \"GRUB_ENABLE_CRYPTODISK=3D%s\\nGRUB_DISTRIB= UTOR=3D%s\\n\", " > - "\"$GRUB_ENABLE_CRYPTODISK\", \"$GRUB_DISTRIBUTOR\""); > + strcpy (ptr, "'; printf \"GRUB_ENABLE_CRYPTODISK=3D%s\\nGRUB_DISTRIB= UTOR=3D%s\\n\" " > + "\"$GRUB_ENABLE_CRYPTODISK\" \"$GRUB_DISTRIBUTOR\""); > =20 > argv[2] =3D script; > argv[3] =3D '\0'; >=20 --Q41iEVKNKNn9HBG9rRuNtUBXHpmd36Dvm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iF4EAREKAAYFAlQe848ACgkQmBXlbbo5nOupXAD8ClYb5DeS3o73+j3t5xuD5TG2 hlHSaFAYGVuTxmjzYWQA/RdXoogP6sPk2aC8XN5DU++aE38C4LMKfG2pbHutUmdM =QPdD -----END PGP SIGNATURE----- --Q41iEVKNKNn9HBG9rRuNtUBXHpmd36Dvm--