From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XVjpZ-0001dd-83 for mharc-grub-devel@gnu.org; Sun, 21 Sep 2014 12:17:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVjpS-0001dN-Tj for grub-devel@gnu.org; Sun, 21 Sep 2014 12:17:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XVjpL-0008Um-5Q for grub-devel@gnu.org; Sun, 21 Sep 2014 12:17:38 -0400 Received: from mail-wg0-x22c.google.com ([2a00:1450:400c:c00::22c]:46326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVjpK-0008Rc-Us for grub-devel@gnu.org; Sun, 21 Sep 2014 12:17:31 -0400 Received: by mail-wg0-f44.google.com with SMTP id z12so1652095wgg.15 for ; Sun, 21 Sep 2014 09:17:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=BhxBFvklGcwk91s2O5mPj51o03ni8GOr3fAqHb4Uo4M=; b=GhVv4HX428P4r8dfzOumlLVfP/m5EHCRKcvGqlZYexra5dBBAs3IhjHbMUEwrwhCqw nGrSQGY/ZfNygvNJLEFDQR6HdfjIcR58MXytQ9h9P4kr+KAJNFqxj51rfRWH86yj3Pi3 8uqifAEWZINqyW976rwR+Ca+3otf8famptD0cqeq/unuwoQVUOlye3b2y+RUZ9UhRr0G nxcNFTJoDP+D+k+KIDJnlrhEhGiY36K/oC6KOHSM5WwmagdngkogxFmhC0lKYQgMA3Ix GgT84CQZOBrilqgoF19RM9bOnWd9eQsARtf/nxDlpfK+XY70dX6CTNzjwudxIIsbk6p0 gEuA== X-Received: by 10.180.97.98 with SMTP id dz2mr8333954wib.26.1411316245199; Sun, 21 Sep 2014 09:17:25 -0700 (PDT) Received: from [192.168.42.4] (160-228.197-178.cust.bluewin.ch. [178.197.228.160]) by mx.google.com with ESMTPSA id am1sm9333584wjc.29.2014.09.21.09.17.23 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Sep 2014 09:17:24 -0700 (PDT) Message-ID: <541EFA0C.8060905@gmail.com> Date: Sun, 21 Sep 2014 18:17:16 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] Fix extraous comma in printf References: <1410431234-26472-1-git-send-email-mchang@suse.com> <541EF38F.4050305@gmail.com> <20140921195848.75ed2a17@opensuse.site> In-Reply-To: <20140921195848.75ed2a17@opensuse.site> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DMwFTSqMtdtA61N71qOxOIoqIfL0AHqJh" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::22c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Sep 2014 16:17:44 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DMwFTSqMtdtA61N71qOxOIoqIfL0AHqJh Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 21.09.2014 17:58, Andrei Borzenkov wrote: > =D0=92 Sun, 21 Sep 2014 17:49:35 +0200 > Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0= =B8=D1=88=D0=B5=D1=82: >=20 >> Committed, thanks. >=20 > You commit contains much more than this single line. Is it intentional?= >=20 No, thank you for noticing this. >> On 11.09.2014 12:27, Michael Chang wrote: >>> This patch is to get intended output from printf shell command, as th= e >>> comma is not used as separator for it's arguments, they will eventual= ly >>> be outputted together with the variables. >>> >>> Though it does not affect or break any function currently, I'd like t= o >>> address this hidden problem and hope to get some attention of it. >>> >>> Thanks. >>> --- >>> grub-core/osdep/unix/config.c | 4 ++-- >>> 1 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/grub-core/osdep/unix/config.c b/grub-core/osdep/unix/con= fig.c >>> index f4b0bb4..65effa9 100644 >>> --- a/grub-core/osdep/unix/config.c >>> +++ b/grub-core/osdep/unix/config.c >>> @@ -105,8 +105,8 @@ grub_util_load_config (struct grub_util_config *c= fg) >>> *ptr++ =3D *iptr; >>> } >>> =20 >>> - strcpy (ptr, "'; printf \"GRUB_ENABLE_CRYPTODISK=3D%s\\nGRUB_DISTR= IBUTOR=3D%s\\n\", " >>> - "\"$GRUB_ENABLE_CRYPTODISK\", \"$GRUB_DISTRIBUTOR\""); >>> + strcpy (ptr, "'; printf \"GRUB_ENABLE_CRYPTODISK=3D%s\\nGRUB_DISTR= IBUTOR=3D%s\\n\" " >>> + "\"$GRUB_ENABLE_CRYPTODISK\" \"$GRUB_DISTRIBUTOR\""); >>> =20 >>> argv[2] =3D script; >>> argv[3] =3D '\0'; >>> >> >> >=20 >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --DMwFTSqMtdtA61N71qOxOIoqIfL0AHqJh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iF4EAREKAAYFAlQe+gwACgkQmBXlbbo5nOvaSAD/acNtRhvDaz4e3CAS+MDG7elP p2u0f7PCvLmXwvd6wo8BAITBct4IFYsykD0GSjsw7IfRvdg/j7UGjN8s3I/xC95U =NG4Q -----END PGP SIGNATURE----- --DMwFTSqMtdtA61N71qOxOIoqIfL0AHqJh--