From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] Fix ACPI halt for certain DSDTs
Date: Sun, 21 Sep 2014 18:59:03 +0200 [thread overview]
Message-ID: <541F03D7.4020501@gmail.com> (raw)
In-Reply-To: <2BBD5AEB-2337-4C89-8ADF-B92BDBD11CBF@unimplemented.org>
[-- Attachment #1: Type: text/plain, Size: 1648 bytes --]
Committed, thanks.
On 03.07.2014 16:00, Valentin Dornauer wrote:
> Thanks for the review, Andrey.
>
> On 2 Jul 2014, at 19:56, Andrey Borzenkov <arvidjaar@gmail.com> wrote:
>>> + in skip_ext_op(), correctly parse OpRegionOp (TermArgs aren't always
>>> + simply strings!); add function to skip TermArgs.
>>
>> It does not really parse every possible value of Type2Opcode, so commit
>> message should probably reflect it.
> Done, I hope it’s clearer now.
>
>>
>>> + case GRUB_ACPI_OPCODE_ADD:
>>> + case GRUB_ACPI_OPCODE_CONCAT:
>>> + case GRUB_ACPI_OPCODE_SUBTRACT:
>>> + case GRUB_ACPI_OPCODE_MULTIPLY:
>>> ...
>>
>> Sort by name?
> Done.
>
>>
>>> + if (add == 0)
>>> + return 0;
>>
>> You use if (!add) in another places. Let's be consistent :)
> Right, done.
>
>>
>>> GRUB_ACPI_OPCODE_NAME = 8, GRUB_ACPI_OPCODE_BYTE_CONST = 0x0a,
>>> + GRUB_ACPI_OPCODE_ALIAS = 0x06,
>>
>> Looks like list is ordered by opcode value, so it should go between
>> GRUB_ACPI_OPCODE_NAME and GRUB_ACPI_OPCODE_BYTE_CONST. Same also next hunk.
> Done.
>
>>
>>> + GRUB_ACPI_OPCODE_CONCATRES = 0x80,
>>
>> In my copy of ACPI spec ConcatRes has opcode 0x84.
> Good catch, don’t know how that slipped through. While verifying the other opcodes
> I stumbled upon some additional opcodes with the same operands: ModOp, IndexOp,
> ToStringOp. I also included them in the new patch set.
>
> - Valentin
>
>
>
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
prev parent reply other threads:[~2014-09-21 17:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 23:55 [PATCH] Fix ACPI halt for certain DSDTs Valentin Dornauer
2014-07-02 17:56 ` Andrey Borzenkov
2014-07-03 14:00 ` Valentin Dornauer
2014-08-19 22:30 ` Valentin Dornauer
2014-09-21 16:59 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541F03D7.4020501@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).