From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XVl29-00037r-Bf for mharc-grub-devel@gnu.org; Sun, 21 Sep 2014 13:34:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVl27-00036I-QY for grub-devel@gnu.org; Sun, 21 Sep 2014 13:34:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XVl27-0007hH-0Q for grub-devel@gnu.org; Sun, 21 Sep 2014 13:34:47 -0400 Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:52544) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVl26-0007gF-Px for grub-devel@gnu.org; Sun, 21 Sep 2014 13:34:46 -0400 Received: by mail-wi0-f178.google.com with SMTP id z2so1756196wiv.17 for ; Sun, 21 Sep 2014 10:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=Vkdk65QLvXnm1wv2ut0TtS/wA6kk0XNHU2giLq8x6V8=; b=TIMb42t3CezRNl0S7kfYQT1YQnRbQpIAhDs1sxzKd2G2wOzQCha65vpUr8Vobrf7eW K6IvagPZUKR5BE6JzTeY5ti0BBq7D5hcjSjXoapfEkP6foH4O7VZL2Y10dVRistE/L4/ UpknMKQpqvsm/MgKVi36iIa5fHA39APwp8u8XLjSDe4DCh4ADVJfc+l4S/MzpV0IhoZ2 6NdLchclOqC/Qvo7VA7TfX/Jq/4m0MFS9TThcahtwGppQG4GWAfY1XEJkicqk5t7JR8B 0OCfnNTsCdgPdSpgkpQvQ9FF9DLjJQx8hAy5FRCSqh1KJRDpgkayXOcEDcHtLKJ/kJYH Rgcg== X-Received: by 10.180.221.107 with SMTP id qd11mr10126913wic.61.1411320881003; Sun, 21 Sep 2014 10:34:41 -0700 (PDT) Received: from ?IPv6:2a02:1205:501d:9350:863a:4bff:fe50:abc4? ([2a02:1205:501d:9350:863a:4bff:fe50:abc4]) by mx.google.com with ESMTPSA id cw6sm9550389wjb.18.2014.09.21.10.34.39 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Sep 2014 10:34:40 -0700 (PDT) Message-ID: <541F03D7.4020501@gmail.com> Date: Sun, 21 Sep 2014 18:59:03 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] Fix ACPI halt for certain DSDTs References: <3DE0DB36-391C-4CC0-8285-7CFDC56287EC@unimplemented.org> <20140702215620.1d67dd4c@opensuse.site> <2BBD5AEB-2337-4C89-8ADF-B92BDBD11CBF@unimplemented.org> In-Reply-To: <2BBD5AEB-2337-4C89-8ADF-B92BDBD11CBF@unimplemented.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0xOI3XPOdfKEvtba9sqDGWKhIwo1M9WLU" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::232 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Sep 2014 17:34:49 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0xOI3XPOdfKEvtba9sqDGWKhIwo1M9WLU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Committed, thanks. On 03.07.2014 16:00, Valentin Dornauer wrote: > Thanks for the review, Andrey. >=20 > On 2 Jul 2014, at 19:56, Andrey Borzenkov wrote: >>> + in skip_ext_op(), correctly parse OpRegionOp (TermArgs aren't alway= s >>> + simply strings!); add function to skip TermArgs. >> >> It does not really parse every possible value of Type2Opcode, so commi= t >> message should probably reflect it. > Done, I hope it=E2=80=99s clearer now. >=20 >> >>> + case GRUB_ACPI_OPCODE_ADD: >>> + case GRUB_ACPI_OPCODE_CONCAT: >>> + case GRUB_ACPI_OPCODE_SUBTRACT: >>> + case GRUB_ACPI_OPCODE_MULTIPLY: >>> ... >> >> Sort by name? > Done. >=20 >> >>> + if (add =3D=3D 0) >>> + return 0; >> >> You use if (!add) in another places. Let's be consistent :) > Right, done. >=20 >> >>> GRUB_ACPI_OPCODE_NAME =3D 8, GRUB_ACPI_OPCODE_BYTE_CONST =3D 0x0a= , >>> + GRUB_ACPI_OPCODE_ALIAS =3D 0x06, >> >> Looks like list is ordered by opcode value, so it should go between >> GRUB_ACPI_OPCODE_NAME and GRUB_ACPI_OPCODE_BYTE_CONST. Same also next = hunk. > Done. >=20 >> >>> + GRUB_ACPI_OPCODE_CONCATRES =3D 0x80, >> >> In my copy of ACPI spec ConcatRes has opcode 0x84. > Good catch, don=E2=80=99t know how that slipped through. While verifyin= g the other opcodes > I stumbled upon some additional opcodes with the same operands: ModOp, = IndexOp, > ToStringOp. I also included them in the new patch set. >=20 > - Valentin >=20 >=20 >=20 >=20 >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --0xOI3XPOdfKEvtba9sqDGWKhIwo1M9WLU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iF4EAREKAAYFAlQfA9cACgkQmBXlbbo5nOvJbQEAmUKsPyz3uNBNUllUIbC9wslc /rK8wJfxJPgAdYPG3tQBAJY1HFNfqx3/qnxl7bRnZoLc+POeQj0TKU0nE8BfJWOv =crOv -----END PGP SIGNATURE----- --0xOI3XPOdfKEvtba9sqDGWKhIwo1M9WLU--