From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XVl20-0002yV-4T for mharc-grub-devel@gnu.org; Sun, 21 Sep 2014 13:34:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVl1x-0002yJ-MP for grub-devel@gnu.org; Sun, 21 Sep 2014 13:34:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XVl1s-0007fH-Hy for grub-devel@gnu.org; Sun, 21 Sep 2014 13:34:37 -0400 Received: from mail-we0-x230.google.com ([2a00:1450:400c:c03::230]:39155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVl1s-0007em-AR for grub-devel@gnu.org; Sun, 21 Sep 2014 13:34:32 -0400 Received: by mail-we0-f176.google.com with SMTP id w61so989493wes.35 for ; Sun, 21 Sep 2014 10:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=YOwpP5iTv4Oyaf55qPcekpyS4mQ/G+tGc/ninOlx0ok=; b=WZMm0j0ZaeL03lXVRHliUtxwnMYXe+Wm3IQBhJJxdiUf1y+5ZgX08OcGtqV40624GQ C1sQA/P75hPLiPUvnItqQoXpE0YLICUuk6Zm8nd46YHm2CAA+3nRQDeFkImTo4nGEF2G OMAFDzt+K5kwDQA7C6ue/+LA1I3vj4mojcEXGRQ6PtnqJudGii7STr8NQeR/yb4hhDls oESFkNgX2bVa4RCWlpKNw7Ac85b013eVtsjlxXGxTIiebUaWJ3R66ps4OHszgmAZBhZK UeOOVaW4oBkMeTgo0WnXtSTBGsTmMZ45nj4nywK0raZ9Nr/qSKGhHM1PQgLTMIk7vkYj Iiig== X-Received: by 10.180.80.198 with SMTP id t6mr3582699wix.6.1411320866527; Sun, 21 Sep 2014 10:34:26 -0700 (PDT) Received: from ?IPv6:2a02:1205:501d:9350:863a:4bff:fe50:abc4? ([2a02:1205:501d:9350:863a:4bff:fe50:abc4]) by mx.google.com with ESMTPSA id pk9sm9555709wjb.16.2014.09.21.10.34.25 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Sep 2014 10:34:25 -0700 (PDT) Message-ID: <541F061D.9090409@gmail.com> Date: Sun, 21 Sep 2014 19:08:45 +0200 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] grub-mkrescue: remove temporary load_cfg file References: <1398961019-29913-1-git-send-email-arvidjaar@gmail.com> In-Reply-To: <1398961019-29913-1-git-send-email-arvidjaar@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dl0LQIEGfX1xo5jCwbW0LWWBkDQPjfVK3" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c03::230 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Sep 2014 17:34:38 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dl0LQIEGfX1xo5jCwbW0LWWBkDQPjfVK3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I actually like to have load.cfg around: it helps with debugging in some cases. Do you have a reason to remove it? On 01.05.2014 18:16, Andrey Borzenkov wrote: > --- > util/grub-mkrescue.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/util/grub-mkrescue.c b/util/grub-mkrescue.c > index e719839..c3d9b32 100644 > --- a/util/grub-mkrescue.c > +++ b/util/grub-mkrescue.c > @@ -323,6 +323,7 @@ make_image_fwdisk_abs (enum grub_install_plat plat,= > grub_install_make_image_wrap (source_dirs[plat], "()/boot/grub", out= put, > 0, load_cfg, mkimage_target, 0); > grub_install_pop_module (); > + grub_util_unlink (load_cfg); > } > =20 > static int > @@ -566,6 +567,7 @@ main (int argc, char *argv[]) > } > grub_install_pop_module (); > grub_install_pop_module (); > + grub_util_unlink (load_cfg); > } > =20 > /** build multiboot core.img */ >=20 --dl0LQIEGfX1xo5jCwbW0LWWBkDQPjfVK3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iF4EAREKAAYFAlQfBh0ACgkQmBXlbbo5nOulkgEAmwg0gwqYs1ROtiKaCCSMucxR S7AldGhzYdsh9QXBx68BAJM7evuGBfAKTMV41xAWgzah1uApuI1ItNC1I2ODSecY =vXPt -----END PGP SIGNATURE----- --dl0LQIEGfX1xo5jCwbW0LWWBkDQPjfVK3--