From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XxetQ-0002Gu-Cv for mharc-grub-devel@gnu.org; Sun, 07 Dec 2014 11:41:08 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XxetJ-0002FS-Pr for grub-devel@gnu.org; Sun, 07 Dec 2014 11:41:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XxetE-0003jF-9s for grub-devel@gnu.org; Sun, 07 Dec 2014 11:41:01 -0500 Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]:52544) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xxedm-0006io-60 for grub-devel@gnu.org; Sun, 07 Dec 2014 11:24:58 -0500 Received: by mail-wg0-f48.google.com with SMTP id y19so4484789wgg.7 for ; Sun, 07 Dec 2014 08:24:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=VvnVF7uUCU1U09d0uDVJc7KtqPc67mWQp6m+ytFHpS8=; b=MQAOXPnx0+o+AQte1/Z8EbMYQLwLiHLzs6DccbDx7WqfzaEbXUcrT8iE1ymVF0A1E3 dExKuYr8buJAjuS6w8szJq+d0pvJ+SmodJdv5bsqHneDskihtPCekd57D9fc9PdIr3d3 2g2NQ8X/ls34zh1gT7HEtS9q2p+JtACe+3PtEEvvkUrRXbsCnQ/wu0LpVJhQzyiNd8yh jAEKKjwY8xh8iEO6kVCgyUezAWMIXUS3q9uxrzaibFpMsWEV+JDy0+xPnlakIw8fKH/K 4N7MwFfblRIV/nwZvoN3O6Et2+j8xCnagKnHCgPkeWcwPAP/uyRluQahJXE37gUPkKHL E6WQ== X-Received: by 10.194.82.97 with SMTP id h1mr25908476wjy.116.1417969496406; Sun, 07 Dec 2014 08:24:56 -0800 (PST) Received: from [192.168.42.182] (130-226.197-178.cust.bluewin.ch. [178.197.226.130]) by mx.google.com with ESMTPSA id pu3sm53124937wjc.14.2014.12.07.08.24.51 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 Dec 2014 08:24:52 -0800 (PST) Message-ID: <54847F51.8030801@gmail.com> Date: Sun, 07 Dec 2014 17:24:49 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: grub-core/osdep/unix/hostdisk.c: remove support for ancient glibc References: <20141121200040.GA4858@euler> <5478CA6D.9020904@gmail.com> <20141204222109.GA30539@euler> In-Reply-To: <20141204222109.GA30539@euler> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jLDarFXcmQw7onfeKhFsEmRUSHPLadEWq" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c00::230 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Dec 2014 16:41:07 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jLDarFXcmQw7onfeKhFsEmRUSHPLadEWq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04.12.2014 23:21, Felix Janda wrote: > On 28.11.2014, Vladimir '=CF=86-coder/phcoder' Serbinenko wrote: >> On 21.11.2014 22:00, Felix Janda wrote: >>> Hello, >>> >>> the file grub-core/osdep/unix/hostdisk.c has special code for glibc<2= =2E1, >>> which gets also pulled in for other libcs (such as musl libc) and mak= es >>> compilation fail for them because the code uses glibc internals. The >>> easiest way to fix is just to remove the code as the below patch does= =2E >>> >> Don't assume that nobody will try to compile with ancient glibc. If yo= u >> want to raise the supported version for glibc you need to add a >> configure check for presence of long offsets to configure and fail it = if >> it's not available. It should also be documented in INSTALL. >=20 > Before messing around with configure.ac, I'd like know whether a patch > (correctly) implementing what you suggest would be accepted. >=20 Yes, I'll accept removing this clause as long as failure on ./configure time is clear in case of no long-files available. > Another solution I would be happy with, is to change the conditions >=20 > # if !defined(__GLIBC__) || \ > ((__GLIBC__ < 2) || ((__GLIBC__ =3D=3D 2) && (__GLIBC_MINOR__ <= 1))) >=20 > to >=20 > # ((__GLIBC__ < 2) || ((__GLIBC__ =3D=3D 2) && (__GLIBC_MINOR__ < 1))) >=20 > Felix >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >=20 --jLDarFXcmQw7onfeKhFsEmRUSHPLadEWq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iF4EAREKAAYFAlSEf1IACgkQmBXlbbo5nOswMQD+NWzoEaIMnxYGDadDH7qj0i3l Ukw0SuMKEE1wbv51DdcA/RY5CkIkzzHOsRY9W2CleZOkg96G2xo5BkKG/IxA5J2c =QQMS -----END PGP SIGNATURE----- --jLDarFXcmQw7onfeKhFsEmRUSHPLadEWq--