grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Fu Wei <fu.wei@linaro.org>
To: grub-devel@gnu.org, Leif Lindholm <leif.lindholm@linaro.org>,
	 Ian Campbell <Ian.Campbell@citrix.com>
Cc: Roy Franz <roy.franz@linaro.org>, Jon Masters <jcm@redhat.com>,
	linaro-uefi <linaro-uefi@lists.linaro.org>
Subject: [PATCH 3/5] arm64: Remove "loaded" checking in the grub_cmd_devicetree of linux.c
Date: Fri, 19 Dec 2014 02:06:44 +0800	[thread overview]
Message-ID: <549317B4.6080606@linaro.org> (raw)

       Reason: (1)we don't need the check, actually
               (2)it is a prerequisite for multiboot support

Signed-off-by: Fu Wei <fu.wei@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
---
 grub-core/loader/arm64/linux.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/grub-core/loader/arm64/linux.c b/grub-core/loader/arm64/linux.c
index 987f5b9..e9e9a29 100644
--- a/grub-core/loader/arm64/linux.c
+++ b/grub-core/loader/arm64/linux.c
@@ -185,13 +185,6 @@ grub_cmd_devicetree (grub_command_t cmd __attribute__ ((unused)),
   void *blob = NULL;
   int size;
 
-  if (!loaded)
-    {
-      grub_error (GRUB_ERR_BAD_ARGUMENT,
-		  N_("you need to load the kernel first"));
-      return GRUB_ERR_BAD_OS;
-    }
-
   if (argc != 1)
     return grub_error (GRUB_ERR_BAD_ARGUMENT, N_("filename expected"));
 
-- 
1.8.3.1


             reply	other threads:[~2014-12-18 18:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-18 18:06 Fu Wei [this message]
2015-05-07 13:21 ` [PATCH 3/5] arm64: Remove "loaded" checking in the grub_cmd_devicetree of linux.c Vladimir 'φ-coder/phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=549317B4.6080606@linaro.org \
    --to=fu.wei@linaro.org \
    --cc=Ian.Campbell@citrix.com \
    --cc=grub-devel@gnu.org \
    --cc=jcm@redhat.com \
    --cc=leif.lindholm@linaro.org \
    --cc=linaro-uefi@lists.linaro.org \
    --cc=roy.franz@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).