From: Phillip Susi <psusi@ubuntu.com>
To: grub-devel@gnu.org
Cc: phcoder@gmail.com
Subject: Re: Do not use O_SYNC
Date: Mon, 05 Jan 2015 14:07:47 -0500 [thread overview]
Message-ID: <54AAE103.1000007@ubuntu.com> (raw)
In-Reply-To: <20130320141559.00AA942DD2@iriserv.iradimed.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Little old, but seems this was lost. The relevant code seems to have
been moved to osdep/hostfile_unix.h, but it is still using O_SYNC and
I really don't see any reason why it should. Can we please get rid of
this?
On 3/20/2013 10:15 AM, Phillip Susi wrote:
> revno: 164 committer: Phillip Susi <psusi@ubuntu.com> branch nick:
> raring timestamp: Wed 2013-03-20 10:00:03 -0400 message: Do not use
> O_SYNC
>
> The disk was being opened with O_SYNC, and written to one sector at
> a time. This has a huge time penalty, causing at least one
> revolution of the disk per sector written. diff: === modified file
> 'grub-core/kern/emu/hostdisk.c' --- grub-core/kern/emu/hostdisk.c
> 2012-09-27 16:16:51 +0000 +++ grub-core/kern/emu/hostdisk.c
> 2013-03-20 14:00:03 +0000 @@ -848,9 +848,6 @@ #ifdef O_LARGEFILE
> flags |= O_LARGEFILE; #endif -#ifdef O_SYNC - flags |= O_SYNC;
> -#endif #ifdef O_FSYNC flags |= O_FSYNC; #endif
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
iQEcBAEBAgAGBQJUquEDAAoJENRVrw2cjl5RDW4H/2U8ICjqHovw8C/s+CFg7smW
q4/Wqpj8bEXHThL3yO+88cTB3q3I2/TGsunq/g4IsFqda3buXrRunHOg7IcNQQhy
JPSBWX7ucsFvi97bAwyh/iqns3MOlJlmnAGpM6yfwYPpyZOaCkU7ulJP0Hopc3LT
+JAq5V3V64GcknjbYhlvWB8K+eXaZ2s0NoIXAFA/ewhi7CQVE22PeQEhxH9rRbKQ
Or4FbGsoFwi+SL4PNuPShp+4H/sg8ewDA/gIVSjsThp9c3whq+nnGhVt28GfLZBc
1KtyeJCJ5HeKOgqzSh7BleUdxtApxFsUU2Fz5M/zyV6f5MidKfHlm8B65sUc+xM=
=HJul
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2015-01-05 19:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 15:05 Everything and the kitchen sink Phillip Susi
2013-02-14 15:48 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-02-14 19:34 ` Phillip Susi
2013-02-14 20:44 ` O_SYNC Phillip Susi
2013-03-20 14:15 ` Do not use O_SYNC Phillip Susi
2015-01-05 19:07 ` Phillip Susi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AAE103.1000007@ubuntu.com \
--to=psusi@ubuntu.com \
--cc=grub-devel@gnu.org \
--cc=phcoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).