From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Y8D0t-0005cD-1G for mharc-grub-devel@gnu.org; Mon, 05 Jan 2015 14:08:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8D0q-0005ax-KK for grub-devel@gnu.org; Mon, 05 Jan 2015 14:08:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8D0m-0000Uh-Hn for grub-devel@gnu.org; Mon, 05 Jan 2015 14:08:24 -0500 Received: from mail-qa0-x235.google.com ([2607:f8b0:400d:c00::235]:47650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8D0m-0000UN-EY for grub-devel@gnu.org; Mon, 05 Jan 2015 14:08:20 -0500 Received: by mail-qa0-f53.google.com with SMTP id j7so15224317qaq.26 for ; Mon, 05 Jan 2015 11:08:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=T4oC9LJA49RlnPrKnEcbWPrRBK8Wxd8iH9kC/4dwP9A=; b=UxUiWFXZiRA0M9I/WGhQkcduGNRY3jkr3qX7iCh0MYNnvk5w4Wb+9oCbgBI+ASkDuZ O8IA7wPJqSPUiUaWGr7+jtfO947FdV5+x2vP6xk0/rq7LqHJOqeLdIDbpWP1yJxlk56r /gyIFxKx2y6WXaBbZCKPga4AK9nIHB0tjj5Me6GZMyBl4ky7rvRe0qqzW/Q2xkepz6xr UMnV8oPxlqM36/G0vNdlpQCkbNr1rvVheFcfnD0CE1LcS/fCRDAaplw2bitFfLHwFx7i YfB4wo09FmTf/wFmmtd+lK52RjnLDH5c5hs3660yUe9Vz1GqMlvtpMdLXlfCTbqJ/ugk bmkQ== X-Received: by 10.224.26.4 with SMTP id b4mr46715332qac.26.1420484899139; Mon, 05 Jan 2015 11:08:19 -0800 (PST) Received: from [10.1.1.151] (fl-67-77-88-12.sta.embarqhsd.net. [67.77.88.12]) by mx.google.com with ESMTPSA id y20sm21454266qgd.35.2015.01.05.11.08.18 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Jan 2015 11:08:18 -0800 (PST) Sender: Phillip Susi Message-ID: <54AAE103.1000007@ubuntu.com> Date: Mon, 05 Jan 2015 14:07:47 -0500 From: Phillip Susi User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: Do not use O_SYNC References: <20130320141559.00AA942DD2@iriserv.iradimed.com> In-Reply-To: <20130320141559.00AA942DD2@iriserv.iradimed.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400d:c00::235 Cc: phcoder@gmail.com X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jan 2015 19:08:25 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Little old, but seems this was lost. The relevant code seems to have been moved to osdep/hostfile_unix.h, but it is still using O_SYNC and I really don't see any reason why it should. Can we please get rid of this? On 3/20/2013 10:15 AM, Phillip Susi wrote: > revno: 164 committer: Phillip Susi branch nick: > raring timestamp: Wed 2013-03-20 10:00:03 -0400 message: Do not use > O_SYNC > > The disk was being opened with O_SYNC, and written to one sector at > a time. This has a huge time penalty, causing at least one > revolution of the disk per sector written. diff: === modified file > 'grub-core/kern/emu/hostdisk.c' --- grub-core/kern/emu/hostdisk.c > 2012-09-27 16:16:51 +0000 +++ grub-core/kern/emu/hostdisk.c > 2013-03-20 14:00:03 +0000 @@ -848,9 +848,6 @@ #ifdef O_LARGEFILE > flags |= O_LARGEFILE; #endif -#ifdef O_SYNC - flags |= O_SYNC; > -#endif #ifdef O_FSYNC flags |= O_FSYNC; #endif -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (MingW32) iQEcBAEBAgAGBQJUquEDAAoJENRVrw2cjl5RDW4H/2U8ICjqHovw8C/s+CFg7smW q4/Wqpj8bEXHThL3yO+88cTB3q3I2/TGsunq/g4IsFqda3buXrRunHOg7IcNQQhy JPSBWX7ucsFvi97bAwyh/iqns3MOlJlmnAGpM6yfwYPpyZOaCkU7ulJP0Hopc3LT +JAq5V3V64GcknjbYhlvWB8K+eXaZ2s0NoIXAFA/ewhi7CQVE22PeQEhxH9rRbKQ Or4FbGsoFwi+SL4PNuPShp+4H/sg8ewDA/gIVSjsThp9c3whq+nnGhVt28GfLZBc 1KtyeJCJ5HeKOgqzSh7BleUdxtApxFsUU2Fz5M/zyV6f5MidKfHlm8B65sUc+xM= =HJul -----END PGP SIGNATURE-----