From: Kris Moore <kris@pcbsd.org>
To: grub-devel@gnu.org
Subject: Patch to fix kldstat(2) / dtrace when booting FreeBSD
Date: Fri, 09 Jan 2015 11:31:26 -0500 [thread overview]
Message-ID: <54B0025E.4020407@pcbsd.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 433 bytes --]
The following patch fixes an important issue when booting FreeBSD.
FreeBSD's kldstat(2) function expects that the full pathname will be
provided to kernel / modules. The current GRUB was striping this out and
only leaving the filename itself. This broke dtrace and other things
which used the full pathname to locate the kernel or modules on disk.
The attached patch fixes this behavior.
--
Kris Moore
PC-BSD Software
iXsystems
[-- Attachment #2: patch-grub-core_loader_i386_bsd.c --]
[-- Type: text/x-csrc, Size: 749 bytes --]
diff --git a/grub-core/loader/i386/bsd.c b/grub-core/loader/i386/bsd.c
index 8f691e0..fb47969 100644
--- a/grub-core/loader/i386/bsd.c
+++ b/grub-core/loader/i386/bsd.c
@@ -415,11 +415,15 @@ grub_freebsd_add_meta_module (const char *filename, const char *type,
grub_addr_t addr, grub_uint32_t size)
{
const char *name;
- name = grub_strrchr (filename, '/');
+ /* Don't strip the full path, some FreeBSD functionality, such
+ * as kldstat(2) / dtrace, rely on this. Instead we only need to remove
+ * any ZFS dataset information first. */
+ name = grub_strrchr (filename, '@');
if (name)
name++;
else
name = filename;
+
if (grub_strcmp (type, "/boot/zfs/zpool.cache") == 0)
name = "/boot/zfs/zpool.cache";
next reply other threads:[~2015-01-09 16:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 16:31 Kris Moore [this message]
2015-01-11 18:27 ` Patch to fix kldstat(2) / dtrace when booting FreeBSD Andrei Borzenkov
2015-01-12 16:11 ` Kris Moore
2015-01-22 19:12 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B0025E.4020407@pcbsd.org \
--to=kris@pcbsd.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).