From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YEMwK-0002AA-CI for mharc-grub-devel@gnu.org; Thu, 22 Jan 2015 13:57:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEMwH-00029U-Im for grub-devel@gnu.org; Thu, 22 Jan 2015 13:57:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEMwF-0004kb-7r for grub-devel@gnu.org; Thu, 22 Jan 2015 13:57:09 -0500 Received: from mail-we0-x22e.google.com ([2a00:1450:400c:c03::22e]:33008) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEMwE-0004kU-Vw for grub-devel@gnu.org; Thu, 22 Jan 2015 13:57:07 -0500 Received: by mail-we0-f174.google.com with SMTP id x3so3533498wes.5 for ; Thu, 22 Jan 2015 10:57:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=jL6P0itAN2zT2tV8eLelM57Z+Ap1wwXHoetlLQwajBE=; b=Gd4IvAMbrP8Sb4bAd7FN6yd+LoPcss6ek05+SZLVQpUk4uNE6ef4OQy/42/1NDha6S t8Y4zr4iVTcSqIjhyKE977EO7fZxY02dtyJpdZhyyxMGzfqWyyjKzP2YSMt8DvnF9Rcb c0G3LgiOOZlhi/Fv0TJgkrp0lx9bChraNFkfqCjSQkTLwEEtael6UVhHTTZZGfB8+ytA uhKa01Zo6nny/P98Jhb5f3hXILWTsVvBhxH8xBR9RvSTVqsjpVYVxw2RX24LnERMEh5J W1hY6PYSo3KQ0EDDGaFpZDqcKmekybu6eq1E4YK5bUfkkgHIIeMggRDEm3PDBs1yRDZM cyPg== X-Received: by 10.180.103.201 with SMTP id fy9mr37410663wib.31.1421953025596; Thu, 22 Jan 2015 10:57:05 -0800 (PST) Received: from ?IPv6:2620:0:105f:fd00:c6e9:2fff:fe57:96ed? ([2620:0:105f:fd00:c6e9:2fff:fe57:96ed]) by mx.google.com with ESMTPSA id ud4sm4180926wib.0.2015.01.22.10.57.04 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jan 2015 10:57:04 -0800 (PST) Message-ID: <54C147F4.9030506@gmail.com> Date: Thu, 22 Jan 2015 19:56:52 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] On linux require the libc to have large file support References: <20150117135706.GA23804@euler> <20150118205320.14a5945f@opensuse.site> <20150118181107.GA6322@euler> <20150118181807.GA16297@euler> In-Reply-To: <20150118181807.GA16297@euler> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lSFdNCeAKFjqBf8un3rv1gaJrLv8qesgI" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c03::22e X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jan 2015 18:57:11 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lSFdNCeAKFjqBf8un3rv1gaJrLv8qesgI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 18.01.2015 19:18, Felix Janda wrote: > Felix Janda wrote: >> Andrei Borzenkov wrote: >>> =D0=92 Sat, 17 Jan 2015 14:57:07 +0100 >>> Felix Janda =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> >>>> With this, support code in grub-core/osdep/unix/hostdisk.c >>>> for old glibc releases could be removed. >>>> --- >>>> This patch tries to address the issues raised in >>>> >>>> http://lists.gnu.org/archive/html/grub-devel/2014-12/msg00030.html >>>> --- >>>> INSTALL | 1 + >>>> configure.ac | 5 +++++ >>>> grub-core/osdep/unix/hostdisk.c | 25 ------------------------- >>>> 3 files changed, 6 insertions(+), 25 deletions(-) >>>> >>>> diff --git a/INSTALL b/INSTALL >>>> index b67cd7f..ac7c2aa 100644 >>>> --- a/INSTALL >>>> +++ b/INSTALL >>>> @@ -39,6 +39,7 @@ configuring the GRUB. >>>> On GNU/Linux, you also need: >>>> =20 >>>> * libdevmapper 1.02.34 or later (recommended) >>>> +* a libc with large file support (e.g. glibc 2.1 or later) >>>> =20 >>>> For optional grub-emu features, you need: >>>> =20 >>>> diff --git a/configure.ac b/configure.ac >>>> index 31d2b0b..bdaebb8 100644 >>>> --- a/configure.ac >>>> +++ b/configure.ac >>>> @@ -346,6 +346,11 @@ AC_GNU_SOURCE >>>> AM_GNU_GETTEXT([external]) >>>> AC_SYS_LARGEFILE >>>> =20 >>>> +if test x"$host_kernel" =3D xlinux ; then >>> >>> I wonder if we should do it unconditionally. Large files support is >>> really presumed by current code. >>> >>> Not for now, but something to keep in mind for next version. >> >> Yes, the test is not ideal. But enabling it for everything would >> break cygwin. (There sizeof(off_t)=3D4 and the windows hostdisk.c is >> used.) >=20 I've put all windows flavours and AROS on whitelist. Everything else requires long-filesystem libc. Thank you for the patch. Actually there may be a way to make mingw have long off_t, perhaps some define. If so, it would be better to add it and keep only AROS on whiteli= st. > Sorry, that should be mingw. I've taken this from >=20 > http://stackoverflow.com/questions/18908557/how-to-enable-largefile-sup= port-on-windows-using-mingw-autotools >=20 >> >> It was not obvious for me how to detect all architectures that >> build grub-core/osdep/unix/hostdisk.c. It would also be possible >> to put something like >> >> int get_a_libc_with_lfs_support[sizeof(off_t)-8]; >> >> into grub-core/osdep/unix/hostdisk.c making at least the build fail >> for the right architectures. >> >>>> + AC_CHECK_SIZEOF(off_t) >>>> + test x"$ac_cv_sizeof_off_t" =3D x8 || AC_MSG_ERROR([Large file su= pport is required]) >>>> +fi >>>> + >>>> # Identify characteristics of the host architecture. >>>> unset ac_cv_c_bigendian >>>> =20 >>>> [..] >=20 --lSFdNCeAKFjqBf8un3rv1gaJrLv8qesgI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iF4EAREKAAYFAlTBSAAACgkQmBXlbbo5nOsTAAEAkPtvSzlr88gVC6ddgXd241gn HOCeMl4K4l20xyAW2oAA/2OoeqBqhWbkKOJR5kMqnV/XUG8VO8jSzDR/ScwSIR0Q =6k2S -----END PGP SIGNATURE----- --lSFdNCeAKFjqBf8un3rv1gaJrLv8qesgI--