From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: grub-devel@gnu.org
Subject: Re: Deterministic grub-mkimage
Date: Thu, 22 Jan 2015 21:08:51 +0100 [thread overview]
Message-ID: <54C158D3.9090806@gmail.com> (raw)
In-Reply-To: <CAAXZBWJTjoh7iQD-7AgNAxSMxLbzeMhposW9A5Dup2nZKy1nQw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]
On 29.12.2014 12:08, Andrew Clausen wrote:
> Hi Jonathan,
>
> On 29 December 2014 at 06:29, Jonathan McCune <jonmccune@google.com> wrote:
>>> One solution would be to:
>>> * build deterministically by default by using a constant timestamp, and
>>
>> I think doing this by default would be a poor choice, as most of the time
>> during development it is very useful to easily identify which version /
>> build / experiment / etc is in use.
>
> I agree that during development, timestamps might be useful. Although
> I've never found them particularly helpful myself -- they aren't as
> easy as, say, having a text file sitting in the same directory saying
> which git commit it is. In fact, including the git commit somewhere
> in the binary would be both more helpful and deterministic. (I am
> happy to supply a patch for this.) Have you ever used time stamps?
>
We already have modinfo.sh. It would be a good place to put commit. In
fact it already includes version. The best would be to add
+g<commit>[-dirty] to version when building from git.
My main concern is that EFI itself might use the timestamp for some
weird caching but this shouldn't be the case. Other than that I'd be ok
with hardcoding it to unix time
1420070400 (Jan 1, 2015, midnight UTC)
Can you prepare the patches for both things?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
next prev parent reply other threads:[~2015-01-22 20:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-28 11:24 Deterministic grub-mkimage Andrew Clausen
2014-12-29 6:29 ` Jonathan McCune
2014-12-29 11:08 ` Andrew Clausen
2014-12-29 19:01 ` Jonathan McCune
2015-01-22 20:08 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2015-03-22 19:33 ` [PATCH] use stock embedded timestamp 2015-01-01T0000+0000 Daniel Kahn Gillmor
2015-03-27 12:27 ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-03-28 16:04 ` Daniel Kahn Gillmor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C158D3.9090806@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).