grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: Does grub-mkrescue support UEFI hybrid USB/DVD images?
Date: Thu, 22 Jan 2015 23:15:28 +0100	[thread overview]
Message-ID: <54C17680.9080804@gmail.com> (raw)
In-Reply-To: <54C16AD2.7090808@pcbsd.org>

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

On 22.01.2015 22:25, Kris Moore wrote:
> 
> Hey all,
> 
> We are trying to create hybrid USB/DVD images, and they work just fine
> on BIOS. However it doesn't seem to work when creating UEFI.
> 
Try this:
diff --git a/grub-core/disk/efi/efidisk.c b/grub-core/disk/efi/efidisk.c
index 3b12c34..983afdb 100644
--- a/grub-core/disk/efi/efidisk.c
+++ b/grub-core/disk/efi/efidisk.c
@@ -862,9 +862,7 @@ grub_efidisk_get_device_name (grub_efi_handle_t *handle)
          if (! ctx.partition_name)
            {
              grub_disk_close (parent);
-             if (is_cdrom)
-               return grub_strdup (device_name);
-             return 0;
+             return grub_strdup (device_name);
            }

          dev_name = grub_xasprintf ("%s,%s", parent->name,



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 213 bytes --]

  reply	other threads:[~2015-01-22 22:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-22 21:25 Does grub-mkrescue support UEFI hybrid USB/DVD images? Kris Moore
2015-01-22 22:15 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
2015-01-23  9:40   ` Andrei Borzenkov
2015-01-23  9:45     ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-01-23 10:10       ` Andrei Borzenkov
2015-01-23 10:14       ` Thomas Schmitt
2015-01-23 14:40         ` Kris Moore
2015-01-23 16:18           ` Thomas Schmitt
2015-01-23 17:58       ` Andrei Borzenkov
2015-01-23 18:27         ` Thomas Schmitt
2015-01-23 18:29         ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-01-23 18:38           ` Andrei Borzenkov
2015-01-23 19:03             ` Andrei Borzenkov
2015-01-24  0:12 ` adrian15
2015-01-25  8:03   ` adrian15
2015-01-25  8:15     ` adrian15
2015-01-25 10:51       ` adrian15

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C17680.9080804@gmail.com \
    --to=phcoder@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).